From joe.darcy at oracle.com Fri May 5 22:11:39 2017 From: joe.darcy at oracle.com (joe darcy) Date: Fri, 5 May 2017 15:11:39 -0700 Subject: Selection of screened and imported JDK 9 ccc requests available to view in CCC project of JBS Message-ID: <615ffc04-6cdb-5cff-3832-220b0c535ac2@oracle.com> Hello, Over 80 approved ccc requests against JDK 9 have been imported and screened and are are available for viewing as CSR issues in the CCC project of JBS: https://bugs.openjdk.java.net/issues/?jql=project%20%3D%20ccc These imported issues range across different components of the JDK and range over several orders of magnitude of changes. Thanks to the CSR members and others who did the screening. (After JDK 9 goes GA, these issues will be moved from a separate CCC project into the JDK project. After the move, "CCC-8123456" in JBS will redirect to the new issue number in the JDK project.) Please take a look at the imported issues, run some queries, etc. Assuming no show-stopper problems are observed, I'd like to go live with CSR for JDK 10 shortly after May 12, 2017. Thanks, -Joe From dl at cs.oswego.edu Tue May 9 14:55:04 2017 From: dl at cs.oswego.edu (Doug Lea) Date: Tue, 9 May 2017 10:55:04 -0400 Subject: Selection of screened and imported JDK 9 ccc requests available to view in CCC project of JBS In-Reply-To: <615ffc04-6cdb-5cff-3832-220b0c535ac2@oracle.com> References: <615ffc04-6cdb-5cff-3832-220b0c535ac2@oracle.com> Message-ID: <962a621e-6f85-310e-a7b2-504579044610@cs.oswego.edu> On 05/05/2017 06:11 PM, joe darcy wrote: > Hello, > > Over 80 approved ccc requests against JDK 9 have been imported and > screened and are are available for viewing as CSR issues in the CCC > project of JBS: > > https://bugs.openjdk.java.net/issues/?jql=project%20%3D%20ccc > Thanks. It would be nice to extract from these some example wordings (maybe someday a checklist) that people can use in the "Compatibility Risk Description", which will be new to some developers, who might otherwise get stuck characterizing this. On a quick scan though, the only one that seems to recur enough to mention is "Spec clarification to match original/current behavior". Probably ex-CCC members can come up with some others? (Otherwise, everything looks good so far.) -Doug From joe.darcy at oracle.com Tue May 16 18:31:37 2017 From: joe.darcy at oracle.com (joe darcy) Date: Tue, 16 May 2017 11:31:37 -0700 Subject: Selection of screened and imported JDK 9 ccc requests available to view in CCC project of JBS In-Reply-To: <615ffc04-6cdb-5cff-3832-220b0c535ac2@oracle.com> References: <615ffc04-6cdb-5cff-3832-220b0c535ac2@oracle.com> Message-ID: Hello, The preview of the imported ccc requests went fine. For scheduling purposes, I'm aiming for us to go live with CSRs review for JDK 10 starting next week, the week of May 22. Thanks, -Joe On 5/5/2017 3:11 PM, joe darcy wrote: > Hello, > > Over 80 approved ccc requests against JDK 9 have been imported and > screened and are are available for viewing as CSR issues in the CCC > project of JBS: > > https://bugs.openjdk.java.net/issues/?jql=project%20%3D%20ccc > > These imported issues range across different components of the JDK and > range over several orders of magnitude of changes. Thanks to the CSR > members and others who did the screening. > > (After JDK 9 goes GA, these issues will be moved from a separate CCC > project into the JDK project. After the move, "CCC-8123456" in JBS > will redirect to the new issue number in the JDK project.) > > Please take a look at the imported issues, run some queries, etc. > Assuming no show-stopper problems are observed, I'd like to go live > with CSR for JDK 10 shortly after May 12, 2017. > > Thanks, > > -Joe > From chenyt at cs.sjtu.edu.cn Wed May 17 21:08:14 2017 From: chenyt at cs.sjtu.edu.cn (=?gb2312?B?s8LT6s2k?=) Date: Wed, 17 May 2017 14:08:14 -0700 Subject: What is a structured locking in the JVM specification? Message-ID: <004c01d2cf51$b4237950$1c6a6bf0$@cs.sjtu.edu.cn> According to the definition, it seems that a structured locking appears like: Monitorenter r0; ?monitorenter r0; ?? monitorexit r0; ?monitorexit r0; * The definition is given as follows: Structured locking is the situation when, during a method invocation, every exit on a given monitor matches a preceding entry on that monitor. (https://docs.oracle.com/javase/specs/jvms/se8/html/jvms-2.html#jvms-2.11.10 ) I?m a little curious whether a structured locking can be composed by the following instructions: Monitorenter r0; monitorenter r2; ?? monitorexit r0; monitorexit r2; In addition, should this sequence be accepted or rejected? At runtime or during the verification time? Yuting From chenyt at cs.sjtu.edu.cn Thu May 18 00:00:12 2017 From: chenyt at cs.sjtu.edu.cn (=?gb2312?B?s8LT6s2k?=) Date: Wed, 17 May 2017 17:00:12 -0700 Subject: =?gb2312?B?tPC4tDogV2hhdCBpcyBhIHN0cnVjdHVyZWQgbG9ja2luZyBpbiB0aA==?= =?gb2312?B?ZSBKVk0gc3BlY2lmaWNhdGlvbj8=?= In-Reply-To: <004c01d2cf51$b4237950$1c6a6bf0$@cs.sjtu.edu.cn> References: <004c01d2cf51$b4237950$1c6a6bf0$@cs.sjtu.edu.cn> Message-ID: <000201d2cf69$ba8c2c70$2fa48550$@cs.sjtu.edu.cn> The original explanation is given as: "Structured locking is the situation when, during a method invocation, every exit on a given monitor matches a preceding entry on that monitor. Since there is no assurance that all code submitted to the Java Virtual Machine will perform structured locking, implementations of the Java Virtual Machine are permitted but not required to enforce both of the following two rules guaranteeing structured locking. Let T be a thread and M be a monitor. Then: (1) The number of monitor entries performed by T on M during a method invocation must equal the number of monitor exits performed by T on M during the method invocation whether the method invocation completes normally or abruptly. (2) At no point during a method invocation may the number of monitor exits performed by T on M since the method invocation exceed the number of monitor entries performed by T on M since the method invocation." I retested some programs on HotSpot and IBM's J9. It seems that HotSpot takes Rule 1 (rule1 is stricter than rule2, and J9 throws out an IllegalMonitorStateException at runtime) and J9 only takes Rule 2 (accepting the program). As the exception can be caught (with further exception handlings), some of my programs run quite differently on the two platforms. f(){ monitorenter r0; } g(){ f(); monitorexit r0; } -----????----- ???: csr-discuss [mailto:csr-discuss-bounces at openjdk.java.net] ?? ?? ? ????: 2017?5?17? 14:08 ???: csr-discuss at openjdk.java.net ??: What is a structured locking in the JVM specification? According to the definition, it seems that a structured locking appears like: Monitorenter r0; ?monitorenter r0; ?? monitorexit r0; ?monitorexit r0; * The definition is given as follows: Structured locking is the situation when, during a method invocation, every exit on a given monitor matches a preceding entry on that monitor. (https://docs.oracle.com/javase/specs/jvms/se8/html/jvms-2.html#jvms-2.11.10 ) I?m a little curious whether a structured locking can be composed by the following instructions: Monitorenter r0; monitorenter r2; ?? monitorexit r0; monitorexit r2; In addition, should this sequence be accepted or rejected? At runtime or during the verification time? Yuting From joe.darcy at oracle.com Thu May 18 00:15:12 2017 From: joe.darcy at oracle.com (joe darcy) Date: Wed, 17 May 2017 17:15:12 -0700 Subject: =?UTF-8?Q?Re:_=e7=ad=94=e5=a4=8d:_What_is_a_structured_locking_in_t?= =?UTF-8?Q?he_JVM_specification=3f?= In-Reply-To: <000201d2cf69$ba8c2c70$2fa48550$@cs.sjtu.edu.cn> References: <004c01d2cf51$b4237950$1c6a6bf0$@cs.sjtu.edu.cn> <000201d2cf69$ba8c2c70$2fa48550$@cs.sjtu.edu.cn> Message-ID: <19936f96-50e2-444e-a2fa-76c05012c564@oracle.com> This is not an alias for question about the JVM specification. Please direct your questions to a more suitable forum. Regards, -Joe Darcy On 5/17/2017 5:00 PM, ??? wrote: > The original explanation is given as: "Structured locking is the situation > when, during a method invocation, every exit on a given monitor matches a > preceding entry on that monitor. Since there is no assurance that all code > submitted to the Java Virtual Machine will perform structured locking, > implementations of the Java Virtual Machine are permitted but not required > to enforce both of the following two rules guaranteeing structured locking. > Let T be a thread and M be a monitor. Then: (1) The number of monitor > entries performed by T on M during a method invocation must equal the number > of monitor exits performed by T on M during the method invocation whether > the method invocation completes normally or abruptly. (2) At no point during > a method invocation may the number of monitor exits performed by T on M > since the method invocation exceed the number of monitor entries performed > by T on M since the method invocation." > > I retested some programs on HotSpot and IBM's J9. It seems that HotSpot > takes Rule 1 (rule1 is stricter than rule2, and J9 throws out an > IllegalMonitorStateException at runtime) and J9 only takes Rule 2 (accepting > the program). As the exception can be caught (with further exception > handlings), some of my programs run quite differently on the two platforms. > > f(){ > monitorenter r0; > } > g(){ > f(); > monitorexit r0; > } > > -----????----- > ???: csr-discuss [mailto:csr-discuss-bounces at openjdk.java.net] ?? ?? > ? > ????: 2017?5?17? 14:08 > ???: csr-discuss at openjdk.java.net > ??: What is a structured locking in the JVM specification? > > According to the definition, it seems that a structured locking appears > like: Monitorenter r0; ?monitorenter r0; ?? monitorexit r0; ?monitorexit > r0; > > * The definition is given as follows: Structured locking is the situation > when, during a method invocation, every exit on a given monitor matches a > preceding entry on that monitor. > (https://docs.oracle.com/javase/specs/jvms/se8/html/jvms-2.html#jvms-2.11.10 > ) > > > > I?m a little curious whether a structured locking can be composed by the > following instructions: > > Monitorenter r0; monitorenter r2; ?? monitorexit r0; monitorexit r2; > > > > In addition, should this sequence be accepted or rejected? At runtime or > during the verification time? > > > > Yuting > > > From joe.darcy at oracle.com Wed May 24 00:04:39 2017 From: joe.darcy at oracle.com (Joseph D. Darcy) Date: Tue, 23 May 2017 17:04:39 -0700 Subject: CSR issue type now live in JDK project for JDK 10 requests Message-ID: <5924CE17.1070208@oracle.com> Hello, The CSR issue type is now live in the JDK project to be used for compatibility and specification review for JDK 10 issues. Thanks to Tony Squier for the JIRA work making this possible. I've created a few retroactive CSR requests for two API changes I needed to do earlier in JDK 10. CSR members have the ability to transition requests to the Pended state. As chair, in addition I can move requests to the Closed/Approved and Provisional states. Administratively, Mark Reinhold also has chair privileges should the need arise to move forward on requests if I'm not available. As we start using the new system, I expect we'll want to make some adjustments. In the coming weeks, I plan to setup JIRA dashboards to assist with CSR reviews. Let the reviewing begin! Thanks, -Joe From david.holmes at oracle.com Thu May 25 01:56:02 2017 From: david.holmes at oracle.com (David Holmes) Date: Thu, 25 May 2017 11:56:02 +1000 Subject: CSR issue type now live in JDK project for JDK 10 requests In-Reply-To: <5924CE17.1070208@oracle.com> References: <5924CE17.1070208@oracle.com> Message-ID: <544e83f6-4829-a5e8-fba4-90cf7680df37@oracle.com> Hi Joe, Have I missed the instructions on how to respond to the CSR JBS issues once they are filed? Do we add comments saying "I approve" or "I have a problem ..."? CSRs are being filed but I'm not sure what, if anything I need to do with them. Thanks, David On 24/05/2017 10:04 AM, Joseph D. Darcy wrote: > Hello, > > The CSR issue type is now live in the JDK project to be used for > compatibility and specification review for JDK 10 issues. > > Thanks to Tony Squier for the JIRA work making this possible. > > I've created a few retroactive CSR requests for two API changes I needed > to do earlier in JDK 10. CSR members have the ability to transition > requests to the Pended state. As chair, in addition I can move requests > to the Closed/Approved and Provisional states. Administratively, Mark > Reinhold also has chair privileges should the need arise to move forward > on requests if I'm not available. > > As we start using the new system, I expect we'll want to make some > adjustments. In the coming weeks, I plan to setup JIRA dashboards to > assist with CSR reviews. > > Let the reviewing begin! > > Thanks, > > -Joe > From joe.darcy at oracle.com Thu May 25 14:02:35 2017 From: joe.darcy at oracle.com (joe darcy) Date: Thu, 25 May 2017 07:02:35 -0700 Subject: CSR issue type now live in JDK project for JDK 10 requests In-Reply-To: <544e83f6-4829-a5e8-fba4-90cf7680df37@oracle.com> References: <5924CE17.1070208@oracle.com> <544e83f6-4829-a5e8-fba4-90cf7680df37@oracle.com> Message-ID: Hi David, You can add yourself as a reviewer to indicated you approve of the request. You can also add a comment to that effect. If you think there is a problem with the request you can pend it if it is in Provisional or Finalized state. If you don't see workflow actions to move the request when in those states, a config change may be needed in JBS. HTH, -Joe On 5/24/2017 6:56 PM, David Holmes wrote: > Hi Joe, > > Have I missed the instructions on how to respond to the CSR JBS issues > once they are filed? Do we add comments saying "I approve" or "I have > a problem ..."? > > CSRs are being filed but I'm not sure what, if anything I need to do > with them. > > Thanks, > David > > On 24/05/2017 10:04 AM, Joseph D. Darcy wrote: >> Hello, >> >> The CSR issue type is now live in the JDK project to be used for >> compatibility and specification review for JDK 10 issues. >> >> Thanks to Tony Squier for the JIRA work making this possible. >> >> I've created a few retroactive CSR requests for two API changes I >> needed to do earlier in JDK 10. CSR members have the ability to >> transition requests to the Pended state. As chair, in addition I can >> move requests to the Closed/Approved and Provisional states. >> Administratively, Mark Reinhold also has chair privileges should the >> need arise to move forward on requests if I'm not available. >> >> As we start using the new system, I expect we'll want to make some >> adjustments. In the coming weeks, I plan to setup JIRA dashboards to >> assist with CSR reviews. >> >> Let the reviewing begin! >> >> Thanks, >> >> -Joe >> From philip.race at oracle.com Tue May 30 16:20:02 2017 From: philip.race at oracle.com (Phil Race) Date: Tue, 30 May 2017 09:20:02 -0700 Subject: CSR issue type now live in JDK project for JDK 10 requests In-Reply-To: References: <5924CE17.1070208@oracle.com> <544e83f6-4829-a5e8-fba4-90cf7680df37@oracle.com> Message-ID: <6bae92c5-8c76-8020-115d-dba971ef9761@oracle.com> On 05/25/2017 07:02 AM, joe darcy wrote: > Hi David, > > You can add yourself as a reviewer to indicated you approve of the > request. I just did that for https://bugs.openjdk.java.net/browse/JDK-8181190 but it feels a bit odd. That has generally meant "peer reviewed by an area expert", as opposed to the CSR review angle .. > > You can also add a comment to that effect. Comments feel too free form for that. > > If you think there is a problem with the request you can pend it if it > is in Provisional or Finalized state. > > If you don't see workflow actions to move the request when in those > states, a config change may be needed in JBS. https://bugs.openjdk.java.net/browse/JDK-8181058 is in Provisional State but I see no way to pend it. Whereas https://bugs.openjdk.java.net/browse/JDK-8181190 is in Proposed State and there I do see a button labelled "Pending" but "Pending" reads like "I am in pended state". Shouldn't the button be labelled "Pend" ? -phil > > HTH, > > -Joe > > > On 5/24/2017 6:56 PM, David Holmes wrote: >> Hi Joe, >> >> Have I missed the instructions on how to respond to the CSR JBS >> issues once they are filed? Do we add comments saying "I approve" or >> "I have a problem ..."? >> >> CSRs are being filed but I'm not sure what, if anything I need to do >> with them. >> >> Thanks, >> David >> >> On 24/05/2017 10:04 AM, Joseph D. Darcy wrote: >>> Hello, >>> >>> The CSR issue type is now live in the JDK project to be used for >>> compatibility and specification review for JDK 10 issues. >>> >>> Thanks to Tony Squier for the JIRA work making this possible. >>> >>> I've created a few retroactive CSR requests for two API changes I >>> needed to do earlier in JDK 10. CSR members have the ability to >>> transition requests to the Pended state. As chair, in addition I can >>> move requests to the Closed/Approved and Provisional states. >>> Administratively, Mark Reinhold also has chair privileges should the >>> need arise to move forward on requests if I'm not available. >>> >>> As we start using the new system, I expect we'll want to make some >>> adjustments. In the coming weeks, I plan to setup JIRA dashboards to >>> assist with CSR reviews. >>> >>> Let the reviewing begin! >>> >>> Thanks, >>> >>> -Joe >>> > From philip.race at oracle.com Tue May 30 16:22:09 2017 From: philip.race at oracle.com (Phil Race) Date: Tue, 30 May 2017 09:22:09 -0700 Subject: CSR issue type now live in JDK project for JDK 10 requests In-Reply-To: <6bae92c5-8c76-8020-115d-dba971ef9761@oracle.com> References: <5924CE17.1070208@oracle.com> <544e83f6-4829-a5e8-fba4-90cf7680df37@oracle.com> <6bae92c5-8c76-8020-115d-dba971ef9761@oracle.com> Message-ID: On 05/30/2017 09:20 AM, Phil Race wrote: > > > On 05/25/2017 07:02 AM, joe darcy wrote: >> Hi David, >> >> You can add yourself as a reviewer to indicated you approve of the >> request. > > I just did that for https://bugs.openjdk.java.net/browse/JDK-8181190 but > it feels a bit odd. That has generally meant "peer reviewed by an area > expert", > as opposed to the CSR review angle .. > And actually I lied. It failed to take because the "reviewed" state isn't valid until it has a compatibility risk which I guess is not needed until it goes final. So I can't do anything except add a free form comment, which also seems wrong. -phil. >> >> You can also add a comment to that effect. > > Comments feel too free form for that. > >> >> If you think there is a problem with the request you can pend it if >> it is in Provisional or Finalized state. >> >> If you don't see workflow actions to move the request when in those >> states, a config change may be needed in JBS. > > https://bugs.openjdk.java.net/browse/JDK-8181058 > > is in Provisional State but I see no way to pend it. > > Whereas https://bugs.openjdk.java.net/browse/JDK-8181190 > is in Proposed State and there I do see a button labelled "Pending" but > "Pending" reads like "I am in pended state". > Shouldn't the button be labelled "Pend" ? > > -phil > > >> >> HTH, >> >> -Joe >> >> >> On 5/24/2017 6:56 PM, David Holmes wrote: >>> Hi Joe, >>> >>> Have I missed the instructions on how to respond to the CSR JBS >>> issues once they are filed? Do we add comments saying "I approve" or >>> "I have a problem ..."? >>> >>> CSRs are being filed but I'm not sure what, if anything I need to do >>> with them. >>> >>> Thanks, >>> David >>> >>> On 24/05/2017 10:04 AM, Joseph D. Darcy wrote: >>>> Hello, >>>> >>>> The CSR issue type is now live in the JDK project to be used for >>>> compatibility and specification review for JDK 10 issues. >>>> >>>> Thanks to Tony Squier for the JIRA work making this possible. >>>> >>>> I've created a few retroactive CSR requests for two API changes I >>>> needed to do earlier in JDK 10. CSR members have the ability to >>>> transition requests to the Pended state. As chair, in addition I >>>> can move requests to the Closed/Approved and Provisional states. >>>> Administratively, Mark Reinhold also has chair privileges should >>>> the need arise to move forward on requests if I'm not available. >>>> >>>> As we start using the new system, I expect we'll want to make some >>>> adjustments. In the coming weeks, I plan to setup JIRA dashboards >>>> to assist with CSR reviews. >>>> >>>> Let the reviewing begin! >>>> >>>> Thanks, >>>> >>>> -Joe >>>> >> > From philip.race at oracle.com Tue May 30 16:25:54 2017 From: philip.race at oracle.com (Phil Race) Date: Tue, 30 May 2017 09:25:54 -0700 Subject: CSR issue type now live in JDK project for JDK 10 requests In-Reply-To: References: <5924CE17.1070208@oracle.com> <544e83f6-4829-a5e8-fba4-90cf7680df37@oracle.com> <6bae92c5-8c76-8020-115d-dba971ef9761@oracle.com> Message-ID: <2302b8f4-9e99-3c08-6d9f-3befd6c6f779@oracle.com> PPS there is also a bug (I think!) since when I select EDIT so I can see all the fields like reviewer I can't fill in the Comment field either unless it has a compatibility risk. Whereas I CAN do it on the main page ! Very odd. I think that you should not be able to get it into any state where it is asking for CSR input until it has a compatibility risk statement. That would solve both those issues. Although the oddness of it all will remain :-( -phil. On 05/30/2017 09:22 AM, Phil Race wrote: > > > On 05/30/2017 09:20 AM, Phil Race wrote: >> >> >> On 05/25/2017 07:02 AM, joe darcy wrote: >>> Hi David, >>> >>> You can add yourself as a reviewer to indicated you approve of the >>> request. >> >> I just did that for https://bugs.openjdk.java.net/browse/JDK-8181190 but >> it feels a bit odd. That has generally meant "peer reviewed by an >> area expert", >> as opposed to the CSR review angle .. >> > > And actually I lied. It failed to take because the "reviewed" state > isn't valid > until it has a compatibility risk which I guess is not needed until it > goes final. > So I can't do anything except add a free form comment, which also > seems wrong. > > -phil. >>> >>> You can also add a comment to that effect. >> >> Comments feel too free form for that. >> >>> >>> If you think there is a problem with the request you can pend it if >>> it is in Provisional or Finalized state. >>> >>> If you don't see workflow actions to move the request when in those >>> states, a config change may be needed in JBS. >> >> https://bugs.openjdk.java.net/browse/JDK-8181058 >> >> is in Provisional State but I see no way to pend it. >> >> Whereas https://bugs.openjdk.java.net/browse/JDK-8181190 >> is in Proposed State and there I do see a button labelled "Pending" but >> "Pending" reads like "I am in pended state". >> Shouldn't the button be labelled "Pend" ? >> >> -phil >> >> >>> >>> HTH, >>> >>> -Joe >>> >>> >>> On 5/24/2017 6:56 PM, David Holmes wrote: >>>> Hi Joe, >>>> >>>> Have I missed the instructions on how to respond to the CSR JBS >>>> issues once they are filed? Do we add comments saying "I approve" >>>> or "I have a problem ..."? >>>> >>>> CSRs are being filed but I'm not sure what, if anything I need to >>>> do with them. >>>> >>>> Thanks, >>>> David >>>> >>>> On 24/05/2017 10:04 AM, Joseph D. Darcy wrote: >>>>> Hello, >>>>> >>>>> The CSR issue type is now live in the JDK project to be used for >>>>> compatibility and specification review for JDK 10 issues. >>>>> >>>>> Thanks to Tony Squier for the JIRA work making this possible. >>>>> >>>>> I've created a few retroactive CSR requests for two API changes I >>>>> needed to do earlier in JDK 10. CSR members have the ability to >>>>> transition requests to the Pended state. As chair, in addition I >>>>> can move requests to the Closed/Approved and Provisional states. >>>>> Administratively, Mark Reinhold also has chair privileges should >>>>> the need arise to move forward on requests if I'm not available. >>>>> >>>>> As we start using the new system, I expect we'll want to make some >>>>> adjustments. In the coming weeks, I plan to setup JIRA dashboards >>>>> to assist with CSR reviews. >>>>> >>>>> Let the reviewing begin! >>>>> >>>>> Thanks, >>>>> >>>>> -Joe >>>>> >>> >> > From philip.race at oracle.com Wed May 31 17:27:10 2017 From: philip.race at oracle.com (Phil Race) Date: Wed, 31 May 2017 10:27:10 -0700 Subject: Tracking what you have looked at .. Message-ID: <7635e049-f41e-878c-2be2-7a1a66a25740@oracle.com> As the number of CSRs in process increases I am starting to realise that it is not so nice to track what I have looked at and OKed and also whether it was OKed for provisional or final. Adding yourself as a reviewer is non-specific Making a comment is not intimately tied to a state. I think we need some explicit fields that correspond to per-person and state. This may not be easy in JBS but that should not change its importance. -phil. From Alan.Bateman at oracle.com Wed May 31 17:40:21 2017 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 31 May 2017 18:40:21 +0100 Subject: Tracking what you have looked at .. In-Reply-To: <7635e049-f41e-878c-2be2-7a1a66a25740@oracle.com> References: <7635e049-f41e-878c-2be2-7a1a66a25740@oracle.com> Message-ID: <3e899036-d2a9-9226-1861-abb960fb173d@oracle.com> On 31/05/2017 18:27, Phil Race wrote: > As the number of CSRs in process increases I am starting to realise that > it is not so nice to track what I have looked at and OKed and also > whether > it was OKed for provisional or final. > Adding yourself as a reviewer is non-specific > Making a comment is not intimately tied to a state. > > I think we need some explicit fields that correspond to per-person and > state. > This may not be easy in JBS but that should not change its importance. I think Joe said he has (or plan) to create a dashboards and/or filters to help with this. -Alan From martinrb at google.com Wed May 31 21:08:45 2017 From: martinrb at google.com (Martin Buchholz) Date: Wed, 31 May 2017 14:08:45 -0700 Subject: CSR issue type now live in JDK project for JDK 10 requests In-Reply-To: References: <5924CE17.1070208@oracle.com> <544e83f6-4829-a5e8-fba4-90cf7680df37@oracle.com> <6bae92c5-8c76-8020-115d-dba971ef9761@oracle.com> Message-ID: I went through the process of creating a CSR but only after filling everything out does it tell me """CSRs cannot be created manually, instead use the Create CSR operation on the Issue View page.""" On Tue, May 30, 2017 at 9:22 AM, Phil Race wrote: > > > On 05/30/2017 09:20 AM, Phil Race wrote: > >> >> >> On 05/25/2017 07:02 AM, joe darcy wrote: >> >>> Hi David, >>> >>> You can add yourself as a reviewer to indicated you approve of the >>> request. >>> >> >> I just did that for https://bugs.openjdk.java.net/browse/JDK-8181190 but >> it feels a bit odd. That has generally meant "peer reviewed by an area >> expert", >> as opposed to the CSR review angle .. >> >> > And actually I lied. It failed to take because the "reviewed" state isn't > valid > until it has a compatibility risk which I guess is not needed until it > goes final. > So I can't do anything except add a free form comment, which also seems > wrong. > > -phil. > > >>> You can also add a comment to that effect. >>> >> >> Comments feel too free form for that. >> >> >>> If you think there is a problem with the request you can pend it if it >>> is in Provisional or Finalized state. >>> >>> If you don't see workflow actions to move the request when in those >>> states, a config change may be needed in JBS. >>> >> >> https://bugs.openjdk.java.net/browse/JDK-8181058 >> >> is in Provisional State but I see no way to pend it. >> >> Whereas https://bugs.openjdk.java.net/browse/JDK-8181190 >> is in Proposed State and there I do see a button labelled "Pending" but >> "Pending" reads like "I am in pended state". >> Shouldn't the button be labelled "Pend" ? >> >> -phil >> >> >> >>> HTH, >>> >>> -Joe >>> >>> >>> On 5/24/2017 6:56 PM, David Holmes wrote: >>> >>>> Hi Joe, >>>> >>>> Have I missed the instructions on how to respond to the CSR JBS issues >>>> once they are filed? Do we add comments saying "I approve" or "I have a >>>> problem ..."? >>>> >>>> CSRs are being filed but I'm not sure what, if anything I need to do >>>> with them. >>>> >>>> Thanks, >>>> David >>>> >>>> On 24/05/2017 10:04 AM, Joseph D. Darcy wrote: >>>> >>>>> Hello, >>>>> >>>>> The CSR issue type is now live in the JDK project to be used for >>>>> compatibility and specification review for JDK 10 issues. >>>>> >>>>> Thanks to Tony Squier for the JIRA work making this possible. >>>>> >>>>> I've created a few retroactive CSR requests for two API changes I >>>>> needed to do earlier in JDK 10. CSR members have the ability to transition >>>>> requests to the Pended state. As chair, in addition I can move requests to >>>>> the Closed/Approved and Provisional states. Administratively, Mark Reinhold >>>>> also has chair privileges should the need arise to move forward on requests >>>>> if I'm not available. >>>>> >>>>> As we start using the new system, I expect we'll want to make some >>>>> adjustments. In the coming weeks, I plan to setup JIRA dashboards to assist >>>>> with CSR reviews. >>>>> >>>>> Let the reviewing begin! >>>>> >>>>> Thanks, >>>>> >>>>> -Joe >>>>> >>>>> >>> >> > From philip.race at oracle.com Wed May 31 21:16:03 2017 From: philip.race at oracle.com (Phil Race) Date: Wed, 31 May 2017 14:16:03 -0700 Subject: CSR issue type now live in JDK project for JDK 10 requests In-Reply-To: References: <5924CE17.1070208@oracle.com> <544e83f6-4829-a5e8-fba4-90cf7680df37@oracle.com> <6bae92c5-8c76-8020-115d-dba971ef9761@oracle.com> Message-ID: <7476a064-79f1-3f4b-2aef-8eaffb9348d3@oracle.com> That sounds like an anoying work flow issue. Tony .. is there a way to remove CSR from the list of types in the drop down of the create page ? Perhaps "Backport" has the same issue but I'm not sure about that -phil. On 05/31/2017 02:08 PM, Martin Buchholz wrote: > I went through the process of creating a CSR but only after filling > everything out does it tell me """CSRs cannot be created manually, > instead use the Create CSR operation on the Issue View page.""" > > On Tue, May 30, 2017 at 9:22 AM, Phil Race > wrote: > > > > On 05/30/2017 09:20 AM, Phil Race wrote: > > > > On 05/25/2017 07:02 AM, joe darcy wrote: > > Hi David, > > You can add yourself as a reviewer to indicated you > approve of the request. > > > I just did that for > https://bugs.openjdk.java.net/browse/JDK-8181190 > but > it feels a bit odd. That has generally meant "peer reviewed by > an area expert", > as opposed to the CSR review angle .. > > > And actually I lied. It failed to take because the "reviewed" > state isn't valid > until it has a compatibility risk which I guess is not needed > until it goes final. > So I can't do anything except add a free form comment, which also > seems wrong. > > -phil. > > > You can also add a comment to that effect. > > > Comments feel too free form for that. > > > If you think there is a problem with the request you can > pend it if it is in Provisional or Finalized state. > > If you don't see workflow actions to move the request when > in those states, a config change may be needed in JBS. > > > https://bugs.openjdk.java.net/browse/JDK-8181058 > > > is in Provisional State but I see no way to pend it. > > Whereas https://bugs.openjdk.java.net/browse/JDK-8181190 > > is in Proposed State and there I do see a button labelled > "Pending" but > "Pending" reads like "I am in pended state". > Shouldn't the button be labelled "Pend" ? > > -phil > > > > HTH, > > -Joe > > > On 5/24/2017 6:56 PM, David Holmes wrote: > > Hi Joe, > > Have I missed the instructions on how to respond to > the CSR JBS issues once they are filed? Do we add > comments saying "I approve" or "I have a problem ..."? > > CSRs are being filed but I'm not sure what, if > anything I need to do with them. > > Thanks, > David > > On 24/05/2017 10:04 AM, Joseph D. Darcy wrote: > > Hello, > > The CSR issue type is now live in the JDK project > to be used for compatibility and specification > review for JDK 10 issues. > > Thanks to Tony Squier for the JIRA work making > this possible. > > I've created a few retroactive CSR requests for > two API changes I needed to do earlier in JDK 10. > CSR members have the ability to transition > requests to the Pended state. As chair, in > addition I can move requests to the > Closed/Approved and Provisional states. > Administratively, Mark Reinhold also has chair > privileges should the need arise to move forward > on requests if I'm not available. > > As we start using the new system, I expect we'll > want to make some adjustments. In the coming > weeks, I plan to setup JIRA dashboards to assist > with CSR reviews. > > Let the reviewing begin! > > Thanks, > > -Joe > > > > > From martinrb at google.com Wed May 31 21:20:28 2017 From: martinrb at google.com (Martin Buchholz) Date: Wed, 31 May 2017 14:20:28 -0700 Subject: CSR issue type now live in JDK project for JDK 10 requests In-Reply-To: <7476a064-79f1-3f4b-2aef-8eaffb9348d3@oracle.com> References: <5924CE17.1070208@oracle.com> <544e83f6-4829-a5e8-fba4-90cf7680df37@oracle.com> <6bae92c5-8c76-8020-115d-dba971ef9761@oracle.com> <7476a064-79f1-3f4b-2aef-8eaffb9348d3@oracle.com> Message-ID: I pasted a uni-diff into the Description of https://bugs.openjdk.java.net/browse/JDK-8181380 but it got mangled. How does one include an inline diff ? From philip.race at oracle.com Wed May 31 21:25:24 2017 From: philip.race at oracle.com (Phil Race) Date: Wed, 31 May 2017 14:25:24 -0700 Subject: CSR issue type now live in JDK project for JDK 10 requests In-Reply-To: References: <5924CE17.1070208@oracle.com> <544e83f6-4829-a5e8-fba4-90cf7680df37@oracle.com> <6bae92c5-8c76-8020-115d-dba971ef9761@oracle.com> <7476a064-79f1-3f4b-2aef-8eaffb9348d3@oracle.com> Message-ID: <62d77361-1f25-8afd-734f-db3e95220e9d@oracle.com> I think you are supposed to be able to use markdown syntax. Should be the same as what is supported in JEPs. -phil. On 05/31/2017 02:20 PM, Martin Buchholz wrote: > > I pasted a uni-diff into the Description of > https://bugs.openjdk.java.net/browse/JDK-8181380 but it got mangled. > How does one include an inline diff ? From martinrb at google.com Wed May 31 21:40:09 2017 From: martinrb at google.com (Martin Buchholz) Date: Wed, 31 May 2017 14:40:09 -0700 Subject: CSR issue type now live in JDK project for JDK 10 requests In-Reply-To: <62d77361-1f25-8afd-734f-db3e95220e9d@oracle.com> References: <5924CE17.1070208@oracle.com> <544e83f6-4829-a5e8-fba4-90cf7680df37@oracle.com> <6bae92c5-8c76-8020-115d-dba971ef9761@oracle.com> <7476a064-79f1-3f4b-2aef-8eaffb9348d3@oracle.com> <62d77361-1f25-8afd-734f-db3e95220e9d@oracle.com> Message-ID: On Wed, May 31, 2017 at 2:25 PM, Phil Race wrote: > I think you are supposed to be able to use markdown syntax. > Should be the same as what is supported in JEPs. > Now you're making me feel guilty for never having filed a JEP ! OK, much better now after having spent some quality time with a markdown cheat sheet. From tony.squier at oracle.com Wed May 31 21:28:26 2017 From: tony.squier at oracle.com (Tony Squier) Date: Wed, 31 May 2017 14:28:26 -0700 Subject: CSR issue type now live in JDK project for JDK 10 requests In-Reply-To: <7476a064-79f1-3f4b-2aef-8eaffb9348d3@oracle.com> References: <5924CE17.1070208@oracle.com> <544e83f6-4829-a5e8-fba4-90cf7680df37@oracle.com> <6bae92c5-8c76-8020-115d-dba971ef9761@oracle.com> <7476a064-79f1-3f4b-2aef-8eaffb9348d3@oracle.com> Message-ID: No there is now way to remove it from the list, that is why we put the error message telling people to use the create csr button. Same with backports BTW. Tony... -- Tony Squier tony.squier at oracle.com Java Platform Group Oracle Corporation ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ NOTICE: This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ On 5/31/17 2:16 PM, Phil Race wrote: > That sounds like an anoying work flow issue. > Tony .. is there a way to remove CSR from the list of types in the > drop down of the create page ? > > Perhaps "Backport" has the same issue but I'm not sure about that > > -phil. > > On 05/31/2017 02:08 PM, Martin Buchholz wrote: >> I went through the process of creating a CSR but only after filling >> everything out does it tell me """CSRs cannot be created manually, >> instead use the Create CSR operation on the Issue View page.""" >> >> On Tue, May 30, 2017 at 9:22 AM, Phil Race > > wrote: >> >> >> >> On 05/30/2017 09:20 AM, Phil Race wrote: >> >> >> >> On 05/25/2017 07:02 AM, joe darcy wrote: >> >> Hi David, >> >> You can add yourself as a reviewer to indicated you >> approve of the request. >> >> >> I just did that for >> https://bugs.openjdk.java.net/browse/JDK-8181190 >> but >> it feels a bit odd. That has generally meant "peer reviewed >> by an area expert", >> as opposed to the CSR review angle .. >> >> >> And actually I lied. It failed to take because the "reviewed" >> state isn't valid >> until it has a compatibility risk which I guess is not needed >> until it goes final. >> So I can't do anything except add a free form comment, which also >> seems wrong. >> >> -phil. >> >> >> You can also add a comment to that effect. >> >> >> Comments feel too free form for that. >> >> >> If you think there is a problem with the request you can >> pend it if it is in Provisional or Finalized state. >> >> If you don't see workflow actions to move the request >> when in those states, a config change may be needed in JBS. >> >> >> https://bugs.openjdk.java.net/browse/JDK-8181058 >> >> >> is in Provisional State but I see no way to pend it. >> >> Whereas https://bugs.openjdk.java.net/browse/JDK-8181190 >> >> is in Proposed State and there I do see a button labelled >> "Pending" but >> "Pending" reads like "I am in pended state". >> Shouldn't the button be labelled "Pend" ? >> >> -phil >> >> >> >> HTH, >> >> -Joe >> >> >> On 5/24/2017 6:56 PM, David Holmes wrote: >> >> Hi Joe, >> >> Have I missed the instructions on how to respond to >> the CSR JBS issues once they are filed? Do we add >> comments saying "I approve" or "I have a problem ..."? >> >> CSRs are being filed but I'm not sure what, if >> anything I need to do with them. >> >> Thanks, >> David >> >> On 24/05/2017 10:04 AM, Joseph D. Darcy wrote: >> >> Hello, >> >> The CSR issue type is now live in the JDK project >> to be used for compatibility and specification >> review for JDK 10 issues. >> >> Thanks to Tony Squier for the JIRA work making >> this possible. >> >> I've created a few retroactive CSR requests for >> two API changes I needed to do earlier in JDK 10. >> CSR members have the ability to transition >> requests to the Pended state. As chair, in >> addition I can move requests to the >> Closed/Approved and Provisional states. >> Administratively, Mark Reinhold also has chair >> privileges should the need arise to move forward >> on requests if I'm not available. >> >> As we start using the new system, I expect we'll >> want to make some adjustments. In the coming >> weeks, I plan to setup JIRA dashboards to assist >> with CSR reviews. >> >> Let the reviewing begin! >> >> Thanks, >> >> -Joe >> >> >> >> >> > From philip.race at oracle.com Wed May 31 23:12:02 2017 From: philip.race at oracle.com (Phil Race) Date: Wed, 31 May 2017 16:12:02 -0700 Subject: CSR issue type now live in JDK project for JDK 10 requests In-Reply-To: References: <5924CE17.1070208@oracle.com> <544e83f6-4829-a5e8-fba4-90cf7680df37@oracle.com> <6bae92c5-8c76-8020-115d-dba971ef9761@oracle.com> <7476a064-79f1-3f4b-2aef-8eaffb9348d3@oracle.com> Message-ID: <0A2552F6-4A97-4896-BBCF-685354160D7D@oracle.com> The annoying part is not that the error message ... it is the timing of the error message. RFE to atlassian I think. -Phil. > On May 31, 2017, at 2:28 PM, Tony Squier wrote: > > No there is now way to remove it from the list, that is why we put the error message telling people to use the create csr button. Same with backports BTW. > Tony... > -- > > Tony Squier > tony.squier at oracle.com > Java Platform Group > Oracle Corporation > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > NOTICE: This email message is for the sole use of the > intended recipient(s) and may contain confidential > information. Any unauthorized review, use, disclosure > or distribution is prohibited. If you are not the intended > recipient, please contact the sender by reply email and > destroy all copies of the original message. > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> On 5/31/17 2:16 PM, Phil Race wrote: >> That sounds like an anoying work flow issue. >> Tony .. is there a way to remove CSR from the list of types in the drop down of the create page ? >> >> Perhaps "Backport" has the same issue but I'm not sure about that >> >> -phil. >> >>> On 05/31/2017 02:08 PM, Martin Buchholz wrote: >>> I went through the process of creating a CSR but only after filling everything out does it tell me """CSRs cannot be created manually, instead use the Create CSR operation on the Issue View page.""" >>> >>>> On Tue, May 30, 2017 at 9:22 AM, Phil Race wrote: >>>> >>>> >>>>> On 05/30/2017 09:20 AM, Phil Race wrote: >>>>> >>>>> >>>>>> On 05/25/2017 07:02 AM, joe darcy wrote: >>>>>> Hi David, >>>>>> >>>>>> You can add yourself as a reviewer to indicated you approve of the request. >>>>> >>>>> I just did that for https://bugs.openjdk.java.net/browse/JDK-8181190 but >>>>> it feels a bit odd. That has generally meant "peer reviewed by an area expert", >>>>> as opposed to the CSR review angle .. >>>>> >>>> >>>> And actually I lied. It failed to take because the "reviewed" state isn't valid >>>> until it has a compatibility risk which I guess is not needed until it goes final. >>>> So I can't do anything except add a free form comment, which also seems wrong. >>>> >>>> -phil. >>>> >>>>>> >>>>>> You can also add a comment to that effect. >>>>> >>>>> Comments feel too free form for that. >>>>> >>>>>> >>>>>> If you think there is a problem with the request you can pend it if it is in Provisional or Finalized state. >>>>>> >>>>>> If you don't see workflow actions to move the request when in those states, a config change may be needed in JBS. >>>>> >>>>> https://bugs.openjdk.java.net/browse/JDK-8181058 >>>>> >>>>> is in Provisional State but I see no way to pend it. >>>>> >>>>> Whereas https://bugs.openjdk.java.net/browse/JDK-8181190 >>>>> is in Proposed State and there I do see a button labelled "Pending" but >>>>> "Pending" reads like "I am in pended state". >>>>> Shouldn't the button be labelled "Pend" ? >>>>> >>>>> -phil >>>>> >>>>> >>>>>> >>>>>> HTH, >>>>>> >>>>>> -Joe >>>>>> >>>>>> >>>>>>> On 5/24/2017 6:56 PM, David Holmes wrote: >>>>>>> Hi Joe, >>>>>>> >>>>>>> Have I missed the instructions on how to respond to the CSR JBS issues once they are filed? Do we add comments saying "I approve" or "I have a problem ..."? >>>>>>> >>>>>>> CSRs are being filed but I'm not sure what, if anything I need to do with them. >>>>>>> >>>>>>> Thanks, >>>>>>> David >>>>>>> >>>>>>>> On 24/05/2017 10:04 AM, Joseph D. Darcy wrote: >>>>>>>> Hello, >>>>>>>> >>>>>>>> The CSR issue type is now live in the JDK project to be used for compatibility and specification review for JDK 10 issues. >>>>>>>> >>>>>>>> Thanks to Tony Squier for the JIRA work making this possible. >>>>>>>> >>>>>>>> I've created a few retroactive CSR requests for two API changes I needed to do earlier in JDK 10. CSR members have the ability to transition requests to the Pended state. As chair, in addition I can move requests to the Closed/Approved and Provisional states. Administratively, Mark Reinhold also has chair privileges should the need arise to move forward on requests if I'm not available. >>>>>>>> >>>>>>>> As we start using the new system, I expect we'll want to make some adjustments. In the coming weeks, I plan to setup JIRA dashboards to assist with CSR reviews. >>>>>>>> >>>>>>>> Let the reviewing begin! >>>>>>>> >>>>>>>> Thanks, >>>>>>>> >>>>>>>> -Joe >>>>>>>> >>>>>> >>>>> >>>> >>> >> > From philip.race at oracle.com Wed May 31 23:13:31 2017 From: philip.race at oracle.com (Phil Race) Date: Wed, 31 May 2017 16:13:31 -0700 Subject: CSR issue type now live in JDK project for JDK 10 requests In-Reply-To: References: <5924CE17.1070208@oracle.com> <544e83f6-4829-a5e8-fba4-90cf7680df37@oracle.com> <6bae92c5-8c76-8020-115d-dba971ef9761@oracle.com> <7476a064-79f1-3f4b-2aef-8eaffb9348d3@oracle.com> <62d77361-1f25-8afd-734f-db3e95220e9d@oracle.com> Message-ID: I think when Joe gets back from vacation the FAQ etc needs to be a priority. -Phil. > On May 31, 2017, at 2:40 PM, Martin Buchholz wrote: > > > >> On Wed, May 31, 2017 at 2:25 PM, Phil Race wrote: >> I think you are supposed to be able to use markdown syntax. >> Should be the same as what is supported in JEPs. > > Now you're making me feel guilty for never having filed a JEP ! > > OK, much better now after having spent some quality time with a markdown cheat sheet.