From david.holmes at oracle.com Mon Dec 10 07:44:12 2018 From: david.holmes at oracle.com (David Holmes) Date: Mon, 10 Dec 2018 17:44:12 +1000 Subject: CSR approval process for backports In-Reply-To: <39A3AEB9-5055-4E61-BA35-F64C7CEECBA3@amazon.com> References: <6c17402e-15b6-0011-02bd-3112587c8bdb@oracle.com> <39A3AEB9-5055-4E61-BA35-F64C7CEECBA3@amazon.com> Message-ID: <23399c0b-cc14-e8d1-454a-6bf04ce97faf@oracle.com> Hi Paul, On 8/12/2018 3:02 am, Hohensee, Paul wrote: > Would it perhaps be better to create a manual backport issue for the CSR first, get that approved, then follow the normal process for the backport itself? Although JBS seems to allow it, as I understand it a "backport" issue is expected to be associated with a "bug" or "enhancement" not a "csr request". It's not at all clear the expected relationships would be created if you did it the way you suggest. cc'd crs-discuss for furtehr comment. Cheers, David > > Paul > > ?On 12/6/18, 1:26 PM, "jdk-updates-dev on behalf of David Holmes" wrote: > > Hi, > > The updates wiki pages states: > > "If a change requires CSR approval, that approval must be obtained prior > to making the push approval request." > > but the CSR approval process for a backport is not defined anywhere as > far as I can see. After discussion with the CSR Group lead it seems the > expectation is that a manual backport issue must be created first, and > then a CSR for that backport can be created. can this information be > added to the updates page and/or the CSR FAQ and linked from the updates > page. > > Thanks, > David > > From joe.darcy at oracle.com Wed Dec 12 00:20:50 2018 From: joe.darcy at oracle.com (Joseph D. Darcy) Date: Tue, 11 Dec 2018 16:20:50 -0800 Subject: CSR approval process for backports In-Reply-To: <23399c0b-cc14-e8d1-454a-6bf04ce97faf@oracle.com> References: <6c17402e-15b6-0011-02bd-3112587c8bdb@oracle.com> <39A3AEB9-5055-4E61-BA35-F64C7CEECBA3@amazon.com> <23399c0b-cc14-e8d1-454a-6bf04ce97faf@oracle.com> Message-ID: <5C105462.6010200@oracle.com> Hello, My general guidance for backports has always been "don't create the backport before you need it." Often that means letting the hgupdater daemon create one on your behalf when you push. At other time, when administrative approval are needed ahead of time, the backport can be created manually or via a script. A CSR should be created off of a backport; a backport should not be created from a CSR request. If that is possible now, we will look to remove that capability in a JBS update. HTH, -Joe On 12/9/2018 11:44 PM, David Holmes wrote: > Hi Paul, > > On 8/12/2018 3:02 am, Hohensee, Paul wrote: >> Would it perhaps be better to create a manual backport issue for the >> CSR first, get that approved, then follow the normal process for the >> backport itself? > > Although JBS seems to allow it, as I understand it a "backport" issue > is expected to be associated with a "bug" or "enhancement" not a "csr > request". It's not at all clear the expected relationships would be > created if you did it the way you suggest. > > cc'd crs-discuss for furtehr comment. > > Cheers, > David > >> >> Paul >> >> ?On 12/6/18, 1:26 PM, "jdk-updates-dev on behalf of David Holmes" >> > david.holmes at oracle.com> wrote: >> >> Hi, >> The updates wiki pages states: >> "If a change requires CSR approval, that approval must be >> obtained prior >> to making the push approval request." >> but the CSR approval process for a backport is not defined >> anywhere as >> far as I can see. After discussion with the CSR Group lead it >> seems the >> expectation is that a manual backport issue must be created >> first, and >> then a CSR for that backport can be created. can this >> information be >> added to the updates page and/or the CSR FAQ and linked from the >> updates >> page. >> Thanks, >> David >>