From david.holmes at oracle.com Fri Jan 19 01:28:28 2018 From: david.holmes at oracle.com (David Holmes) Date: Fri, 19 Jan 2018 11:28:28 +1000 Subject: Multi-part CSR requests? Message-ID: <50661545-8666-4637-945f-82e898e18a74@oracle.com> I'm working on a feature that involves changes to the JLS, JVMS, existing java.lang APIs and adds some new APIs. The changes will be pushed altogether under one bug id. That implies one CSR request for that bug id. One CSR request for all these changes seems rather complex. Is it expected to just do one CSR request, or should I create subtasks of the main bug and then create a CSR for each subtask? Thanks, David From joe.darcy at oracle.com Fri Jan 19 18:24:19 2018 From: joe.darcy at oracle.com (joe darcy) Date: Fri, 19 Jan 2018 10:24:19 -0800 Subject: Multi-part CSR requests? In-Reply-To: <50661545-8666-4637-945f-82e898e18a74@oracle.com> References: <50661545-8666-4637-945f-82e898e18a74@oracle.com> Message-ID: Hi David, On 1/18/2018 5:28 PM, David Holmes wrote: > I'm working on a feature that involves changes to the JLS, JVMS, > existing java.lang APIs and adds some new APIs. The changes will be > pushed altogether under one bug id. That implies one CSR request for > that bug id. > > One CSR request for all these changes seems rather complex. Is it > expected to just do one CSR request, or should I create subtasks of > the main bug and then create a CSR for each subtask? > In general, there should be a correspondence between bugs and their CSRs. The CSR strives to support different working styles. Some people prefer a few very large changes spanning many areas, as used by the Jigsaw team in JDK 9; others prefer a larger number of smaller changes (my preferred style for my own CSR work). In this case, if you don't want one very encompassing CSR, I recommend using 3 or 4 separate bugs (one for JLS, one for JVMS, one or two for APIs, etc.) and 3 or 4 matching CSRs that all got pushed together under one changeset (or as multiple changests pushed simultaneously). HTH, -Joe From joe.darcy at oracle.com Sat Jan 20 03:50:27 2018 From: joe.darcy at oracle.com (joe darcy) Date: Fri, 19 Jan 2018 19:50:27 -0800 Subject: FYI, "import-preserve" label being added to CSR issues in the CCC project Message-ID: <2138a41e-f425-b4a7-3472-d6260eb81e00@oracle.com> Hello, FYI, to aid some of the logistics around completing the transition away from the earlier ccc process to the CSR, the visible CSR issues in the CCC project will have an "import-preserve" label added. As a reminder, when the transition is complete, these issues will be moved from the CCC project into the JDK project, alongside all other JDK bugs, enhancements, CSRs for JDK 10, etc. Cheers, -Joe