RFR: JDK-8047810, DeviceManager throws IOException while opening port by config

Alexey Konstantinov alexey.konstantinov at oracle.com
Wed Aug 13 14:42:37 UTC 2014


Hi Jen,

The changes look fine, except tthat I'd even suggest using this check

845     while(JAVACALL_OK == (listOperationsResult = 
javautil_list_get_next(list, (javacall_handle*) &pin))) {
instead of
845     while(JAVACALL_FAIL != (listOperationsResult = 
javautil_list_get_next(list, (javacall_handle*) &pin))) {

Thanks,
Alexey

On 8/13/2014 1:25 AM, Jen Dority wrote:
> issue: https://bugs.openjdk.java.net/browse/JDK-8047810
> webrev: http://cr.openjdk.java.net/~jld/8047810/
>
> Hi All,
>
> Need a review for an issue keeping GPIOPort APIs from working 
> properly. Traced the issue to bad return value checking (looking for 
> JAVACALL_DIO_FAIL instead of JAVACALL_FAIL) and made some additional 
> cleanup to issues I found along the way.
>
> Thanks,
> Jen
>
>
>
>



More information about the dio-dev mailing list