RFR: JDK-8054922 - UART timeout and threshold & JDK-8053930 - UART always returns 7 bit per char

Alexey Konstantinov alexey.konstantinov at oracle.com
Wed Aug 13 16:12:23 UTC 2014


Hi Jen,

Everything looks fine, great job! I've got just a few remarks:
1) the event handling bug fixes could be propagated to the 
com.oracle.dio.uart.impl.ModemSignalDispatcher class, which has the very 
similar implementation problems
2) gpio_resource.h can be removed now
3) javacall_serial.h copyright is not updated

Thanks,
Alexey

On 8/12/2014 8:22 PM, Jen Dority wrote:
> issues: JDK-8053930 <https://bugs.openjdk.java.net/browse/JDK-8053930> 
> & JDK-8054922 <https://bugs.openjdk.java.net/browse/JDK-8054922>
> webrev: http://cr.openjdk.java.net/~jld/8054922/
>
> Hi All,
>
> Need a review for an update to the UART code. These changes  add a 
> timeout event, reorganize the the uart ccode, and fix a few bugs with 
> the UART event handling that were found while testing these changes.
>
> Thanks,
> Jen
>
>



More information about the dio-dev mailing list