RFR: JDK-8054922 - UART timeout and threshold & JDK-8053930 - UART always returns 7 bit per char
Jen Dority
jen.dority at oracle.com
Wed Aug 13 19:21:33 UTC 2014
Thanks Alexey.
Jen
On 8/13/2014 3:20 PM, Alexey Konstantinov wrote:
> Hi Jen,
>
> The updated changeset looks OK.
>
> Thanks,
> Alexey
>
> On 8/13/2014 10:30 PM, Jen Dority wrote:
>> Updated webrev:
>> http://bussund0416/export/users/jdority/webrevs/8054922/webrev/index.html
>>
>> Addressed all of Alexey's comments and removed the two now unused
>> stub functions declared in gpio_resource.h from gpio.c.
>>
>> Thanks,
>> Jen
>>
>> On 8/13/2014 2:07 PM, Jen Dority wrote:
>>> Hi Alexey,
>>>
>>> On 8/13/2014 12:12 PM, Alexey Konstantinov wrote:
>>>> Hi Jen,
>>>>
>>>> Everything looks fine, great job! I've got just a few remarks:
>>>> 1) the event handling bug fixes could be propagated to the
>>>> com.oracle.dio.uart.impl.ModemSignalDispatcher class, which has the
>>>> very similar implementation problems
>>> OK, I will make them there as well.
>>>
>>>> 2) gpio_resource.h can be removed now
>>> Will do.
>>>> 3) javacall_serial.h copyright is not updated
>>> Will fix.
>>>
>>> Thanks,
>>> Jen
>>>>
>>>> Thanks,
>>>> Alexey
>>>>
>>>> On 8/12/2014 8:22 PM, Jen Dority wrote:
>>>>> issues: JDK-8053930
>>>>> <https://bugs.openjdk.java.net/browse/JDK-8053930> & JDK-8054922
>>>>> <https://bugs.openjdk.java.net/browse/JDK-8054922>
>>>>> webrev: http://cr.openjdk.java.net/~jld/8054922/
>>>>>
>>>>> Hi All,
>>>>>
>>>>> Need a review for an update to the UART code. These changes add a
>>>>> timeout event, reorganize the the uart ccode, and fix a few bugs
>>>>> with the UART event handling that were found while testing these
>>>>> changes.
>>>>>
>>>>> Thanks,
>>>>> Jen
>>>>>
>>>>>
>>>>
>>>
>>
>
More information about the dio-dev
mailing list