RFR: JDK-8054999 - create support for custom security policy

[Stas Smirnov]

Hi Alexey,

thank you for taking a look on the review.
Well, referring to the docs 
<http://docs.oracle.com/javase/8/docs/api/java/security/Policy.html#getPermissions-java.security.CodeSource-> 
GPIOPolicy.getPermissions() returns a PermissionCollection object and so 
do I. I actually return a single instance of PermissionCollection, not a 
new one, but the only one, this instance is being created in the init() 
method and only once cause it is static and created only in case it has 
not already been created.
Did I answer your question or I missed something?

13.08.2014 23:12, Alexey Konstantinov пишет:
> Hi Stas,
>
> Looks OK to me. Probably it is not relevant to your task and it works 
> as it is, but for the sake of correctness, shouldn't 
> GPIOPolicy.getPermissions() return a new instance of 
> PermissionCollection as the spec requires?
>
> Thanks,
> Alexey
>
> On 8/13/2014 7:30 PM, Stas Smirnov wrote:
>> issue: JDK-8054999 <https://bugs.openjdk.java.net/browse/JDK-8054999>
>> webrev: http://cr.openjdk.java.net/~stsmirno/8054999/webrev/
>>
>> Hi All,
>>
>> Need a review for an update.
>> These changes  add two custom classes to be able to set Policy 
>> programmatically without any need to specify java.security.policy 
>> file in the command line.
>


-- 

Best regards,
Stas Smirnov

Stas Smirnov | Java Embedded
Phone: +7 812 3346130 | Mobile: +7 921 9262241
Oracle Development SPB, LLC
10th Krasnoarmeyskaya 22A, St. Petersburg, 190103, Russia