RFR: JDK-8055209 - create initial set of SPI tests
Alexey Konstantinov
alexey.konstantinov at oracle.com
Fri Aug 15 15:14:36 UTC 2014
Hi Stas,
Could you double check the test logic of
SPIWriteAndReadTest.testWriteAndRead()? I'd suppose that the final check
srcStr.equals(dstStr)) will always fail, because it does not seem to me
that there are any reasons for dstStr to get updated as result of
writing something to the dst buffer.
Thanks,
Alexey
On 8/15/2014 6:54 PM, Stas Smirnov wrote:
> Please use this, correct link to the webrev
> <http://cr.openjdk.java.net/%7Estsmirno/8055209c/>
>
> 15.08.2014 18:03, Stas Smirnov пишет:
>> issue: JDK-8055209 <https://bugs.openjdk.java.net/browse/JDK-8055209>
>> webrev: 8055137 <http://cr.openjdk.java.net/%7Estsmirno/8055209/>
>>
>> Hi All,
>>
>> Need a review for an update.
>> In this update I have added 4 tests classes, to verify config, to
>> verify permissions, word length and write/read operation and fixed a
>> typo in the testbase class.
>>
>> --
>>
>> Best regards,
>> Stas Smirnov
>>
>> Stas Smirnov | Java Embedded
>> Phone: +7 812 3346130 | Mobile: +7 921 9262241
>> Oracle Development SPB, LLC
>> 10th Krasnoarmeyskaya 22A, St. Petersburg, 190103, Russia
>>
>
>
More information about the dio-dev
mailing list