RFR: JDK-8055209 - create initial set of SPI tests

Stas Smirnov stanislav.smirnov at oracle.com
Fri Aug 15 15:38:12 UTC 2014


Alexey, thanks for catching this, my eyes were closed when I put it there:)

right thing will be
                 String srcStr = new String(src.array());

                 System.out.println("Write SPI: data = " + srcStr);
                 spiDevice.writeAndRead(src, dst);
                 spiDevice.end();

                 String dstStr = new String(dst.array());
                 System.out.println("Read SPI: " + dstStr);

                 if(!srcStr.equals(dstStr)){
                     result = printFailedStatus("Data does not match");
                 }

15.08.2014 19:14, Alexey Konstantinov пишет:
> Hi Stas,
>
> Could you double check the test logic of 
> SPIWriteAndReadTest.testWriteAndRead()? I'd suppose that the final 
> check srcStr.equals(dstStr)) will always fail, because it does not 
> seem to me that there are any reasons for dstStr to get updated as 
> result of writing something to the dst buffer.
>
> Thanks,
> Alexey
>
> On 8/15/2014 6:54 PM, Stas Smirnov wrote:
>> Please use this, correct link to the webrev 
>> <http://cr.openjdk.java.net/%7Estsmirno/8055209c/>
>>
>> 15.08.2014 18:03, Stas Smirnov пишет:
>>> issue: JDK-8055209 <https://bugs.openjdk.java.net/browse/JDK-8055209>
>>> webrev: 8055137 <http://cr.openjdk.java.net/%7Estsmirno/8055209/>
>>>
>>> Hi All,
>>>
>>> Need a review for an update.
>>> In this update I have added 4 tests classes, to verify config, to 
>>> verify permissions, word length and write/read operation and fixed a 
>>> typo in the testbase class.
>>>
>>> -- 
>>>
>>> Best regards,
>>> Stas Smirnov
>>>
>>> Stas Smirnov | Java Embedded
>>> Phone: +7 812 3346130 | Mobile: +7 921 9262241
>>> Oracle Development SPB, LLC
>>> 10th Krasnoarmeyskaya 22A, St. Petersburg, 190103, Russia
>>>
>>
>>
>


-- 

Best regards,
Stas Smirnov

Stas Smirnov | Java Embedded
Phone: +7 812 3346130 | Mobile: +7 921 9262241
Oracle Development SPB, LLC
10th Krasnoarmeyskaya 22A, St. Petersburg, 190103, Russia



More information about the dio-dev mailing list