RFR: JDK-8055187 - create UART testbase

Jen Dority jen.dority at oracle.com
Mon Aug 18 14:52:24 UTC 2014


Hi Stas.

Looks good.

Thanks,
Jen

On 8/15/2014 11:00 AM, Stas Smirnov wrote:
> Here is an updated webrev 
> <http://cr.openjdk.java.net/%7Estsmirno/8055187b/>
>
> 15.08.2014 18:45, Stas Smirnov пишет:
>> Thanks for catching this
>>
>>
>> 15.08.2014 18:42, Alexey Konstantinov пишет:
>>> Hi Stas,
>>>
>>> UARTTestBase.setupUartConfig looks like having a few copy/paste 
>>> leftovers, see "spi" in the variable naming. The rest looks OK to me.
>>>
>>> Thanks,
>>> Alexey
>>>
>>> On 8/15/2014 6:14 PM, Stas Smirnov wrote:
>>>> issue: JDK-8055187 <https://bugs.openjdk.java.net/browse/JDK-8055187>
>>>> webrev: 8055187 <http://cr.openjdk.java.net/%7Estsmirno/8055187/>
>>>>
>>>> Hi All,
>>>>
>>>> Need a review for an update.
>>>> In this update I have added UART testbase to handle config and run 
>>>> tests properly, further I will develop set of tests based on this.
>>>>
>>>
>>
>>
>
>



More information about the dio-dev mailing list