From alexey.mironov at oracle.com Mon Dec 1 14:59:22 2014 From: alexey.mironov at oracle.com (alexey mironov) Date: Mon, 01 Dec 2014 17:59:22 +0300 Subject: RFR: JDK-8066260 - I2CSlave - wrong return value in trasfer method Message-ID: <547C824A.8010906@oracle.com> issue: https://bugs.openjdk.java.net/browse/JDK-8066260 webrev: http://cr.openjdk.java.net/~amironov/8066260/ Please review the changes made in order to fix wrong return value in I2CSlaveImpl. Regards, Alexey From alexey.mironov at oracle.com Mon Dec 1 15:00:59 2014 From: alexey.mironov at oracle.com (alexey mironov) Date: Mon, 01 Dec 2014 18:00:59 +0300 Subject: RFR: JDK-8065384 - DIO permission action verification redesign Message-ID: <547C82AB.60703@oracle.com> issue: https://bugs.openjdk.java.net/browse/JDK-8065384 webrev: http://cr.openjdk.java.net/~amironov/8065384/ Please review the changes made in order to improve action verification. Regards, Alexey From alexey.mironov at oracle.com Mon Dec 1 15:02:04 2014 From: alexey.mironov at oracle.com (alexey mironov) Date: Mon, 01 Dec 2014 18:02:04 +0300 Subject: RFR: JDK-8066263 - Split UARTimpl and UARTModemImpl implementation in DIO realization Message-ID: <547C82EC.3080102@oracle.com> issue: https://bugs.openjdk.java.net/browse/JDK-8066263 webrev: http://cr.openjdk.java.net/~amironov/8066263/ Please review the changes made in order to split UART and UARTModem implementations. Regards, Alexey From alexey.mironov at oracle.com Mon Dec 1 15:03:13 2014 From: alexey.mironov at oracle.com (alexey mironov) Date: Mon, 01 Dec 2014 18:03:13 +0300 Subject: RFR: JDK-8066264 - OOM when SPI.writeAndRead with skip Message-ID: <547C8331.9000601@oracle.com> issue: https://bugs.openjdk.java.net/browse/JDK-8066264 webrev: http://cr.openjdk.java.net/~amironov/8066264/ Please review the changes made in order to fix the case when write buffer is exhausted but there is space to read. Regards, Alexey From alexey.mironov at oracle.com Mon Dec 1 15:06:13 2014 From: alexey.mironov at oracle.com (alexey mironov) Date: Mon, 01 Dec 2014 18:06:13 +0300 Subject: RFR: JDK-8065371 - Redesign GPIOPortImpl impl in pure java code Message-ID: <547C83E5.4060302@oracle.com> issue: https://bugs.openjdk.java.net/browse/JDK-8065371 webrev: http://cr.openjdk.java.net/~amironov/8065371.1/ Please review new diff for GPIOPortImpl. Regards, Alexey From sergey.nazarkin at oracle.com Mon Dec 1 16:43:11 2014 From: sergey.nazarkin at oracle.com (sergey.nazarkin at oracle.com) Date: Mon, 01 Dec 2014 16:43:11 +0000 Subject: hg: dio/dev: 8065776: UART right initial value for controller number Message-ID: <201412011643.sB1GhCMm017408@aojmv0008> Changeset: fdf76602f5b7 Author: snazarki Date: 2014-12-01 20:40 +0400 URL: http://hg.openjdk.java.net/dio/dev/rev/fdf76602f5b7 8065776: UART right initial value for controller number Summary: Corrected controllerNumber and controllerName verification Reviewed-by: snazarki Contributed-by: alexey.mironov at oracle.com ! src/share/classes/jdk/dio/uart/UARTConfig.java From sergey.nazarkin at oracle.com Mon Dec 1 16:44:59 2014 From: sergey.nazarkin at oracle.com (Sergey Nazarkin) Date: Mon, 01 Dec 2014 19:44:59 +0300 Subject: RFR: JDK-8065371 - Redesign GPIOPortImpl impl in pure java code In-Reply-To: <547C83E5.4060302@oracle.com> References: <547C83E5.4060302@oracle.com> Message-ID: <547C9B0B.9050005@oracle.com> Please be more careful with review request. Proposed changes are not related to the issue description. Please drop it /Sergey On 01.12.2014 18:06, alexey mironov wrote: > issue: https://bugs.openjdk.java.net/browse/JDK-8065371 > > webrev: http://cr.openjdk.java.net/~amironov/8065371.1/ > > > Please review new diff for GPIOPortImpl. > > Regards, > Alexey From sergey.nazarkin at oracle.com Mon Dec 1 16:47:30 2014 From: sergey.nazarkin at oracle.com (Sergey Nazarkin) Date: Mon, 01 Dec 2014 19:47:30 +0300 Subject: RFR: JDK-8066264 - OOM when SPI.writeAndRead with skip In-Reply-To: <547C8331.9000601@oracle.com> References: <547C8331.9000601@oracle.com> Message-ID: <547C9BA2.5070109@oracle.com> OK for me. BTW, why do you put wrong links in the brackets? /Sergey On 01.12.2014 18:03, alexey mironov wrote: > issue: https://bugs.openjdk.java.net/browse/JDK-8066264 > > webrev: http://cr.openjdk.java.net/~amironov/8066264/ > > > Please review the changes made in order to fix the case when write > buffer is exhausted but there is space to read. > > Regards, > Alexey From sergey.nazarkin at oracle.com Mon Dec 1 16:52:36 2014 From: sergey.nazarkin at oracle.com (Sergey Nazarkin) Date: Mon, 01 Dec 2014 19:52:36 +0300 Subject: RFR: JDK-8066263 - Split UARTimpl and UARTModemImpl implementation in DIO realization In-Reply-To: <547C82EC.3080102@oracle.com> References: <547C82EC.3080102@oracle.com> Message-ID: <547C9CD4.4020804@oracle.com> NOT OK. The changes are coming from fixes for different issues. Please, make correct merge of necessary code only /Sergey On 01.12.2014 18:02, alexey mironov wrote: > issue: https://bugs.openjdk.java.net/browse/JDK-8066263 > > webrev: http://cr.openjdk.java.net/~amironov/8066263/ > > > Please review the changes made in order to split UART and UARTModem > implementations. > > Regards, > Alexey From sergey.nazarkin at oracle.com Mon Dec 1 16:59:29 2014 From: sergey.nazarkin at oracle.com (Sergey Nazarkin) Date: Mon, 01 Dec 2014 19:59:29 +0300 Subject: RFR: JDK-8065384 - DIO permission action verification redesign In-Reply-To: <547C82AB.60703@oracle.com> References: <547C82AB.60703@oracle.com> Message-ID: <547C9E71.4060702@oracle.com> Please update issue description and put details about what has been done. The code is OK for me /Sergey On 01.12.2014 18:00, alexey mironov wrote: > issue: https://bugs.openjdk.java.net/browse/JDK-8065384 > > webrev: http://cr.openjdk.java.net/~amironov/8065384/ > > > Please review the changes made in order to improve action verification. > > Regards, > Alexey From sergey.nazarkin at oracle.com Mon Dec 1 17:00:29 2014 From: sergey.nazarkin at oracle.com (Sergey Nazarkin) Date: Mon, 01 Dec 2014 20:00:29 +0300 Subject: RFR: JDK-8066260 - I2CSlave - wrong return value in trasfer method In-Reply-To: <547C824A.8010906@oracle.com> References: <547C824A.8010906@oracle.com> Message-ID: <547C9EAD.7050304@oracle.com> Looks OK /Sergey On 01.12.2014 17:59, alexey mironov wrote: > issue: https://bugs.openjdk.java.net/browse/JDK-8066260 > > webrev: http://cr.openjdk.java.net/~amironov/8066260/ > > > Please review the changes made in order to fix wrong return value in > I2CSlaveImpl. > > Regards, > Alexey From jen.dority at oracle.com Mon Dec 1 17:26:22 2014 From: jen.dority at oracle.com (Jen Dority) Date: Mon, 01 Dec 2014 12:26:22 -0500 Subject: RFR: JDK-8066260 - I2CSlave - wrong return value in trasfer method In-Reply-To: <547C9EAD.7050304@oracle.com> References: <547C824A.8010906@oracle.com> <547C9EAD.7050304@oracle.com> Message-ID: <547CA4BE.8020903@oracle.com> Hi Alexey, A note about creating JIRA issues. It's fine to create a new issue by cloning an old issue so some default fields will be filled in properly, but you need to go back and delete the links to the old issues. Otherwise you are creating a lot of noise and false information for engineers that come along later. Jen On 12/1/2014 12:00 PM, Sergey Nazarkin wrote: > Looks OK > > /Sergey > > On 01.12.2014 17:59, alexey mironov wrote: >> issue: https://bugs.openjdk.java.net/browse/JDK-8066260 >> >> webrev: http://cr.openjdk.java.net/~amironov/8066260/ >> >> >> Please review the changes made in order to fix wrong return value in >> I2CSlaveImpl. >> >> Regards, >> Alexey > From jen.dority at oracle.com Mon Dec 1 19:28:36 2014 From: jen.dority at oracle.com (Jen Dority) Date: Mon, 01 Dec 2014 14:28:36 -0500 Subject: RFR: JDK-8066260 - I2CSlave - wrong return value in trasfer method In-Reply-To: <547C9EAD.7050304@oracle.com> References: <547C824A.8010906@oracle.com> <547C9EAD.7050304@oracle.com> Message-ID: <547CC164.5030907@oracle.com> Hi Alexey, Please revert the comment change on line 313. It introduces a typo. Thanks, Jen On 12/1/2014 12:00 PM, Sergey Nazarkin wrote: > Looks OK > > /Sergey > > On 01.12.2014 17:59, alexey mironov wrote: >> issue: https://bugs.openjdk.java.net/browse/JDK-8066260 >> >> webrev: http://cr.openjdk.java.net/~amironov/8066260/ >> >> >> Please review the changes made in order to fix wrong return value in >> I2CSlaveImpl. >> >> Regards, >> Alexey > From sergey.nazarkin at oracle.com Wed Dec 3 17:36:53 2014 From: sergey.nazarkin at oracle.com (sergey.nazarkin at oracle.com) Date: Wed, 03 Dec 2014 17:36:53 +0000 Subject: hg: dio/dev: 8066264: OOM when SPI.writeAndRead with skip Message-ID: <201412031736.sB3Har7W022091@aojmv0008> Changeset: 958ec7f4180f Author: snazarki Date: 2014-12-03 21:24 +0400 URL: http://hg.openjdk.java.net/dio/dev/rev/958ec7f4180f 8066264: OOM when SPI.writeAndRead with skip Summary: Fixed the case when write buffer is exhausted but there is space to read Reviewed-by: snazarki Contributed-by: alexey.mironov at oracle.com ! src/share/classes/com/oracle/dio/impl/AbstractPeripheral.java ! src/share/classes/com/oracle/dio/spibus/impl/SPISlaveImpl.java From sergey.nazarkin at oracle.com Wed Dec 3 18:03:43 2014 From: sergey.nazarkin at oracle.com (sergey.nazarkin at oracle.com) Date: Wed, 03 Dec 2014 18:03:43 +0000 Subject: hg: dio/dev: 2 new changesets Message-ID: <201412031803.sB3I3hC9026215@aojmv0008> Changeset: 7531895ef161 Author: snazarki Date: 2014-12-03 21:57 +0400 URL: http://hg.openjdk.java.net/dio/dev/rev/7531895ef161 8065384: DIO permission action verification redesign Summary: Remove dependency of ActionFactory from DevicePermission classes to make different device modules conditionally compiled. Reviewed-by: snazarki Contributed-by: alexey.mironov at oracle.com ! src/se/classes/jdk/dio/mmio/MMIOPermission.java ! src/share/classes/com/oracle/dio/utils/ActionFactory.java ! src/share/classes/jdk/dio/DeviceMgmtPermission.java ! src/share/classes/jdk/dio/DevicePermission.java ! src/share/classes/jdk/dio/adc/ADCPermission.java ! src/share/classes/jdk/dio/atcmd/ATPermission.java ! src/share/classes/jdk/dio/counter/CounterPermission.java ! src/share/classes/jdk/dio/dac/DACPermission.java ! src/share/classes/jdk/dio/generic/GenericPermission.java ! src/share/classes/jdk/dio/gpio/GPIOPinPermission.java ! src/share/classes/jdk/dio/gpio/GPIOPortPermission.java ! src/share/classes/jdk/dio/i2cbus/I2CPermission.java ! src/share/classes/jdk/dio/pwm/PWMPermission.java ! src/share/classes/jdk/dio/spibus/SPIPermission.java ! src/share/classes/jdk/dio/uart/UARTPermission.java ! src/share/classes/jdk/dio/watchdog/WatchdogTimerPermission.java Changeset: 4ab1a1b60e6c Author: snazarki Date: 2014-12-03 22:01 +0400 URL: http://hg.openjdk.java.net/dio/dev/rev/4ab1a1b60e6c 8066260: I2CSlave - wrong return value in trasfer method Summary: transfer() return -1 instead of 0. Reviewed-by: snazarki Contributed-by: alexey.mironov at oracle.com ! src/share/classes/com/oracle/dio/i2cbus/impl/I2CSlaveImpl.java From sergey.nazarkin at oracle.com Wed Dec 3 18:12:47 2014 From: sergey.nazarkin at oracle.com (sergey.nazarkin at oracle.com) Date: Wed, 03 Dec 2014 18:12:47 +0000 Subject: hg: dio/dev: 8065371: Correct private variable array type at GPIOPortConfig Message-ID: <201412031812.sB3IClLh028277@aojmv0008> Changeset: a5e2cee209be Author: snazarki Date: 2014-12-03 22:10 +0400 URL: http://hg.openjdk.java.net/dio/dev/rev/a5e2cee209be 8065371: Correct private variable array type at GPIOPortConfig Summary: Make it possible to assign alternative implementation of GPIOPin interface Reviewed-by: snazarki Contributed-by: alexey.mironov at oracle.com ! src/se/native/com/oracle/dio/gpio/impl/jni_gpio.cpp ! src/share/classes/jdk/dio/gpio/GPIOPortConfig.java From alexey.mironov at oracle.com Thu Dec 4 10:14:01 2014 From: alexey.mironov at oracle.com (alexey mironov) Date: Thu, 04 Dec 2014 13:14:01 +0300 Subject: RFR: JDK-8066263 - Split UARTimpl and UARTModemImpl implementation in DIO realization In-Reply-To: <547C82EC.3080102@oracle.com> References: <547C82EC.3080102@oracle.com> Message-ID: <548033E9.4010807@oracle.com> new webrev: http://cr.openjdk.java.net/~amironov/8066263.1/ Previous webrev contain fix for 2 bugs. I prepare new webrev. Please review it. Regards, Alexey On 01.12.2014 18:02, alexey mironov wrote: > issue: https://bugs.openjdk.java.net/browse/JDK-8066263 > > webrev: http://cr.openjdk.java.net/~amironov/8066263/ > > > Please review the changes made in order to split UART and UARTModem > implementations. > > Regards, > Alexey From sergey.nazarkin at oracle.com Thu Dec 4 10:49:43 2014 From: sergey.nazarkin at oracle.com (sergey.nazarkin at oracle.com) Date: Thu, 04 Dec 2014 10:49:43 +0000 Subject: hg: dio/dev: 8066263: Split UARTimpl and ModemUARTImpl implementation in DIO realization Message-ID: <201412041049.sB4AnhcW023654@aojmv0008> Changeset: 5d629ccf074a Author: snazarki Date: 2014-12-04 14:49 +0400 URL: http://hg.openjdk.java.net/dio/dev/rev/5d629ccf074a 8066263: Split UARTimpl and ModemUARTImpl implementation in DIO realization Summary: Making ModemUART implementation optional Reviewed-by: snazarki Contributed-by: alexey.mironov at oracle.com + src/se/native/com/oracle/dio/uart/impl/jni_modem.cpp ! src/se/native/com/oracle/dio/uart/impl/jni_uart.cpp ! src/share/classes/com/oracle/dio/uart/impl/ModemUARTFactory.java + src/share/classes/com/oracle/dio/uart/impl/ModemUARTImpl.java ! src/share/classes/com/oracle/dio/uart/impl/UARTImpl.java From sergey.nazarkin at oracle.com Thu Dec 4 10:49:58 2014 From: sergey.nazarkin at oracle.com (Sergey Nazarkin) Date: Thu, 04 Dec 2014 13:49:58 +0300 Subject: RFR: JDK-8066263 - Split UARTimpl and UARTModemImpl implementation in DIO realization In-Reply-To: <548033E9.4010807@oracle.com> References: <547C82EC.3080102@oracle.com> <548033E9.4010807@oracle.com> Message-ID: <54803C56.6060908@oracle.com> Looks OK /Sergey On 04.12.2014 13:14, alexey mironov wrote: > new webrev: http://cr.openjdk.java.net/~amironov/8066263.1/ > > Previous webrev contain fix for 2 bugs. I prepare new webrev. Please > review it. > > Regards, > Alexey > > On 01.12.2014 18:02, alexey mironov wrote: >> issue: https://bugs.openjdk.java.net/browse/JDK-8066263 >> >> webrev: http://cr.openjdk.java.net/~amironov/8066263/ >> >> >> Please review the changes made in order to split UART and UARTModem >> implementations. >> >> Regards, >> Alexey > From alexey.mironov at oracle.com Thu Dec 4 11:48:48 2014 From: alexey.mironov at oracle.com (alexey mironov) Date: Thu, 04 Dec 2014 14:48:48 +0300 Subject: RFR: JDK-8066676 - Add privilege API for JavaME compatibility Message-ID: <54804A20.1010302@oracle.com> issue: https://bugs.openjdk.java.net/browse/JDK-8066676 webrev: http://cr.openjdk.java.net/~amironov/8066676/ Please review the changes made in order to add privilege API for JavaME compatibility. Regards, Alexey From sergey.nazarkin at oracle.com Thu Dec 4 12:10:44 2014 From: sergey.nazarkin at oracle.com (Sergey Nazarkin) Date: Thu, 04 Dec 2014 15:10:44 +0300 Subject: RFR: JDK-8066676 - Add privilege API for JavaME compatibility In-Reply-To: <54804A20.1010302@oracle.com> References: <54804A20.1010302@oracle.com> Message-ID: <54804F44.9030609@oracle.com> Looks OK /Sergey On 04.12.2014 14:48, alexey mironov wrote: > issue: https://bugs.openjdk.java.net/browse/JDK-8066676 > webrev: http://cr.openjdk.java.net/~amironov/8066676/ > > Please review the changes made in order to add privilege API for > JavaME compatibility. > > Regards, > Alexey From jen.dority at oracle.com Thu Dec 4 13:08:02 2014 From: jen.dority at oracle.com (Jen Dority) Date: Thu, 04 Dec 2014 08:08:02 -0500 Subject: RFR: JDK-8066263 - Split UARTimpl and UARTModemImpl implementation in DIO realization In-Reply-To: <54803C56.6060908@oracle.com> References: <547C82EC.3080102@oracle.com> <548033E9.4010807@oracle.com> <54803C56.6060908@oracle.com> Message-ID: <54805CB2.70101@oracle.com> Why this change? @@ -209,9 +203,6 @@ } // first port in list is DEFAULT port String ports = Configuration.getProperty("microedition.commports"); - if (ports == null) { - ports = Configuration.getProperty("jdk.dio.uart.ports"); - } if (null != ports) { StringTokenizer t = new StringTokenizer(ports, ","); while(devNum-- > 0 && t.hasMoreTokens()) { This had nothing to do with the issue. The microedition.* property isn't appropriate for SE. IMO, we should put this back and get get it officially sanctioned in the spec. Jen On 12/4/2014 5:49 AM, Sergey Nazarkin wrote: > Looks OK > > /Sergey > > On 04.12.2014 13:14, alexey mironov wrote: >> new webrev: http://cr.openjdk.java.net/~amironov/8066263.1/ >> >> Previous webrev contain fix for 2 bugs. I prepare new webrev. Please >> review it. >> >> Regards, >> Alexey >> >> On 01.12.2014 18:02, alexey mironov wrote: >>> issue: https://bugs.openjdk.java.net/browse/JDK-8066263 >>> >>> webrev: http://cr.openjdk.java.net/~amironov/8066263/ >>> >>> >>> Please review the changes made in order to split UART and UARTModem >>> implementations. >>> >>> Regards, >>> Alexey >> > From sergey.nazarkin at oracle.com Thu Dec 4 13:26:47 2014 From: sergey.nazarkin at oracle.com (Sergey Nazarkin) Date: Thu, 04 Dec 2014 16:26:47 +0300 Subject: RFR: JDK-8066263 - Split UARTimpl and UARTModemImpl implementation in DIO realization In-Reply-To: <54805CB2.70101@oracle.com> References: <547C82EC.3080102@oracle.com> <548033E9.4010807@oracle.com> <54803C56.6060908@oracle.com> <54805CB2.70101@oracle.com> Message-ID: <54806117.6010201@oracle.com> This part of implementation internals not covered by the spec. Actually, it should not be. But I agree this change is result of inaccurate merge. /Sergey On 04.12.2014 16:08, Jen Dority wrote: > Why this change? > > @@ -209,9 +203,6 @@ > } > // first port in list is DEFAULT port > String ports = > Configuration.getProperty("microedition.commports"); > - if (ports == null) { > - ports = Configuration.getProperty("jdk.dio.uart.ports"); > - } > if (null != ports) { > StringTokenizer t = new StringTokenizer(ports, ","); > while(devNum-- > 0 && t.hasMoreTokens()) { > > This had nothing to do with the issue. The microedition.* property > isn't appropriate for SE. IMO, we should put this back and get get it > officially sanctioned in the spec. > > Jen > > > On 12/4/2014 5:49 AM, Sergey Nazarkin wrote: >> Looks OK >> >> /Sergey >> >> On 04.12.2014 13:14, alexey mironov wrote: >>> new webrev: http://cr.openjdk.java.net/~amironov/8066263.1/ >>> >>> Previous webrev contain fix for 2 bugs. I prepare new webrev. Please >>> review it. >>> >>> Regards, >>> Alexey >>> >>> On 01.12.2014 18:02, alexey mironov wrote: >>>> issue: https://bugs.openjdk.java.net/browse/JDK-8066263 >>>> >>>> webrev: http://cr.openjdk.java.net/~amironov/8066263/ >>>> >>>> >>>> Please review the changes made in order to split UART and UARTModem >>>> implementations. >>>> >>>> Regards, >>>> Alexey >>> >> > From alexey.mironov at oracle.com Thu Dec 4 15:30:31 2014 From: alexey.mironov at oracle.com (alexey mironov) Date: Thu, 04 Dec 2014 18:30:31 +0300 Subject: FR: JDK-8066691 - Expected UnavailableDeviceException is not thrown when again openning UART in EXCLUSIVE mode Message-ID: <54807E17.4040200@oracle.com> issue: https://bugs.openjdk.java.net/browse/JDK-8066691 webrev: http://cr.openjdk.java.net/~amironov/8066691/ Please review the changes made in order to fix problem with not thrown UnavailableDeviceException. Regards, Alexey From sergey.nazarkin at oracle.com Thu Dec 4 16:08:40 2014 From: sergey.nazarkin at oracle.com (Sergey Nazarkin) Date: Thu, 04 Dec 2014 19:08:40 +0300 Subject: FR: JDK-8066691 - Expected UnavailableDeviceException is not thrown when again openning UART in EXCLUSIVE mode In-Reply-To: <54807E17.4040200@oracle.com> References: <54807E17.4040200@oracle.com> Message-ID: <54808708.6020903@oracle.com> Please provide detailed description /Sergey On 04.12.2014 18:30, alexey mironov wrote: > issue: https://bugs.openjdk.java.net/browse/JDK-8066691 > webrev: http://cr.openjdk.java.net/~amironov/8066691/ > > Please review the changes made in order to fix problem with not thrown > UnavailableDeviceException. > > Regards, > Alexey From sergey.nazarkin at oracle.com Fri Dec 5 16:08:55 2014 From: sergey.nazarkin at oracle.com (sergey.nazarkin at oracle.com) Date: Fri, 05 Dec 2014 16:08:55 +0000 Subject: hg: dio/dev: 2 new changesets Message-ID: <201412051608.sB5G8t0V028952@aojmv0008> Changeset: c69cb4805050 Author: snazarki Date: 2014-12-05 19:57 +0400 URL: http://hg.openjdk.java.net/dio/dev/rev/c69cb4805050 8066691: Expected UnavailableDeviceException is not thrown when again openning UART in EXCLUSIVE mode Summary: Open device list is kept for source compatibility with JavaME. File lock to prevent access from different process. Reviewed-by: snazarki Contributed-by: alexey.mironov at oracle.com ! src/share/linux/native/com/oracle/dio/uart/serial.c ! src/share/linux/native/com/oracle/dio/uart/serial.h ! src/share/linux/native/com/oracle/dio/uart/uart.c + src/share/linux/native/com/oracle/dio/utils/list_helper.c + src/share/native/com/oracle/dio/list_helper.h Changeset: b583dbc924ea Author: snazarki Date: 2014-12-05 20:08 +0400 URL: http://hg.openjdk.java.net/dio/dev/rev/b583dbc924ea 8066676: Add privilege API for JavaME compatibility Summary: To maintain source level compatibility with JavaME API to save, restore, drop privileges and stubs for SE implementation were added. Reviewed-by: snazarki Contributed-by: alexey.mironov at oracle.com ! src/share/linux/native/com/oracle/dio/gpio/gpio.c ! src/share/linux/native/com/oracle/dio/i2c/i2c.c ! src/share/linux/native/com/oracle/dio/mmio/mmio.c ! src/share/linux/native/com/oracle/dio/spibus/spi.c + src/share/linux/native/com/oracle/dio/stub/privilige_manager.c + src/share/native/com/oracle/dio/privilege_manager.h From alexey.mironov at oracle.com Mon Dec 8 14:56:52 2014 From: alexey.mironov at oracle.com (alexey mironov) Date: Mon, 08 Dec 2014 17:56:52 +0300 Subject: RFR: JDK-8066263 - Split UARTimpl and UARTModemImpl implementation in DIO realization Message-ID: <5485BC34.6070003@oracle.com> new webrev: http://cr.openjdk.java.net/~amironov/8066263.2/ I put back this code. Please review new webrev. Regards, Alexey On 12/4/2014 08:08 AM, Jen Dority wrote: > Why this change? > > @@ -209,9 +203,6 @@ > } > // first port in list is DEFAULT port > String ports = Configuration.getProperty("microedition.commports"); > - if (ports == null) { > - ports = Configuration.getProperty("jdk.dio.uart.ports"); > - } > if (null != ports) { > StringTokenizer t = new StringTokenizer(ports, ","); > while(devNum-- > 0 && t.hasMoreTokens()) { > > This had nothing to do with the issue. The microedition.* property isn't appropriate for SE. IMO, we should put this back and get get it officially sanctioned in the spec. > > Jen > > > On 12/4/2014 5:49 AM, Sergey Nazarkin wrote: >> Looks OK >> >> /Sergey >> >> On 04.12.2014 13:14, alexey mironov wrote: >>> new webrev:http://cr.openjdk.java.net/~amironov/8066263.1/ >>> >>> Previous webrev contain fix for 2 bugs. I prepare new webrev. Please >>> review it. >>> >>> Regards, >>> Alexey >>> >>> On 01.12.2014 18:02, alexey mironov wrote: >>>> issue:https://bugs.openjdk.java.net/browse/JDK-8066263 >>>> >>>> webrev:http://cr.openjdk.java.net/~amironov/8066263/ >>>> >>>> >>>> Please review the changes made in order to split UART and UARTModem >>>> implementations. >>>> >>>> Regards, >>>> Alexey >>> >> From alexey.mironov at oracle.com Mon Dec 8 17:46:30 2014 From: alexey.mironov at oracle.com (alexey mironov) Date: Mon, 08 Dec 2014 20:46:30 +0300 Subject: RFR: JDK-8066898 - Small type mismatch at native files Message-ID: <5485E3F6.5080700@oracle.com> issue: https://bugs.openjdk.java.net/browse/JDK-8066898 webrev: http://cr.openjdk.java.net/~amironov/8066898/ Hi All, Please review the changes made in order to fix the issue with the type mismatching. Regards, Alexey From sergey.nazarkin at oracle.com Tue Dec 9 10:28:31 2014 From: sergey.nazarkin at oracle.com (Sergey Nazarkin) Date: Tue, 09 Dec 2014 13:28:31 +0300 Subject: RFR: JDK-8066898 - Small type mismatch at native files In-Reply-To: <5485E3F6.5080700@oracle.com> References: <5485E3F6.5080700@oracle.com> Message-ID: <5486CECF.5040402@oracle.com> Looks OK for me /Sergey On 08.12.2014 20:46, alexey mironov wrote: > issue: https://bugs.openjdk.java.net/browse/JDK-8066898 > webrev: http://cr.openjdk.java.net/~amironov/8066898/ > > Hi All, > Please review the changes made in order to fix the issue with the type > mismatching. > > Regards, > Alexey From alexey.mironov at oracle.com Tue Dec 9 11:50:07 2014 From: alexey.mironov at oracle.com (alexey mironov) Date: Tue, 09 Dec 2014 14:50:07 +0300 Subject: RFR: JDK-8066954 - Split UARTimpl and UARTModemImpl implementation in DIO realization Message-ID: <5486E1EF.8030900@oracle.com> issue: https://bugs.openjdk.java.net/browse/JDK-8066954 webrev: http://cr.openjdk.java.net/~amironov/8066954/ Hi All, Please review changes made in order to recover getting jdk.dio.uart.ports in UARTImpl. Regards, Alexey From sergey.nazarkin at oracle.com Tue Dec 9 11:55:43 2014 From: sergey.nazarkin at oracle.com (Sergey Nazarkin) Date: Tue, 09 Dec 2014 14:55:43 +0300 Subject: RFR: JDK-8066954 - Split UARTimpl and UARTModemImpl implementation in DIO realization In-Reply-To: <5486E1EF.8030900@oracle.com> References: <5486E1EF.8030900@oracle.com> Message-ID: <5486E33F.1040605@oracle.com> Looks OK for me /Sergey On 09.12.2014 14:50, alexey mironov wrote: > issue: https://bugs.openjdk.java.net/browse/JDK-8066954 > webrev: http://cr.openjdk.java.net/~amironov/8066954/ > > Hi All, > Please review changes made in order to recover getting > jdk.dio.uart.ports in UARTImpl. > > Regards, > Alexey From sergey.nazarkin at oracle.com Thu Dec 11 09:53:19 2014 From: sergey.nazarkin at oracle.com (sergey.nazarkin at oracle.com) Date: Thu, 11 Dec 2014 09:53:19 +0000 Subject: hg: dio/dev: 2 new changesets Message-ID: <201412110953.sBB9rKqp013510@aojmv0008> Changeset: 57d30652361c Author: snazarki Date: 2014-12-11 13:48 +0400 URL: http://hg.openjdk.java.net/dio/dev/rev/57d30652361c 8066954: Recovery the jdk.dio.uart.ports property in UARTImpl Summary: Reverted piece of code removed occasionally in one of previous commit Reviewed-by: snazarki Contributed-by: alexey.mironov at oracle.com ! src/share/classes/com/oracle/dio/uart/impl/UARTImpl.java Changeset: a6e7bcf2492e Author: snazarki Date: 2014-12-11 13:53 +0400 URL: http://hg.openjdk.java.net/dio/dev/rev/a6e7bcf2492e 8066898: Small type mismatch at native files Summary: Fixed return value for a number of functions Reviewed-by: snazarki Contributed-by: alexey.mironov at oracle.com ! src/share/linux/native/com/oracle/dio/gpio/gpio.c ! src/share/linux/native/com/oracle/dio/mmio/mmio.c ! src/share/linux/native/com/oracle/dio/spibus/spi.c ! src/share/linux/native/com/oracle/dio/uart/uart.c From alexey.mironov at oracle.com Thu Dec 11 19:38:30 2014 From: alexey.mironov at oracle.com (alexey mironov) Date: Thu, 11 Dec 2014 22:38:30 +0300 Subject: RFR: JDK-8067292 - Hangs when read in UARTEvent.INPUT_DATA_AVAILABLE callback in JavaME Message-ID: <5489F2B6.1060005@oracle.com> issue: https://bugs.openjdk.java.net/browse/JDK-8067292 webrev: http://cr.openjdk.java.net/~amironov/8067292/ Please review the changes made in order to add code that fix problem with hangs in JavaME. Regards, Alexey From alexey.mironov at oracle.com Thu Dec 11 19:40:43 2014 From: alexey.mironov at oracle.com (alexey mironov) Date: Thu, 11 Dec 2014 22:40:43 +0300 Subject: RFR: JDK-8067288 - Add const qualifier in properties and serial Message-ID: <5489F33B.3090700@oracle.com> issue: https://bugs.openjdk.java.net/browse/JDK-8067288 webrev: http://cr.openjdk.java.net/~amironov/8067288/ Please review the changes made in order to add const qualifier in serial and property APIs. Regards, Alexey From sergey.nazarkin at oracle.com Fri Dec 12 10:45:28 2014 From: sergey.nazarkin at oracle.com (Sergey Nazarkin) Date: Fri, 12 Dec 2014 13:45:28 +0300 Subject: RFR: JDK-8067288 - Add const qualifier in properties and serial In-Reply-To: <5489F33B.3090700@oracle.com> References: <5489F33B.3090700@oracle.com> Message-ID: <548AC748.8070605@oracle.com> Looks OK for me /Sergey On 11.12.2014 22:40, alexey mironov wrote: > issue: https://bugs.openjdk.java.net/browse/JDK-8067288 > webrev: http://cr.openjdk.java.net/~amironov/8067288/ > > Please review the changes made in order to add const qualifier in > serial and property APIs. > > Regards, > Alexey From sergey.nazarkin at oracle.com Fri Dec 12 10:48:08 2014 From: sergey.nazarkin at oracle.com (Sergey Nazarkin) Date: Fri, 12 Dec 2014 13:48:08 +0300 Subject: RFR: JDK-8067292 - Hangs when read in UARTEvent.INPUT_DATA_AVAILABLE callback in JavaME In-Reply-To: <5489F2B6.1060005@oracle.com> References: <5489F2B6.1060005@oracle.com> Message-ID: <548AC7E8.2090409@oracle.com> Looks OK for me /Sergey On 11.12.2014 22:38, alexey mironov wrote: > issue: https://bugs.openjdk.java.net/browse/JDK-8067292 > webrev: http://cr.openjdk.java.net/~amironov/8067292/ > > Please review the changes made in order to add code that fix problem > with hangs in JavaME. > > Regards, > Alexey From sergey.nazarkin at oracle.com Mon Dec 15 11:37:42 2014 From: sergey.nazarkin at oracle.com (sergey.nazarkin at oracle.com) Date: Mon, 15 Dec 2014 11:37:42 +0000 Subject: hg: dio/dev: 2 new changesets Message-ID: <201412151137.sBFBbgXj011843@aojmv0008> Changeset: 4f321d3dab0c Author: snazarki Date: 2014-12-15 15:34 +0400 URL: http://hg.openjdk.java.net/dio/dev/rev/4f321d3dab0c 8067292: Hangs when read in UARTEvent.INPUT_DATA_AVAILABLE callback in JavaME Summary: UART.read() checks if call is from event processing thread Reviewed-by: snazarki Contributed-by: alexey.mironov at oracle.com ! src/se/classes/com/oracle/dio/uart/impl/UARTEventHandler.java ! src/share/classes/com/oracle/dio/uart/impl/UARTImpl.java Changeset: 5528dd55f222 Author: snazarki Date: 2014-12-15 15:37 +0400 URL: http://hg.openjdk.java.net/dio/dev/rev/5528dd55f222 8067288: Add const qualifier in properties and serial Summary: Minor fixes Reviewed-by: snazarki Contributed-by: alexey.mironov at oracle.com ! src/se/native/com/oracle/dio/javacall_properties.c ! src/se/native/com/oracle/dio/javacall_properties.h From alexey.mironov at oracle.com Mon Dec 15 12:50:29 2014 From: alexey.mironov at oracle.com (alexey mironov) Date: Mon, 15 Dec 2014 15:50:29 +0300 Subject: RFR: JDK-8067434 - UART read wrong return value in JavaME Message-ID: <548ED915.3080307@oracle.com> Issue: https://bugs.openjdk.java.net/browse/JDK-8067434 webrev: http://cr.openjdk.java.net/~amironov/8067434/ Please review the changes made in order to change return value in JavaME. Regards, Alexey From sergey.nazarkin at oracle.com Mon Dec 15 13:48:20 2014 From: sergey.nazarkin at oracle.com (Sergey Nazarkin) Date: Mon, 15 Dec 2014 16:48:20 +0300 Subject: RFR: JDK-8067434 - UART read wrong return value in JavaME In-Reply-To: <548ED915.3080307@oracle.com> References: <548ED915.3080307@oracle.com> Message-ID: <548EE6A4.50506@oracle.com> Looks OK. /Sergey On 15.12.2014 15:50, alexey mironov wrote: > Issue: https://bugs.openjdk.java.net/browse/JDK-8067434 > webrev: http://cr.openjdk.java.net/~amironov/8067434/ > > Please review the changes made in order to change return value in JavaME. > > Regards, > Alexey From sergey.nazarkin at oracle.com Tue Dec 16 09:52:24 2014 From: sergey.nazarkin at oracle.com (sergey.nazarkin at oracle.com) Date: Tue, 16 Dec 2014 09:52:24 +0000 Subject: hg: dio/dev: 8067434: UART read wrong return value in JavaME Message-ID: <201412160952.sBG9qO4E012408@aojmv0008> Changeset: f87ca4482faf Author: snazarki Date: 2014-12-16 13:51 +0400 URL: http://hg.openjdk.java.net/dio/dev/rev/f87ca4482faf 8067434: UART read wrong return value in JavaME Summary: corrected value returned from read() called from event processing thread Reviewed-by: snazarki Contributed-by: alexey.mironov at oracle.com ! src/share/classes/com/oracle/dio/uart/impl/UARTImpl.java From alexey.mironov at oracle.com Tue Dec 16 13:23:25 2014 From: alexey.mironov at oracle.com (alexey mironov) Date: Tue, 16 Dec 2014 16:23:25 +0300 Subject: RFR: JDK-8067665 - [UART] cannot send big buffer if subscribed to UARTEvent.OUTPUT_BUFFER_EMPTY Message-ID: <5490324D.8070904@oracle.com> issue: https://bugs.openjdk.java.net/browse/JDK-8067665 webrev: http://cr.openjdk.java.net/~amironov/8067665/ Please review the changes made in order to fix problem with sending big buffer. Regards, Alexey From sergey.nazarkin at oracle.com Tue Dec 16 13:59:15 2014 From: sergey.nazarkin at oracle.com (Sergey Nazarkin) Date: Tue, 16 Dec 2014 16:59:15 +0300 Subject: RFR: JDK-8067665 - [UART] cannot send big buffer if subscribed to UARTEvent.OUTPUT_BUFFER_EMPTY In-Reply-To: <5490324D.8070904@oracle.com> References: <5490324D.8070904@oracle.com> Message-ID: <54903AB3.1080203@oracle.com> Looks OK /Sergey On 16.12.2014 16:23, alexey mironov wrote: > issue: https://bugs.openjdk.java.net/browse/JDK-8067665 > webrev: http://cr.openjdk.java.net/~amironov/8067665/ > > Please review the changes made in order to fix problem with sending > big buffer. > > Regards, > Alexey From alexey.mironov at oracle.com Tue Dec 16 14:49:42 2014 From: alexey.mironov at oracle.com (alexey mironov) Date: Tue, 16 Dec 2014 17:49:42 +0300 Subject: RFR: JDK-8067671 - DeviceManager.unregister(id) wouldn't throw an IAE for platform-registered id Message-ID: <54904686.1030807@oracle.com> issue: https://bugs.openjdk.java.net/browse/JDK-8067671 webrev: http://cr.openjdk.java.net/~amironov/8067671/ Please review the changes made in order to fix problem with throwing IAE when calling unregister method. Regards, Alexey From sergey.nazarkin at oracle.com Tue Dec 16 15:17:47 2014 From: sergey.nazarkin at oracle.com (Sergey Nazarkin) Date: Tue, 16 Dec 2014 18:17:47 +0300 Subject: RFR: JDK-8067671 - DeviceManager.unregister(id) wouldn't throw an IAE for platform-registered id In-Reply-To: <54904686.1030807@oracle.com> References: <54904686.1030807@oracle.com> Message-ID: <54904D1B.5000003@oracle.com> Looks OK /Sergey On 16.12.2014 17:49, alexey mironov wrote: > issue: https://bugs.openjdk.java.net/browse/JDK-8067671 > webrev: http://cr.openjdk.java.net/~amironov/8067671/ > > Please review the changes made in order to fix problem with throwing > IAE when calling unregister method. > > Regards, > Alexey From alexey.mironov at oracle.com Tue Dec 16 15:17:58 2014 From: alexey.mironov at oracle.com (alexey mironov) Date: Tue, 16 Dec 2014 18:17:58 +0300 Subject: RFR: JDK-8067672 - Fix I2C.read with skip and subaddress Message-ID: <54904D26.4030108@oracle.com> issue: https://bugs.openjdk.java.net/browse/JDK-8067672 webrev: http://cr.openjdk.java.net/~amironov/8067672/ Please review the changes made in order to fix i2c.read behavior. Regards, Alexey From sergey.nazarkin at oracle.com Tue Dec 16 15:18:45 2014 From: sergey.nazarkin at oracle.com (Sergey Nazarkin) Date: Tue, 16 Dec 2014 18:18:45 +0300 Subject: RFR: JDK-8067672 - Fix I2C.read with skip and subaddress In-Reply-To: <54904D26.4030108@oracle.com> References: <54904D26.4030108@oracle.com> Message-ID: <54904D55.3060101@oracle.com> Looks OK /Sergey On 16.12.2014 18:17, alexey mironov wrote: > issue: https://bugs.openjdk.java.net/browse/JDK-8067672 > webrev: http://cr.openjdk.java.net/~amironov/8067672/ > > Please review the changes made in order to fix i2c.read behavior. > > Regards, > Alexey From jen.dority at oracle.com Tue Dec 16 15:31:06 2014 From: jen.dority at oracle.com (Jen Dority) Date: Tue, 16 Dec 2014 10:31:06 -0500 Subject: Result: New Device I/O Committer: Alexey Mironov Message-ID: <5490503A.8040507@oracle.com> Voting for Alexey Mironov is now closed. Yes: 4 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. Jen Dority [1] http://mail.openjdk.java.net/pipermail/dio-dev/2014-November/000309.html From alexey.mironov at oracle.com Tue Dec 16 15:49:58 2014 From: alexey.mironov at oracle.com (alexey mironov) Date: Tue, 16 Dec 2014 18:49:58 +0300 Subject: RFR: JDK-8067674 - Possible dead code Message-ID: <549054A6.6030209@oracle.com> issue: https://bugs.openjdk.java.net/browse/JDK-8067674 webrev: http://cr.openjdk.java.net/~amironov/8067674/ Please review the changes made in order to delete dead code. Regards, Alexey From sergey.nazarkin at oracle.com Tue Dec 16 15:54:46 2014 From: sergey.nazarkin at oracle.com (Sergey Nazarkin) Date: Tue, 16 Dec 2014 18:54:46 +0300 Subject: RFR: JDK-8067674 - Possible dead code In-Reply-To: <549054A6.6030209@oracle.com> References: <549054A6.6030209@oracle.com> Message-ID: <549055C6.3030403@oracle.com> Looks OK /Sergey On 16.12.2014 18:49, alexey mironov wrote: > issue: https://bugs.openjdk.java.net/browse/JDK-8067674 > webrev: http://cr.openjdk.java.net/~amironov/8067674/ > > Please review the changes made in order to delete dead code. > > Regards, > Alexey From sergey.nazarkin at oracle.com Wed Dec 17 15:13:14 2014 From: sergey.nazarkin at oracle.com (sergey.nazarkin at oracle.com) Date: Wed, 17 Dec 2014 15:13:14 +0000 Subject: hg: dio/dev: 4 new changesets Message-ID: <201412171513.sBHFDEYP018097@aojmv0008> Changeset: 35a49b03d773 Author: snazarki Date: 2014-12-17 19:01 +0400 URL: http://hg.openjdk.java.net/dio/dev/rev/35a49b03d773 8067674: Possible dead code Summary: Removed unaccessible code from public classes Reviewed-by: snazarki Contributed-by: alexey.mironov at oracle.com ! src/se/classes/jdk/dio/mmio/MMIOEvent.java ! src/share/classes/jdk/dio/adc/MonitoringEvent.java ! src/share/classes/jdk/dio/counter/CountingEvent.java ! src/share/classes/jdk/dio/generic/GenericEvent.java ! src/share/classes/jdk/dio/gpio/PinEvent.java ! src/share/classes/jdk/dio/gpio/PortEvent.java ! src/share/classes/jdk/dio/modem/ModemSignalEvent.java ! src/share/classes/jdk/dio/pwm/GenerationEvent.java ! src/share/classes/jdk/dio/uart/UARTEvent.java Changeset: 2cc12574e8b4 Author: snazarki Date: 2014-12-17 19:03 +0400 URL: http://hg.openjdk.java.net/dio/dev/rev/2cc12574e8b4 8067672: Fix I2C.read with skip and subaddress Summary: Corrected function call Reviewed-by: snazarki Contributed-by: alexey.mironov at oracle.com ! src/share/classes/com/oracle/dio/i2cbus/impl/I2CSlaveImpl.java Changeset: 081bed253c1e Author: snazarki Date: 2014-12-17 19:06 +0400 URL: http://hg.openjdk.java.net/dio/dev/rev/081bed253c1e 8067671: DeviceManager.unregister(id) wouldn't throw an IAE for platform-registered id Summary: DeviceManager.unregister performs additional check Reviewed-by: snazarki Contributed-by: alexey.mironov at oracle.com ! src/se/classes/com/oracle/dio/registry/RegistryImpl.java ! src/share/classes/com/oracle/dio/registry/Registry.java ! src/share/classes/jdk/dio/DeviceManager.java Changeset: e937a3e81707 Author: snazarki Date: 2014-12-17 19:12 +0400 URL: http://hg.openjdk.java.net/dio/dev/rev/e937a3e81707 8067665: [UART] cannot send big buffer if subscribed to UARTEvent.OUTPUT_BUFFER_EMPTY Summary: Nonblocking write method was introduced Reviewed-by: snazarki Contributed-by: alexey.mironov at oracle.com ! src/se/native/com/oracle/dio/uart/impl/jni_uart.cpp ! src/share/classes/com/oracle/dio/uart/impl/UARTImpl.java ! src/share/linux/native/com/oracle/dio/uart/serial.c ! src/share/linux/native/com/oracle/dio/uart/uart.c ! src/share/native/com/oracle/dio/javacall_uart.h From sergey.nazarkin at oracle.com Wed Dec 17 15:30:35 2014 From: sergey.nazarkin at oracle.com (sergey.nazarkin at oracle.com) Date: Wed, 17 Dec 2014 15:30:35 +0000 Subject: hg: dio/dev: 8067795: Fix build failure introduced at e937a3e81707 changeset Message-ID: <201412171530.sBHFUZkG021143@aojmv0008> Changeset: 93bc1f742193 Author: snazarki Date: 2014-12-17 19:30 +0400 URL: http://hg.openjdk.java.net/dio/dev/rev/93bc1f742193 8067795: Fix build failure introduced at e937a3e81707 changeset Reviewed-by: alkonsta ! src/se/native/com/oracle/dio/uart/impl/jni_uart.cpp From alexey.mironov at oracle.com Wed Dec 17 18:14:03 2014 From: alexey.mironov at oracle.com (alexey mironov) Date: Wed, 17 Dec 2014 21:14:03 +0300 Subject: RFR: JDK-8067803 - NPE is not thrown when calling UART.startWriting(ByteBuffer, null) Message-ID: <5491C7EB.3010809@oracle.com> issue: https://bugs.openjdk.java.net/browse/JDK-8067803 webrev: http://cr.openjdk.java.net/~amironov/8067803/ Please review the changes made in order to add check for null. Regards, Alexey From alexey.mironov at oracle.com Wed Dec 17 18:30:58 2014 From: alexey.mironov at oracle.com (alexey mironov) Date: Wed, 17 Dec 2014 21:30:58 +0300 Subject: RFR: JDK-8067804 - NPE at RegistrationEventHandler.notifyRemoved/notifyRegistered Message-ID: <5491CBE2.1070405@oracle.com> issue: https://bugs.openjdk.java.net/browse/JDK-8067804 webrev: http://cr.openjdk.java.net/~amironov/8067804/ Please review the changes made in order to move check for null before event processing. Regards, Alexey From alexey.mironov at oracle.com Wed Dec 17 18:57:11 2014 From: alexey.mironov at oracle.com (alexey mironov) Date: Wed, 17 Dec 2014 21:57:11 +0300 Subject: RFR: JDK-8067807 - Instead of UnsupportedOperationException, DeviceNotFoundException is thrown when registering PWMChannel. Message-ID: <5491D207.9020002@oracle.com> issue: https://bugs.openjdk.java.net/browse/JDK-8067807 webrev: http://cr.openjdk.java.net/~amironov/8067807/ Please review the changes made in order to fix java me compatibility. Regards, Alexey From sergey.nazarkin at oracle.com Thu Dec 18 14:23:19 2014 From: sergey.nazarkin at oracle.com (Sergey Nazarkin) Date: Thu, 18 Dec 2014 17:23:19 +0300 Subject: RFR: JDK-8067807 - Instead of UnsupportedOperationException, DeviceNotFoundException is thrown when registering PWMChannel. In-Reply-To: <5491D207.9020002@oracle.com> References: <5491D207.9020002@oracle.com> Message-ID: <5492E357.1090006@oracle.com> OK /Sergey On 17.12.2014 21:57, alexey mironov wrote: > issue: https://bugs.openjdk.java.net/browse/JDK-8067807 > webrev: http://cr.openjdk.java.net/~amironov/8067807/ > > Please review the changes made in order to fix java me compatibility. > > Regards, > Alexey From sergey.nazarkin at oracle.com Thu Dec 18 14:23:58 2014 From: sergey.nazarkin at oracle.com (Sergey Nazarkin) Date: Thu, 18 Dec 2014 17:23:58 +0300 Subject: RFR: JDK-8067804 - NPE at RegistrationEventHandler.notifyRemoved/notifyRegistered In-Reply-To: <5491CBE2.1070405@oracle.com> References: <5491CBE2.1070405@oracle.com> Message-ID: <5492E37E.1010106@oracle.com> OK /Sergey On 17.12.2014 21:30, alexey mironov wrote: > issue: https://bugs.openjdk.java.net/browse/JDK-8067804 > webrev: http://cr.openjdk.java.net/~amironov/8067804/ > > Please review the changes made in order to move check for null before > event processing. > > Regards, > Alexey From sergey.nazarkin at oracle.com Thu Dec 18 14:24:40 2014 From: sergey.nazarkin at oracle.com (Sergey Nazarkin) Date: Thu, 18 Dec 2014 17:24:40 +0300 Subject: RFR: JDK-8067803 - NPE is not thrown when calling UART.startWriting(ByteBuffer, null) In-Reply-To: <5491C7EB.3010809@oracle.com> References: <5491C7EB.3010809@oracle.com> Message-ID: <5492E3A8.2060001@oracle.com> OK /Sergey On 17.12.2014 21:14, alexey mironov wrote: > issue: https://bugs.openjdk.java.net/browse/JDK-8067803 > webrev: http://cr.openjdk.java.net/~amironov/8067803/ > > Please review the changes made in order to add check for null. > > Regards, > Alexey From sergey.nazarkin at oracle.com Fri Dec 19 10:42:45 2014 From: sergey.nazarkin at oracle.com (sergey.nazarkin at oracle.com) Date: Fri, 19 Dec 2014 10:42:45 +0000 Subject: hg: dio/dev: 3 new changesets Message-ID: <201412191042.sBJAgjs1012268@aojmv0008> Changeset: b55a2b6b8163 Author: snazarki Date: 2014-12-19 14:27 +0400 URL: http://hg.openjdk.java.net/dio/dev/rev/b55a2b6b8163 8067803: NPE is not thrown when calling UART.startWriting(ByteBuffer, null) Summary: Checks for null Reviewed-by: snazarki Contributed-by: alexey.mironov at oracle.com ! src/share/classes/com/oracle/dio/uart/impl/UARTImpl.java Changeset: 591e95d602be Author: snazarki Date: 2014-12-19 14:30 +0400 URL: http://hg.openjdk.java.net/dio/dev/rev/591e95d602be 8067804: NPE at RegistrationEventHandler.notifyRemoved/notifyRegistered Summary: null check was added Reviewed-by: snazarki Contributed-by: alexey.mironov at oracle.com ! src/share/classes/com/oracle/dio/registry/RegistrationEventHandler.java Changeset: 9a36714478e0 Author: snazarki Date: 2014-12-19 14:38 +0400 URL: http://hg.openjdk.java.net/dio/dev/rev/9a36714478e0 8067807: Instead of UnsupportedOperationException, DeviceNotFoundException is thrown when registering PWMChannel. Summary: Added check for platfrom ability to make registration Reviewed-by: snazarki Contributed-by: alexey.mironov at oracle.com ! src/se/classes/com/oracle/dio/registry/RegistryImpl.java ! src/share/classes/com/oracle/dio/registry/Registry.java ! src/share/classes/jdk/dio/DeviceManager.java From alexey.mironov at oracle.com Mon Dec 22 13:54:13 2014 From: alexey.mironov at oracle.com (alexey mironov) Date: Mon, 22 Dec 2014 16:54:13 +0300 Subject: RFR: JDK-8068039 - Annotate upper stack native methods with field usages Message-ID: <54982285.7020308@oracle.com> issue: https://bugs.openjdk.java.net/browse/JDK-8068039 webrev: http://cr.openjdk.java.net/~amironov/8068039/ Please review the changes made in order to update annotation for java me compatibility. Regards, Alexey From sergey.nazarkin at oracle.com Mon Dec 22 15:33:47 2014 From: sergey.nazarkin at oracle.com (Sergey Nazarkin) Date: Mon, 22 Dec 2014 18:33:47 +0300 Subject: RFR: JDK-8068039 - Annotate upper stack native methods with field usages In-Reply-To: <54982285.7020308@oracle.com> References: <54982285.7020308@oracle.com> Message-ID: <549839DB.40206@oracle.com> Looks OK /Sergey On 22.12.2014 16:54, alexey mironov wrote: > issue: https://bugs.openjdk.java.net/browse/JDK-8068039 > webrev: http://cr.openjdk.java.net/~amironov/8068039/ > > Please review the changes made in order to update annotation for java > me compatibility. > > Regards, > Alexey From alexey.mironov at oracle.com Mon Dec 22 20:09:33 2014 From: alexey.mironov at oracle.com (alexey mironov) Date: Mon, 22 Dec 2014 23:09:33 +0300 Subject: RFR: JDK-8068059 - MMIO native file not updated Message-ID: <54987A7D.3030208@oracle.com> issue: https://bugs.openjdk.java.net/browse/JDK-8068059 webrev: http://cr.openjdk.java.net/~amironov/8068059/ Please review the changes made in order to update javacall_mmio.h. Regards, Alexey From sergey.nazarkin at oracle.com Tue Dec 23 09:54:05 2014 From: sergey.nazarkin at oracle.com (Sergey Nazarkin) Date: Tue, 23 Dec 2014 12:54:05 +0300 Subject: RFR: JDK-8068059 - MMIO native file not updated In-Reply-To: <54987A7D.3030208@oracle.com> References: <54987A7D.3030208@oracle.com> Message-ID: <54993BBD.20802@oracle.com> Looks OK /Sergey On 22.12.2014 23:09, alexey mironov wrote: > issue: https://bugs.openjdk.java.net/browse/JDK-8068059 > webrev: http://cr.openjdk.java.net/~amironov/8068059/ > > Please review the changes made in order to update javacall_mmio.h. > > Regards, > Alexey From sergey.nazarkin at oracle.com Tue Dec 23 11:46:42 2014 From: sergey.nazarkin at oracle.com (sergey.nazarkin at oracle.com) Date: Tue, 23 Dec 2014 11:46:42 +0000 Subject: hg: dio/dev: 2 new changesets Message-ID: <201412231146.sBNBkh5S020181@aojmv0008> Changeset: 0d0d2c265612 Author: snazarki Date: 2014-12-23 15:43 +0400 URL: http://hg.openjdk.java.net/dio/dev/rev/0d0d2c265612 8068039: Annotate upper stack native methods with field usages Summary: Changes are required for JavaME only Reviewed-by: snazarki Contributed-by: alexey.mironov at oracle.com + src/se/classes/impl/apimarker/API.java + src/se/classes/impl/romizer/Local.java + src/se/classes/impl/romizer/WeakDontRenameClass.java ! src/se/classes/jdk/dio/mmio/AccessOutOfBoundsException.java ! src/se/classes/jdk/dio/mmio/MMIODevice.java ! src/se/classes/jdk/dio/mmio/MMIODeviceConfig.java ! src/se/classes/jdk/dio/mmio/MMIOEvent.java ! src/se/classes/jdk/dio/mmio/MMIOEventListener.java ! src/se/classes/jdk/dio/mmio/MMIOPermission.java ! src/se/classes/jdk/dio/mmio/RawBlock.java ! src/se/classes/jdk/dio/mmio/RawMemory.java ! src/se/classes/jdk/dio/mmio/RawRegister.java ! src/share/classes/com/oracle/dio/gpio/impl/GPIOPinFactory.java ! src/share/classes/com/oracle/dio/gpio/impl/GPIOPinImpl.java ! src/share/classes/com/oracle/dio/gpio/impl/GPIOPortFactory.java ! src/share/classes/com/oracle/dio/gpio/impl/GPIOPortImpl.java ! src/share/classes/com/oracle/dio/i2cbus/impl/I2CDeviceFactory.java ! src/share/classes/com/oracle/dio/i2cbus/impl/I2CSlaveImpl.java ! src/share/classes/com/oracle/dio/spibus/impl/SPIDeviceFactory.java ! src/share/classes/com/oracle/dio/spibus/impl/SPISlaveImpl.java ! src/share/classes/com/oracle/dio/uart/impl/ModemUARTFactory.java ! src/share/classes/com/oracle/dio/uart/impl/ModemUARTImpl.java ! src/share/classes/com/oracle/dio/uart/impl/UARTFactory.java ! src/share/classes/com/oracle/dio/uart/impl/UARTImpl.java ! src/share/classes/jdk/dio/AsyncErrorHandler.java ! src/share/classes/jdk/dio/BufferAccess.java ! src/share/classes/jdk/dio/ClosedDeviceException.java ! src/share/classes/jdk/dio/Device.java ! src/share/classes/jdk/dio/DeviceAlreadyExistsException.java ! src/share/classes/jdk/dio/DeviceConfig.java ! src/share/classes/jdk/dio/DeviceDescriptor.java ! src/share/classes/jdk/dio/DeviceEvent.java ! src/share/classes/jdk/dio/DeviceEventListener.java ! src/share/classes/jdk/dio/DeviceException.java ! src/share/classes/jdk/dio/DeviceManager.java ! src/share/classes/jdk/dio/DeviceMgmtPermission.java ! src/share/classes/jdk/dio/DeviceNotFoundException.java ! src/share/classes/jdk/dio/DevicePermission.java ! src/share/classes/jdk/dio/InputRoundListener.java ! src/share/classes/jdk/dio/InvalidDeviceConfigException.java ! src/share/classes/jdk/dio/OutputRoundListener.java ! src/share/classes/jdk/dio/RegistrationEvent.java ! src/share/classes/jdk/dio/RegistrationListener.java ! src/share/classes/jdk/dio/RoundCompletionEvent.java ! src/share/classes/jdk/dio/Transactional.java ! src/share/classes/jdk/dio/UnavailableDeviceException.java ! src/share/classes/jdk/dio/UnsupportedAccessModeException.java ! src/share/classes/jdk/dio/UnsupportedDeviceTypeException.java ! src/share/classes/jdk/dio/adc/ADCChannel.java ! src/share/classes/jdk/dio/adc/ADCChannelConfig.java ! src/share/classes/jdk/dio/adc/ADCPermission.java ! src/share/classes/jdk/dio/adc/AcquisitionRoundListener.java ! src/share/classes/jdk/dio/adc/InvalidInputSamplingRateException.java ! src/share/classes/jdk/dio/adc/MonitoringEvent.java ! src/share/classes/jdk/dio/adc/MonitoringListener.java ! src/share/classes/jdk/dio/atcmd/ATDevice.java ! src/share/classes/jdk/dio/atcmd/ATDeviceConfig.java ! src/share/classes/jdk/dio/atcmd/ATModem.java ! src/share/classes/jdk/dio/atcmd/ATPermission.java ! src/share/classes/jdk/dio/atcmd/CommandResponseHandler.java ! src/share/classes/jdk/dio/atcmd/DataConnection.java ! src/share/classes/jdk/dio/atcmd/DataConnectionHandler.java ! src/share/classes/jdk/dio/atcmd/UnsolicitedResponseHandler.java ! src/share/classes/jdk/dio/counter/CounterPermission.java ! src/share/classes/jdk/dio/counter/CountingEvent.java ! src/share/classes/jdk/dio/counter/CountingListener.java ! src/share/classes/jdk/dio/counter/PulseCounter.java ! src/share/classes/jdk/dio/counter/PulseCounterConfig.java ! src/share/classes/jdk/dio/dac/DACChannel.java ! src/share/classes/jdk/dio/dac/DACChannelConfig.java ! src/share/classes/jdk/dio/dac/DACPermission.java ! src/share/classes/jdk/dio/dac/GenerationRoundListener.java ! src/share/classes/jdk/dio/dac/InvalidOutputSamplingRateException.java ! src/share/classes/jdk/dio/generic/GenericBufferIODevice.java ! src/share/classes/jdk/dio/generic/GenericDevice.java ! src/share/classes/jdk/dio/generic/GenericDeviceConfig.java ! src/share/classes/jdk/dio/generic/GenericDeviceControl.java ! src/share/classes/jdk/dio/generic/GenericEvent.java ! src/share/classes/jdk/dio/generic/GenericEventListener.java ! src/share/classes/jdk/dio/generic/GenericPermission.java ! src/share/classes/jdk/dio/gpio/GPIOPin.java ! src/share/classes/jdk/dio/gpio/GPIOPinConfig.java ! src/share/classes/jdk/dio/gpio/GPIOPinPermission.java ! src/share/classes/jdk/dio/gpio/GPIOPort.java ! src/share/classes/jdk/dio/gpio/GPIOPortConfig.java ! src/share/classes/jdk/dio/gpio/GPIOPortPermission.java ! src/share/classes/jdk/dio/gpio/PinEvent.java ! src/share/classes/jdk/dio/gpio/PinListener.java ! src/share/classes/jdk/dio/gpio/PortEvent.java ! src/share/classes/jdk/dio/gpio/PortListener.java ! src/share/classes/jdk/dio/i2cbus/I2CCombinedMessage.java ! src/share/classes/jdk/dio/i2cbus/I2CDevice.java ! src/share/classes/jdk/dio/i2cbus/I2CDeviceConfig.java ! src/share/classes/jdk/dio/i2cbus/I2CPermission.java ! src/share/classes/jdk/dio/modem/ModemSignalEvent.java ! src/share/classes/jdk/dio/modem/ModemSignalListener.java ! src/share/classes/jdk/dio/modem/ModemSignalsControl.java ! src/share/classes/jdk/dio/power/PowerManaged.java ! src/share/classes/jdk/dio/power/PowerSavingHandler.java ! src/share/classes/jdk/dio/pwm/GenerationEvent.java ! src/share/classes/jdk/dio/pwm/GenerationListener.java ! src/share/classes/jdk/dio/pwm/GenerationRoundListener.java ! src/share/classes/jdk/dio/pwm/InvalidPulseRateException.java ! src/share/classes/jdk/dio/pwm/PWMChannel.java ! src/share/classes/jdk/dio/pwm/PWMChannelConfig.java ! src/share/classes/jdk/dio/pwm/PWMPermission.java ! src/share/classes/jdk/dio/spi/AbstractDevice.java ! src/share/classes/jdk/dio/spi/DeviceProvider.java ! src/share/classes/jdk/dio/spibus/InvalidWordLengthException.java ! src/share/classes/jdk/dio/spibus/SPIDevice.java ! src/share/classes/jdk/dio/spibus/SPIDeviceConfig.java ! src/share/classes/jdk/dio/spibus/SPIPermission.java ! src/share/classes/jdk/dio/uart/ModemUART.java ! src/share/classes/jdk/dio/uart/UART.java ! src/share/classes/jdk/dio/uart/UARTConfig.java ! src/share/classes/jdk/dio/uart/UARTEvent.java ! src/share/classes/jdk/dio/uart/UARTEventListener.java ! src/share/classes/jdk/dio/uart/UARTPermission.java ! src/share/classes/jdk/dio/watchdog/WatchdogTimer.java ! src/share/classes/jdk/dio/watchdog/WatchdogTimerConfig.java ! src/share/classes/jdk/dio/watchdog/WatchdogTimerPermission.java ! src/share/classes/jdk/dio/watchdog/WindowedWatchdogTimer.java Changeset: 8109a64f0ee6 Author: snazarki Date: 2014-12-23 15:46 +0400 URL: http://hg.openjdk.java.net/dio/dev/rev/8109a64f0ee6 8068059: MMIO native file not updated Summary: Align MMIO interfaces with other DIO modules Reviewed-by: snazarki Contributed-by: alexey.mironov at oracle.com ! src/share/native/com/oracle/dio/javacall_mmio.h From alexey.mironov at oracle.com Tue Dec 23 13:47:57 2014 From: alexey.mironov at oracle.com (alexey mironov) Date: Tue, 23 Dec 2014 16:47:57 +0300 Subject: RFR: JDK-8068181 - Unexpected ServiceConfigurationError Message-ID: <5499728D.5000904@oracle.com> issue: https://bugs.openjdk.java.net/browse/JDK-8068181 webrev: http://cr.openjdk.java.net/~amironov/8068181 / Please review the changes made in order to fix problem with unexpected SRC. Regards, Alexey From sergey.nazarkin at oracle.com Tue Dec 23 13:54:26 2014 From: sergey.nazarkin at oracle.com (Sergey Nazarkin) Date: Tue, 23 Dec 2014 16:54:26 +0300 Subject: RFR: JDK-8068181 - Unexpected ServiceConfigurationError In-Reply-To: <5499728D.5000904@oracle.com> References: <5499728D.5000904@oracle.com> Message-ID: <54997412.9030404@oracle.com> Looks OK /Sergey On 23.12.2014 16:47, alexey mironov wrote: > issue: https://bugs.openjdk.java.net/browse/JDK-8068181 > webrev: http://cr.openjdk.java.net/~amironov/8068181 / > > Please review the changes made in order to fix problem with unexpected > SRC. > > Regards, > Alexey From alexey.mironov at oracle.com Wed Dec 24 11:18:25 2014 From: alexey.mironov at oracle.com (alexey.mironov at oracle.com) Date: Wed, 24 Dec 2014 11:18:25 +0000 Subject: hg: dio/dev: 8068181: Unexpected ServiceConfigurationError Message-ID: <201412241118.sBOBIQL3012390@aojmv0008> Changeset: 405b79ef234d Author: amironov Date: 2014-12-24 14:17 +0300 URL: http://hg.openjdk.java.net/dio/dev/rev/405b79ef234d 8068181: Unexpected ServiceConfigurationError Summary: Added try/catch Reviewed-by: snazarki Contributed-by: alexey.mironov at oracle.com ! src/share/classes/jdk/dio/DeviceManager.java From alexey.mironov at oracle.com Wed Dec 24 13:17:06 2014 From: alexey.mironov at oracle.com (alexey mironov) Date: Wed, 24 Dec 2014 16:17:06 +0300 Subject: RFR: JDK-8068243 - Expected IllegalArgumentException was not thrown Message-ID: <549ABCD2.2070200@oracle.com> issue: https://bugs.openjdk.java.net/browse/JDK-8068243 webrev: http://cr.openjdk.java.net/~amironov/8068243/ Please review the changes made in order to add IllegalArgumentException throwing in UARTEvent constructor. Regards, Alexey From sergey.nazarkin at oracle.com Wed Dec 24 13:20:51 2014 From: sergey.nazarkin at oracle.com (Sergey Nazarkin) Date: Wed, 24 Dec 2014 16:20:51 +0300 Subject: RFR: JDK-8068243 - Expected IllegalArgumentException was not thrown In-Reply-To: <549ABCD2.2070200@oracle.com> References: <549ABCD2.2070200@oracle.com> Message-ID: <549ABDB3.6010103@oracle.com> Looks OK /Sergey On 24.12.2014 16:17, alexey mironov wrote: > issue: https://bugs.openjdk.java.net/browse/JDK-8068243 > webrev: http://cr.openjdk.java.net/~amironov/8068243/ > > Please review the changes made in order to add > IllegalArgumentException throwing in UARTEvent constructor. > > Regards, > Alexey From alexey.mironov at oracle.com Thu Dec 25 13:37:04 2014 From: alexey.mironov at oracle.com (alexey.mironov at oracle.com) Date: Thu, 25 Dec 2014 13:37:04 +0000 Subject: hg: dio/dev: 8068243: Expected IllegalArgumentException was not thrown Message-ID: <201412251337.sBPDb4v5016506@aojmv0008> Changeset: f383add578f5 Author: amironov Date: 2014-12-25 16:16 +0300 URL: http://hg.openjdk.java.net/dio/dev/rev/f383add578f5 8068243: Expected IllegalArgumentException was not thrown Summary: Added throwing IAE and parameter check Reviewed-by: snazarki Contributed-by: alexey.mironov at oracle.com ! src/share/classes/jdk/dio/uart/UARTEvent.java From alexey.mironov at oracle.com Tue Dec 30 10:58:53 2014 From: alexey.mironov at oracle.com (alexey mironov) Date: Tue, 30 Dec 2014 13:58:53 +0300 Subject: RFR: JDK-8068381 - DAAPI_DEFAULT_ORDER is absent in javacall_dio.h Message-ID: <54A2856D.4070401@oracle.com> issue: https://bugs.openjdk.java.net/browse/JDK-8068381 webrev: http://cr.openjdk.java.net/~amironov/8068381/ Please review the changes made in order to add DAAPI_DEFAULT_ORDER to javacall_dio.h. Regards, Alexey From sergey.nazarkin at oracle.com Tue Dec 30 11:07:58 2014 From: sergey.nazarkin at oracle.com (Sergey Nazarkin) Date: Tue, 30 Dec 2014 14:07:58 +0300 Subject: RFR: JDK-8068381 - DAAPI_DEFAULT_ORDER is absent in javacall_dio.h In-Reply-To: <54A2856D.4070401@oracle.com> References: <54A2856D.4070401@oracle.com> Message-ID: <54A2878E.2090504@oracle.com> OK /Sergey On 30.12.2014 13:58, alexey mironov wrote: > issue: https://bugs.openjdk.java.net/browse/JDK-8068381 > webrev: http://cr.openjdk.java.net/~amironov/8068381/ > > Please review the changes made in order to add DAAPI_DEFAULT_ORDER to > javacall_dio.h. > > Regards, > Alexey From alexey.mironov at oracle.com Tue Dec 30 11:37:07 2014 From: alexey.mironov at oracle.com (alexey.mironov at oracle.com) Date: Tue, 30 Dec 2014 11:37:07 +0000 Subject: hg: dio/dev: 8068381: DAAPI_DEFAULT_ORDER is absent in javacall_dio.h Message-ID: <201412301137.sBUBb78R026307@aojmv0008> Changeset: b4a41ec5f5b2 Author: amironov Date: 2014-12-30 14:36 +0300 URL: http://hg.openjdk.java.net/dio/dev/rev/b4a41ec5f5b2 8068381: DAAPI_DEFAULT_ORDER is absent in javacall_dio.h Summary: Added DAAPI_DEFAULT_ORDER Reviewed-by: snazarki Contributed-by: alexey.mironov at oracle.com ! src/share/native/com/oracle/dio/javacall_dio.h