RFR: JDK-8066263 - Split UARTimpl and UARTModemImpl implementation in DIO realization

Jen Dority jen.dority at oracle.com
Thu Dec 4 13:08:02 UTC 2014


Why this change?

@@ -209,9 +203,6 @@
              }
              // first port in list is DEFAULT port
              String ports = Configuration.getProperty("microedition.commports");
-            if (ports == null) {
-                ports = Configuration.getProperty("jdk.dio.uart.ports");
-            }
              if (null != ports) {
                  StringTokenizer t = new StringTokenizer(ports, ",");
                  while(devNum-- > 0 && t.hasMoreTokens()) {

This had nothing to do with the issue. The microedition.* property isn't appropriate for SE. IMO, we should put this back and get get it officially sanctioned in the spec.

Jen


On 12/4/2014 5:49 AM, Sergey Nazarkin wrote:
> Looks OK
>
> /Sergey
>
> On 04.12.2014 13:14, alexey mironov wrote:
>> new webrev: http://cr.openjdk.java.net/~amironov/8066263.1/
>>
>> Previous webrev contain fix for 2 bugs. I prepare new webrev. Please 
>> review it.
>>
>> Regards,
>> Alexey
>>
>> On 01.12.2014 18:02, alexey mironov wrote:
>>> issue: https://bugs.openjdk.java.net/browse/JDK-8066263 
>>> <https://bugs.openjdk.java.net/browse/JDK-8065776>
>>> webrev: http://cr.openjdk.java.net/~amironov/8066263/ 
>>> <https://bugs.openjdk.java.net/browse/JDK-8065776>
>>>
>>> Please review the changes made in order to split UART and UARTModem 
>>> implementations.
>>>
>>> Regards,
>>> Alexey
>>
>



More information about the dio-dev mailing list