RFR: JDK-8048317 - GPIOLEDSample.java has the wrong package name

Riaz A Aimandi riaz.aimandi at oracle.com
Wed Jul 2 16:18:21 UTC 2014


Hi Jen,

OK. I suggest adding couple of lines of comment on top of the sample class before committing it.

Thanks

- riaz

On Jul 2, 2014, at 11:28 AM, Jen Dority <jen.dority at oracle.com> wrote:

> Hi Riaz,
> 
> I took another look at the sample package names. I decided to change it from com.oracle.dio.sample.gpio to dio.gpio. This is more in line with other samples/demos.
> 
> Here's the latest webrev: http://cr.openjdk.java.net/~jld/8048317b/
> 
> The only change is the package name and path changes to match. Once this is put back, I will update the device io wiki to reflect the new package name.
> 
> Thanks,
> Jen
> 
> On 7/1/2014 4:32 PM, Riaz A Aimandi wrote:
>> Hi Jen,
>> 
>> As there will be multiple samples, you may want to consider renaming the package directory
>> instead of updating the package name in the source.
>> 
>> Thanks,
>> 
>> - riaz
>> 
>> On Jul 1, 2014, at 12:50 PM, Jen Dority <jen.dority at oracle.com> wrote:
>> 
>>> issue: https://bugs.openjdk.java.net/browse/JDK-8048317
>>> webrev: http://cr.openjdk.java.net/~jld/8048317/
>>> 
>>> Need a trivial review for a package name correction -- "samples" --> "sample".
>>> 
>>> Thanks,
>>> Jen
>>> 
> 



More information about the dio-dev mailing list