RFR: GPIO JT Harness Tests - was Re: RFR: DIO JT Harness testsuite

[Jen Dority]

Hi Stas,

I'm splitting off the review for 8048010 so we can talk about it in its 
own thread. It wasn't clear from your email there were two separate 
reviews needed.

issue: *https://bugs.openjdk.java.net/browse/JDK-8048010*
webrev: http://cr.openjdk.java.net/~jld/8048010b/

GPIOPinConfigTest.java:
136 - 'open/closed' --> 'opened/closed'
204, 205 - 'Some' --> 'An'

GPIOPinDirectionsTest.java:
'during' --> 'while' (4 places)
206 - 'Direction was changed, but should not' --> 'Direction was changed 
unexpectedly.'
212 - 'Some' --> 'An'

GPIOPinNegativeTest.java:
125 - 'New pin was open/closed OK but it should not' --> 'Able to 
open/close invalid pin configuration.'

GPIOTestBase.java:
74 - 'Wrong input gpins argument' --> 'Mode PIN requires -gpins argument'
84 - 'Wrong input gports argument' --> 'Mode PORTS requires -gports 
argument'

Otherwise the changes look good to me. These are all string changes so I 
don't think we need to re-review the changes once they're done.

Jen

On 6/25/2014 11:55 AM, Stas Smirnov wrote:
> Hello,
>
> sending an updated RFR links
> http://cr.openjdk.java.net/~jld/8048010b/
> http://cr.openjdk.java.net/~jld/8047969b/
>
> I just appended a 'b' to the JIRA number so the old ones are still 
> available.
>
> I have updated the sources layout corresponding to what Bob Vandette 
> have suggested lately.
>
> Please note that for some strange reason raw display of the files is 
> unavailable however everything else works as expected, I mean patch 
> and other files.
>
> 24.06.2014 22:43, Stas Smirnov пишет:
>> Hello,
>>
>> I am sending an RFR <http://cr.openjdk.java.net/%7Ejld/8047969/> of 
>> my changes as a fix for JDK-8047969 
>> <https://bugs.openjdk.java.net/browse/JDK-8047969>.
>> My changeset include JT Harness testsuite placed in the device-io 
>> repository in the "tests" folder. There are no tests, just 
>> configuration files, JT Harness interview classes, utility classes 
>> and files, README_Tests file and ant build script.
>> In the README_Tests file I specified a wiki page 
>> https://wiki.openjdk.java.net/display/dio/Tests+Configuration+And+Execution 
>> it does not exist, but after this changset will be approved, such a 
>> wiki needs to be created to put their all information about testsiote 
>> configuration and tests execution.
>> lib/README is required to make lib folder visible for mercurial, in 
>> this folder developers will place required additional 3rd party 
>> libraries and dio.jar will be copied automatically by ant script.
>> -- 
>> Best regards,
>> Stas Smirnov
>> Stas Smirnov | Java Embedded
>> Phone: +7 812 3346130 | Mobile: +7 921 9262241
>> Oracle Development SPB, LLC
>> 10th Krasnoarmeyskaya 22A, St. Petersburg, 190103, Russia
>
>