RFR: DIO JT Harness testsuite

Jen Dority jen.dority at oracle.com
Thu Jun 26 13:59:05 UTC 2014


Hi Stas,

I've finished the rest, and it looks good.

None of these merit a re-review. I'll push the final changes when you 
have them  ready.

Jen

On 6/26/2014 4:20 AM, stanislav smirnov wrote:
> Hi Jen,
>
> thanks for your feedback, I will take a look on 'portPins' and make 
> necessary changes if required, please let me know if you find more
>
> On 26.06.2014 2:02, Jen Dority wrote:
>> Hi Stas,
>>
>> Still not finished reviewing these changes yet, but here's are some 
>> easy things I found.
>>
>> GPIOInterview.java:
>> 575 - Can we drop the null check and just return 'portPins'?
>>
>> i18n.properties:
>> 32 - 'testsuite' --> 'test suite'
>> 32,  - 'the JT Harness' --> 'JT Harness'
>> 45 - 'This is a hidden.' --> 'This is a hidden question.' or 'This 
>> question is hidden.'
>> 69 - 'the JT Harness' --> 'JT Harness'
>> 72 - 'currently testsuite' --> 'currently the testsuite' and 
>> 'testsuite' --> 'test suite'
>>
>> Jen
>>
>> On 6/25/2014 11:55 AM, Stas Smirnov wrote:
>>> Hello,
>>>
>>> sending an updated RFR links
>>> http://cr.openjdk.java.net/~jld/8048010b/
>>> http://cr.openjdk.java.net/~jld/8047969b/
>>>
>>> I just appended a 'b' to the JIRA number so the old ones are still 
>>> available.
>>>
>>> I have updated the sources layout corresponding to what Bob Vandette 
>>> have suggested lately.
>>>
>>> Please note that for some strange reason raw display of the files is 
>>> unavailable however everything else works as expected, I mean patch 
>>> and other files.
>>>
>>> 24.06.2014 22:43, Stas Smirnov пишет:
>>>> Hello,
>>>>
>>>> I am sending an RFR <http://cr.openjdk.java.net/%7Ejld/8047969/> of 
>>>> my changes as a fix for JDK-8047969 
>>>> <https://bugs.openjdk.java.net/browse/JDK-8047969>.
>>>> My changeset include JT Harness testsuite placed in the device-io 
>>>> repository in the "tests" folder. There are no tests, just 
>>>> configuration files, JT Harness interview classes, utility classes 
>>>> and files, README_Tests file and ant build script.
>>>> In the README_Tests file I specified a wiki page 
>>>> https://wiki.openjdk.java.net/display/dio/Tests+Configuration+And+Execution 
>>>> it does not exist, but after this changset will be approved, such a 
>>>> wiki needs to be created to put their all information about 
>>>> testsiote configuration and tests execution.
>>>> lib/README is required to make lib folder visible for mercurial, in 
>>>> this folder developers will place required additional 3rd party 
>>>> libraries and dio.jar will be copied automatically by ant script.
>>>> -- 
>>>> Best regards,
>>>> Stas Smirnov
>>>> Stas Smirnov | Java Embedded
>>>> Phone: +7 812 3346130 | Mobile: +7 921 9262241
>>>> Oracle Development SPB, LLC
>>>> 10th Krasnoarmeyskaya 22A, St. Petersburg, 190103, Russia
>>>
>>>
>>
>



More information about the dio-dev mailing list