RFR: JDK-8057012 - UART: ByteBuffer's position and limit can be affected by another thread while executing native read/write operations

Jen Dority jen.dority at oracle.com
Wed Sep 3 15:14:25 UTC 2014


Hi Alexey,

The code looks fine. I do have a few comments on the comments though. :)

UARTImpl.java:
264-269: I think this comment should end at "necessary." The redundant 
code example is redundant.
334: This comment is a duplicate of the line above it and can be removed.
337: "by the idea" --> "because", or "since", if you want to avoid 
having "because" appear twice in this comment block
338-342: Can you change "bytesWrote" to "bytesWritten?"
692: don't need "of" here
693: "while" --> "during"

Sorry for the delayed review. I don't think any of these changes should 
require a re-review.

Thanks,
Jen


On 9/1/2014 11:48 AM, alexey mironov wrote:
> issue: https://bugs.openjdk.java.net/browse/JDK-8057012
> webrev: http://cr.openjdk.java.net/~alkonsta/8057012/
>
> Hi All,
>
> Please review the changes made in order to fix issue with protection 
> ByteBuffer's position and limit from corruption.
>
> Regards,
> Alexey



More information about the dio-dev mailing list