From snazarkin at azul.com  Thu Dec  3 17:46:38 2015
From: snazarkin at azul.com (Sergey Nazarkin)
Date: Thu, 3 Dec 2015 17:46:38 +0000
Subject: [PATCH] java.nio.BufferUnderflowException at GPIOInputSample
	application
In-Reply-To: <23187DBC-E311-4447-B045-B319C3C33C62@azul.com>
References: <23187DBC-E311-4447-B045-B319C3C33C62@azul.com>
Message-ID: <899A8B9E-7A31-4C9D-A030-5F264FB98DA3@azul.com>

Hi, Olga!

Since you?re the only alive reviewer for the project, could you please review the patch?

Thank you.

Sergey Nazarkin
snazarkin at azul.com<mailto:snazarkin at azul.com>



On 11 Nov 2015, at 14:43, Sergey Nazarkin <snazarkin at azul.com<mailto:snazarkin at azul.com>> wrote:

Hi!

Please review changes to fix unhandled java.nio.BufferUnderflowException thrown at  GPIOInputSample application.

http://cr.openjdk.java.net/~snazarki/gpio-notify-BUFE/

/Sergey


From peter.saitz at savien.at  Thu Dec  3 20:11:58 2015
From: peter.saitz at savien.at (Peter Saitz)
Date: Thu, 03 Dec 2015 21:11:58 +0100
Subject: [PATCH] java.nio.BufferUnderflowException
	atGPIOInputSampleapplication
References: <23187DBC-E311-4447-B045-B319C3C33C62@azul.com>
	<899A8B9E-7A31-4C9D-A030-5F264FB98DA3@azul.com>
Message-ID: <5660A20E.8010709@savien.at>

Hi Sergey

I will make a re-test in the next few days.
You will get feedback...

With kind regards
Peter Saitz

_________________________

Peter Saitz
Software Developer

Savien Technologies GmbH.
Bierh?uselberggasse 31
A-1140 Vienna/Austria

mailto: peter.saitz at savien.at
phone: +43 699 19650224

Am 03.12.2015 um 18:46 schrieb Sergey Nazarkin:
> Hi, Olga!
>
> Since you?re the only alive reviewer for the project, could you please review the patch?
>
> Thank you.
>
> Sergey Nazarkin
> snazarkin at azul.com<mailto:snazarkin at azul.com>
>
>
>
> On 11 Nov 2015, at 14:43, Sergey Nazarkin <snazarkin at azul.com<mailto:snazarkin at azul.com>> wrote:
>
> Hi!
>
> Please review changes to fix unhandled java.nio.BufferUnderflowException thrown at  GPIOInputSample application.
>
> http://cr.openjdk.java.net/~snazarki/gpio-notify-BUFE/
>
> /Sergey
>


From olga.milovskaya at oracle.com  Tue Dec  8 10:38:18 2015
From: olga.milovskaya at oracle.com (olga nazarkina)
Date: Tue, 8 Dec 2015 13:38:18 +0300
Subject: JDK-8142489 Presence of ATPermission ... "...,data" or
	(GPIOPinPermission|GPIOPortPermission ... "...,setdirection" in
	java.security.policy results in IAE
Message-ID: <5666B31A.7030208@oracle.com>

issue: https://bugs.openjdk.java.net/browse/JDK-8142489
webrev: http://cr.openjdk.java.net/~onazarkina/8142489/

Fix IAE in Presence of ATPermission ... "...,data" or 
(GPIOPinPermission|GPIOPortPermission ... "...,setdirection" in 
java.security.policy

From snazarkin at azul.com  Tue Dec  8 14:42:56 2015
From: snazarkin at azul.com (Sergey Nazarkin)
Date: Tue, 8 Dec 2015 14:42:56 +0000
Subject: JDK-8142489 Presence of ATPermission ... "...,data" or
	(GPIOPinPermission|GPIOPortPermission ... "...,setdirection" in
	java.security.policy results in IAE
In-Reply-To: <5666B31A.7030208@oracle.com>
References: <5666B31A.7030208@oracle.com>
Message-ID: <640F82C9-F54D-4B0A-A49B-F0FC20BEF150@azul.com>

Looks OK of rme


Sergey Nazarkin




On 08 Dec 2015, at 13:38, olga nazarkina <olga.milovskaya at oracle.com<mailto:olga.milovskaya at oracle.com>> wrote:

issue: https://bugs.openjdk.java.net/browse/JDK-8142489
webrev: http://cr.openjdk.java.net/~onazarkina/8142489/

Fix IAE in Presence of ATPermission ... "...,data" or (GPIOPinPermission|GPIOPortPermission ... "...,setdirection" in java.security.policy


From sergey.nazarkin at oracle.com  Thu Dec 10 09:42:47 2015
From: sergey.nazarkin at oracle.com (sergey.nazarkin at oracle.com)
Date: Thu, 10 Dec 2015 09:42:47 +0000
Subject: hg: dio/dev: DIO-9: java.nio.BufferUnderflowException thrown at
	GPIOInputSample application
Message-ID: <201512100942.tBA9gmsC024724@aojmv0008.oracle.com>

Changeset: 4a3ade651fcc
Author:    snazarkin
Date:      2015-12-10 12:41 +0300
URL:       http://hg.openjdk.java.net/dio/dev/rev/4a3ade651fcc

DIO-9: java.nio.BufferUnderflowException thrown at GPIOInputSample application
Summary: javanotify_gpio_xxx_value_changed inserts integer value expected by EventQueueManager
Reviewed-by: onazarkina

! src/se/native/com/oracle/dio/gpio/impl/jni_gpio.cpp


From olga.milovskaya at oracle.com  Sun Dec 13 16:00:19 2015
From: olga.milovskaya at oracle.com (olga.milovskaya at oracle.com)
Date: Sun, 13 Dec 2015 16:00:19 +0000
Subject: hg: dio/dev: 8142489: Presence of ATPermission ... "...,
	data" or (GPIOPinPermission|GPIOPortPermission ... "...,
	setdirection" in java.security.policy results in IAE
Message-ID: <201512131600.tBDG0Jfm009991@aojmv0008.oracle.com>

Changeset: 958f53876e01
Author:    onazarkina
Date:      2015-12-13 18:44 +0300
URL:       http://hg.openjdk.java.net/dio/dev/rev/958f53876e01

8142489: Presence of ATPermission ... "...,data" or (GPIOPinPermission|GPIOPortPermission ... "...,setdirection" in java.security.policy results in IAE
Summary: Fix IAE in GPIOPinPermission|GPIOPortPermission
Reviewed-by: snazarki

! src/share/classes/jdk/dio/DevicePermission.java


From olga.milovskaya at oracle.com  Thu Dec 17 10:15:30 2015
From: olga.milovskaya at oracle.com (olga nazarkina)
Date: Thu, 17 Dec 2015 13:15:30 +0300
Subject: JDK-8145419: I2CCombinedMessage.transfer() would not trigger a stop
	condition if last recently added buffer's remaining() == 0
Message-ID: <56728B42.6090404@oracle.com>

issue: https://bugs.openjdk.java.net/browse/JDK-8145419
webrev: http://cr.openjdk.java.net/~onazarkina/8145419/

Last buffer such as buffer.remaining() != 0 is marked with respective 
attribute to trigger a stop condition. Besides, an unexpected IAE 
doesn't occur (JDK-8144994 
<https://bugs.openjdk.java.net/browse/JDK-8144994>?) anymore.

From olga.milovskaya at oracle.com  Mon Dec 28 12:07:39 2015
From: olga.milovskaya at oracle.com (olga.milovskaya at oracle.com)
Date: Mon, 28 Dec 2015 12:07:39 +0000
Subject: hg: dio/dev: 8145419: I2CCombinedMessage.transfer() would not trigger
	a stop condition if last recently added buffer's remaining() == 0
Message-ID: <201512281207.tBSC7dHp029802@aojmv0008.oracle.com>

Changeset: 9e33128d2ca4
Author:    onazarkina
Date:      2015-12-28 15:07 +0300
URL:       http://hg.openjdk.java.net/dio/dev/rev/9e33128d2ca4

8145419: I2CCombinedMessage.transfer() would not trigger a stop condition if last recently added buffer's remaining() == 0
Summary: last buffer such as buffer.remaining() != 0 is marked with respective attribute to trigger a stop condition. Besides, an unexpected IAE doesn't occur (JDK-8144994?) anymore.
Reviewed-by: snazarki

! src/share/classes/com/oracle/dio/i2cbus/impl/I2CCombinedMessage.java
! src/share/linux/native/com/oracle/dio/i2c/i2c.c
! src/share/linux/native/com/oracle/dio/spibus/spi.c