RFR: JDK-8073671 - Need ability to create osgi bundle for DIO

Sergey Nazarkin sergey.nazarkin at oracle.com
Wed Feb 25 09:26:45 UTC 2015


Looks OK

/Sergey

On 25.02.2015 0:41, Jen Dority wrote:
> updated webrev: http://cr.openjdk.java.net/~jld/8073671b/
>
> fixed version number - 1.01 --> 1.0.1
> separated OSGI_BUILD_DIR into a build and dist directory so 
> intermediate files would not appear in "dist" directory
>
> Sergey, ':=' variables can still be overridden on the make command 
> line -- just tested to make sure. But I think it's preferable that 
> ones we expect to be overridden often are declared with '?=' and 
> default values instead -- e.g. PI_TOOLS, STRIP_PACKAGES, BUILD_NUMBER, 
> etc. This also allows them to be set in the environment. This is why I 
> changed how TARGET_CPU_LEGACY_LIB was set -- so that it's clear that 
> it's a variable that might be set from outside and consistent with 
> existing declarations. It's not related to the main purpose of this 
> issue though, so if you want, I can revert this part of the change.
>
> Jen
>
> On 2/24/2015 4:21 AM, Sergey Nazarkin wrote:
>> Hi Jen,
>>
>> I'd not use of ":=" in path assignment since it prevents variable 
>> modification from script caller like build server where it may be 
>> useful to store build artifact in different folder.
>>
>> /Sergey
>>
>> On 23.02.2015 22:08, Jen Dority wrote:
>>> issue: https://bugs.openjdk.java.net/browse/JDK-8073671
>>> webrev: http://cr.openjdk.java.net/~jld/8073671/
>>>
>>> Hi All,
>>>
>>> Need a review for some makefile changes to build an osgi bundle for 
>>> Device I/O.
>>>
>>> Thanks,
>>> Jen
>>>
>>>
>>
>



More information about the dio-dev mailing list