RFR: DIO-17 UART.generateBreak() is not implemented correctly

Sergey Nazarkin snazarkin at azul.com
Wed Mar 9 12:23:09 UTC 2016


LGTM


Sergey Nazarkin




> On 09 Mar 2016, at 15:09, boris kvartskhava <boris.kvartskhava at oracle.com> wrote:
> 
> issue: https://bugs.openjdk.java.net/browse/DIO-17
> webrev: http://cr.openjdk.java.net/~onazarkina/DIO-17/
> 
> This change resolves an issue with invalid DIO implementation
>   of UART.generateBreak(...) method.
>  The result of the call to ioctl(..., TCSBRKP, positive) is undefined.
>   Instead, an approach with the sequency is taken:
>   ioctl(..., TIOCSBRK, 0);
>   followed by usleep() followed by
>   ioctl(..., TIOCCBRK, 0);
> 
> 



More information about the dio-dev mailing list