RFR: [dio-25] Support 64 bits platforms
Sergey Nazarkin
snazarkin at azul.com
Tue Sep 26 16:26:25 UTC 2017
Sounds reasonable, thanks for review.
Sergey Nazarkin
> On 25 Sep 2017, at 04:54, Alexander Mironenko <alexander.mironenko at oracle.com> wrote:
>
> Hi,
> Minor, I would change Handle.hashCode() to
> public int hashCode() {
>
> return ((int)device_reference) ^ ((int)(device_reference >>> Integer.SIZE)) ;
>
> }
>
> Other places look good to me.
> Regards,
> Alex
>
>> On Sep 15, 2017, at 9:24 AM, Sergey Nazarkin <snazarkin at azul.com> wrote:
>>
>> Hi!
>>
>> please review modification [1] that adds 64 bits systems support. This update breaks compatibility with JavaME binaries if any exists, though API is unchanged so no application should be affected.
>>
>> I perform only rough tests with GPIO and UART, and would appreciate if someone test SPI and I2C.
>>
>>
>> [1] http://cr.openjdk.java.net/~snazarki/dio-25/
>> [2] https://bugs.openjdk.java.net/browse/DIO-25
>>
>> Sergey Nazarkin
>>
>>
>>
>>
>
More information about the dio-dev
mailing list