Format for JDK 6/7 changeset comments?

[Brad Wetmore]

 > How many status can a changeset have? "new", "pending" and
 > "submitted"? Will there be a state for review?

I haven't seen any response to your questions yet, so let me take a 
quick stab at the current architecture of our bug database.

(Each group handles their bug states a little differently, so what I may 
describe may be met with guffaws from other groups.  There is a "How-To" 
document under development that will layout more specifics, so this is a 
quick overview that may change with time.)

Please see Kelly's "Mercurial Wheel" blog entry if you haven't already:

     http://blogs.sun.com/kto/entry/openjdk_mercurial_wheel

Be sure to note the part about being nice to your integrator...  ;)

Dispatched
     No one's looked at it.
Incomplete
     Someone's looked at it, need more info, there's missing info, etc.
Accepted
     Someone's looked at it, agrees it should be tracked.  Cause not
     known yet.
Defer
     Can't do anything about it now.
Cause known
     Understand the problem, but not the fix.
Fix Understood
     Understand problem, have a good idea for solution.
Fix In Progress
     Actively working on fix.
Fix Available
     Fix is ready and has been delivered, but is not in MASTER yet.
Fix Failed
     Rats!  Back to drawing board.
Fix Delivered
     Fix is in the MASTER.
Closed
     Fix in the MASTER has been verified.

So, to your questions.  You can probably now map each bug state to the 
stage you're working on.  When you start coding, you're in Fix in 
Progress (FIP).  When you've submitted code for review, you're still 
FIP.  Once you're approved, create your changeset, and putback to your 
gate.  At that point, you mark the bug as "Fix Available".

Kelly wrote:

 > Mercurial changesets should not be created until the change has been
 > reviewed and is ready to be integrated into a public area.
 > Changes that are untested, unreviewed, or experimental should stay as
 > patches, at least that's my opinion after using Mercurial for some
 > time.

+1

At some interval, your friendly neighborhood gatekeeper (possibly me) 
will loving collect your changes along with the others received to date, 
build and run the available tests, then gently place your changes into 
the MASTER workspace and move the bug into the "Fix Delivered" state.

Most gatekeepers will accept changes as long as they are accompanied by 
good quality chocolate.  Watch out for gatekeepers that have 
more...ummm...refined tastes (fine wine, ports).  I'd stay away from 
Duke, he'll make you attend JavaOne.

Feel free to ignore the entire previous paragraph.  I do like chocolate 
tho...  ;-)  Anyone Europeans out there?

Neo wrote:

> For example, in that
> state, the committer cannot make changes any more. And he/she has to
> use another changeset to re-work his/her changes.

Once your fix is delivered (goes into Fix available state), you will 
probably need to do another change set as anyone can now download it.

> How many files could we edit by a changeset? No restrictions or something else?

I don't know of any restrictions on numbers.  If you're thinking of 
changing thousands of files, we will want to know about it.  ;)

Brad
Java Security/Network Integrator