Format for JDK 6/7 changeset comments?

[Andreas Sterbenz]

Mark Reinhold wrote:
>> Date: Thu, 08 Nov 2007 10:36:01 -0800
>> From: andreas.sterbenz at sun.com
> 
>> Mark Reinhold wrote:
>>> I disagree with you about where reviewers should be acknowledged.
>>>
>>> Reviewing code is tantamount to authorship.  From one of our internal
>>> guideline documents (which is already in the process of being cleaned
>>> up for external use):
>> That's fine. And the names of the reviewers should be stored in the bug
>> database, along with all the other information about the fix. Do you agree
>> with that?
> 
> No.  Authorship information should go with the code.

Exactly because that information is important it should be stored in the 
bug database, where all other information about the bug is stored [*], the 
location of which is well known to everyone and not just the developers 
working on the JDK, which can be queried using a web interface, etc.

Capturing everything in the bug database except code reviewers does not 
seem like a good idea to me.

It is probably a bit more difficult to ensure that the correct information 
is in the bug database than to validate the changeset comments, but it 
should be possible for the hooks to query it and verify that the relevant 
information is present (e.g. must have a comment that includes the text 
"Reviewed-by: X").

Andreas.

[*] except the actual code changes