Format for JDK 6/7 changeset comments?

Andrew Haley aph at redhat.com
Tue Nov 13 11:26:51 UTC 2007


Iris Garcia writes:
 > 
 > > The goal here isn't to give credit to every last person who
 > > helped with the change, but rather to acknowledge non-committers
 > > who contribute whole changes.  I'd rather see just a simple
 > > acknowledgment listing the contributor's e-mail address, e.g.,
 > > 
 > >     Contributed-by: Random Hacker <hack at gnu.org>
 > > 
 > > We can change "Review:" to "Reviewed-by:" as well, to stress the
 > > analogy with RFC-822 and the fact that changeset comments aren't
 > > intended to be arbitrary text.
 > 
 > How can we be sure that Random Hacker doesn't have a problem with
 > us releasing his e-mail address?
 > 
 > If somebody is commiting a change, then they've already agreed to
 > the SCA.  I'm not sure if signing the SCA means that we can use
 > their e-mail address, but I think we can assume that by choosing to
 > contribute to an open project, certain information is public.

Anyone who contributes any code to a free software project must make
their email address available so that they can be contacted by anyone
reviewing their proposed change.  The set of reviewers is not limited
to those with the power to accept a change, but includes anyone who is
capable of reading one.

Andrew.

-- 
Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, UK
Registered in England and Wales No. 3798903



More information about the discuss mailing list