Publishing code reviews

Mark Reinhold mr at
Thu Oct 11 22:54:25 UTC 2007

> Date: Thu, 11 Oct 2007 12:02:59 -0700
> From: dmitri.trembovetski at

> ...
>    It would take some effort to migrate the system to another
>    machine (Igor Kushnirsky would know how much effort that
>    would take).

That would be good to know.  Would Igor (or someone) have the time to do
this migration anytime soon?

>    But the robot - especially it's built-in archive
>    feature (all review-related conversations are archived,
>    along with webrevs) - proved invaluable.

I can believe that -- but do you want to force it on the entire team?

>    What about the JDK developers who would not like the OpenSolaris
>    service? I would wager that they will be the majority =)

That could be, but my sense is that there's a significant minority that
doesn't like the robot.

>> If we do create an OpenSolaris-style code-review server then we should
>> certainly arrange for the robot to publish webrevs there.  That can't be
>> hard.
>    Yes, that would be good in any case.

The OpenSolaris-style code-review service is essentially a strict subset
of the robot service.  Until the robot is migrated to an external server
(and likely even after that) we can easily arrange for it to publish
webrevs on the code-review server.

The robot only sends e-mail messages to specific reviewers, not to
mailing lists.  That's fine internally, but we should likely also have
the robot cc: e-mails to the appropriate public lists so that anyone can
read the review traffic.  These need not be the foo-dev lists; we could
set up a parallel set of, say, foo-review lists.

Does that make sense?

>    Would we need to somehow filter out the webrevs which
>    contain closed sources?

Yes.  That's a Sun-internal problem, though, so let's discuss it

- Mark

More information about the discuss mailing list