Publishing code reviews

Peter B. Kessler Peter.Kessler at Sun.COM
Thu Oct 11 23:26:16 UTC 2007


Tim O'Brien wrote:

> 
> 
> On 10/11/07, *Mark Reinhold* <mr at sun.com <mailto:mr at sun.com>> wrote:
> 
>      >    Would we need to somehow filter out the webrevs which
>      >    contain closed sources?
> 
>     Yes.  That's a Sun-internal problem, though, so let's discuss it
>     internally.
> 
> 
> 
> That's interesting, what sort of code is closed?   Is there ever going 
> to be a case where a webrev contains certain sections that are public 
> and certain sections that are private?   since you mentioned it on a 
> public list, could you give us a sense of what the public is missing?

Think of the code we can't release because of the encumberances.
If we have to make changes in that code, we need to get reviews,
but we can't ask the community for help with those reviews.

Clearly the less code we have that we can't put in the open the
better.  But as long as that set is non-empty, it's something we
have to deal with, internally.

			... peter



More information about the discuss mailing list