URL to review in commit msg?

[joe darcy]

Hi Roman,

FWIW, I agree with you that it would be helpful to have a link to the 
code review discussion in the bug history. Towards that end, I put a 
link to the review thread in the comments on my bugs in JBS; e.g.:

https://bugs.openjdk.java.net/browse/JDK-8183175?focusedCommentId=14097068&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14097068
https://bugs.openjdk.java.net/browse/JDK-8183173?focusedCommentId=14097055&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14097055

A few other engineers follow this practice as well, but it is far from 
universal.

HTH,

-Joe


On 7/25/2017 3:06 AM, Roman Kennke wrote:
> Hello,
>
> I found myself more than once in a situation where I looked up the
> changeset that introduced a particular section of code using hg
> annotate, and would have liked to read up on the discussion around it.
> But there's no link to reviews anywhere, not in the commit msg, and not
> in the bug entry either. At least, as far as I can tell. (please,
> correct me if I'm wrong!)
>
> It doesn't seem difficult to simply add the URL to the review thread
> into the commit msg (or alternatively, to the bug entry).
>
> Would that be something others would find useful too?
>
> Alternatively (and I think this is being worked on since, dunno, some
> years now), we could use an online review system that integrates with
> Jira (I suspect Crucible would be the obvious candidate here?), and
> which would record and link everything together. But until that happens...?
>
> Cheers, Roman
>