Feedback after first Contribution

[Michael Bien]

Hello,

earlier this week I made my first contribution and wanted to leave some 
feedback from the POV of an external contributor.

First let me explain what I did to get it integrated:

Since the bugfix itself was trivial, I created a pull request right away 
(I signed the OCA before that) before discussing anything on a dev list, 
since I wanted to use the code as basis for the discussion.

The bot (which is pretty cool) quickly pointed out that the PR didn't 
have an issue assigned to it. I figured the only way to get an issue for 
me would be to either ask on the mailing list or to paste the paragraphs 
of the PR into the small boxes of the bug report system, while linking 
back to the PR to make it clear that a fix exists.

A week later i could prefix the PR with the issue ID which made the bot 
happy. At this point the first automated mail landed on the (correct) 
dev list which triggered the actual reviewing process - pretty cool.

suggestions:

1) I feel there should be a faster path from a PR to a JBS issue. Maybe 
there could be a command which would let the bot generate a draft issue? 
Pasting the paragraphs into the customer bug form really felt like i was 
wasting someone's time knowing that the bug reviewer will probably try 
to reproduce the bug.

2) The guide should mention somewhere that the commits will get squashed 
in the end to a single commit using the issue as title. So that the 
contributor can just keep adding commits during the review process 
without having to bother with git push -f or a clean history.

3) The bot really didn't want to add me as a contributor :) There might 
be a bug somewhere:
https://github.com/openjdk/jdk/pull/248#issuecomment-713021764

best regards,

michael

. . .

https://mbien.dev