<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class="elementToProof">
Link to Netty Issue:</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class="elementToProof ContentPasted0">
1: <a href="https://github.com/netty/netty/pull/13099" id="LPlnkOWALinkPreview">https://github.com/netty/netty/pull/13099</a></div>
<div class="_Entity _EType_OWALinkPreview _EId_OWALinkPreview _EReadonly_1">
<div id="LPBorder_GTaHR0cHM6Ly9naXRodWIuY29tL25ldHR5L25ldHR5L3B1bGwvMTMwOTk." class="LPBorder713663" style="width: 100%; margin-top: 16px; margin-bottom: 16px; position: relative; max-width: 800px; min-width: 424px;">
<table id="LPContainer713663" role="presentation" style="padding: 12px 36px 12px 12px; width: 100%; border-width: 1px; border-style: solid; border-color: rgb(200, 200, 200); border-radius: 2px;">
<tbody>
<tr valign="top" style="border-spacing: 0px;">
<td>
<div id="LPImageContainer713663" style="position: relative; margin-right: 12px; height: 120px; overflow: hidden; width: 240px;">
<a target="_blank" id="LPImageAnchor713663" href="https://github.com/netty/netty/pull/13099"><img id="LPThumbnailImageId713663" alt="" height="120" style="display: block;" width="240" src="https://opengraph.githubassets.com/9dc9b173c70e1dfd7d5f80cb9ba16afedfd0579b06733a4eaf0ec8a562ce699e/netty/netty/pull/13099"></a></div>
</td>
<td style="width: 100%;">
<div id="LPTitle713663" style="font-size: 21px; font-weight: 300; margin-right: 8px; font-family: wf_segoe-ui_light, "Segoe UI Light", "Segoe WP Light", "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; margin-bottom: 12px;">
<a target="_blank" id="LPUrlAnchor713663" href="https://github.com/netty/netty/pull/13099" style="text-decoration: none; color: var(--themePrimary);">Add `StacklessSSLHandshakeException` for `ClosedChannelException` by hyperxpro Β· Pull Request #13099 Β· netty/netty</a></div>
<div id="LPDescription713663" style="font-size: 14px; max-height: 100px; color: rgb(102, 102, 102); font-family: wf_segoe-ui_normal, "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; margin-bottom: 12px; margin-right: 8px; overflow: hidden;">
Motivation: When a channel is closed during the SSL handshake then java.nio.channels.ClosedChannelException is thrown. This is correct when we see it from a low-level transport perspective but from...</div>
<div id="LPMetadata713663" style="font-size: 14px; font-weight: 400; color: rgb(166, 166, 166); font-family: wf_segoe-ui_normal, "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif;">
github.com</div>
</td>
</tr>
</tbody>
</table>
</div>
</div>
<br>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> discuss <discuss-retn@openjdk.org> on behalf of Aayush Atharva <aayush@ShieldBlaze.com><br>
<b>Sent:</b> Tuesday, January 24, 2023 11:44 AM<br>
<b>To:</b> discuss@openjdk.org <discuss@openjdk.org><br>
<b>Subject:</b> Add more constructors in ClosedChannelException</font>
<div> </div>
</div>
<style type="text/css" style="display:none">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div class="x_elementToProof x_ContentPasted0 x_ContentPasted1" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0); background-color:rgb(255,255,255)">
Hello JDK Community! <span id="x_π">π</span></div>
<div class="x_elementToProof x_ContentPasted0 x_ContentPasted1" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0); background-color:rgb(255,255,255)">
<br>
</div>
<div class="x_elementToProof x_ContentPasted0 x_ContentPasted1" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0); background-color:rgb(255,255,255)">
The current ClosedChannelException does not have any constructors to pass a message. We have to rely on 'initCause(...)'β for passing extra messages regarding a ClosedChannelException but it's not a very good practice in my opinion. Because we will have to
generate another Exception which will create another brand-new object in the heap and generates a stack trace. And all of this just to pass a simple message for ClosedChannelException.</div>
<div class="x_elementToProof x_ContentPasted0 x_ContentPasted1" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0); background-color:rgb(255,255,255)">
<br>
</div>
<div class="x_elementToProof x_ContentPasted0 x_ContentPasted1" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0); background-color:rgb(255,255,255)">
<span class="x_ContentPasted4" style="font-size:12pt; margin:0px; background-color:rgb(255,255,255)">When we log ClosedChannelException, we get something like this in our loggers:</span></div>
<div class="x_elementToProof x_ContentPasted0 x_ContentPasted1" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0); background-color:rgb(255,255,255)">
<div class="x_ContentPasted4" style="font-size:12pt; margin:0px; background-color:rgb(255,255,255)">
```</div>
<div class="x_ContentPasted4 x_elementToProof" style="font-size:12pt; margin:0px; background-color:rgb(255,255,255)">
java.nio.channels.ClosedChannelException: null<br class="x_ContentPasted4">
</div>
<div class="x_ContentPasted4 x_elementToProof" style="font-size:12pt; margin:0px; background-color:rgb(255,255,255)">
<span>ββββββat foo.bar(Meow.java:9999)</span></div>
<div class="x_ContentPasted4" style="font-size:12pt; margin:0px; background-color:rgb(255,255,255)">
```</div>
<div class="x_ContentPasted4" style="font-size:12pt; margin:0px; background-color:rgb(255,255,255)">
<br>
</div>
</div>
<div class="x_elementToProof x_ContentPasted0 x_ContentPasted1" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0); background-color:rgb(255,255,255)">
Honestly, it's not helpful at all. Netty[1] suffers from this same problem but we have added a new suppressed Stackless exception in <span class="x_ContentPasted3" style="background-color:rgb(255,255,255); display:inline!important">ClosedChannelException which
will help us give more context to users about the exception but this is really a workaround.</span></div>
<div class="x_elementToProof x_ContentPasted0 x_ContentPasted1" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0); background-color:rgb(255,255,255)">
<span class="x_ContentPasted3" style="background-color:rgb(255,255,255); display:inline!important"><br class="x_ContentPasted5">
<span class="x_ContentPasted5" style="background-color:rgb(255,255,255); display:inline!important">In my opinion, we can add extra constructors in ClosedChannelException which will accept messages and we can have a good exception at the end.</span><br>
</span></div>
<div class="x_elementToProof x_ContentPasted0 x_ContentPasted1" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0); background-color:rgb(255,255,255)">
<span class="x_ContentPasted3" style="background-color:rgb(255,255,255); display:inline!important"><br>
</span></div>
<div class="x_elementToProof x_ContentPasted0 x_ContentPasted1" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0); background-color:rgb(255,255,255)">
I'd like to have everyone's opinion on this and see how we can tackle this.<br>
<br>
Thanks!</div>
</div>
</body>
</html>