Fix debuginfo generation for Linux

[Andrew Haley]

In Linux packages we always generate full debuginfo, regardless of
optimization.  Recent changes to OpenJDK have broken our debuginfo
patches, and this new version of icedtea-debuginfo.patch fixes that, I
hope.

We need to find some way to test debuginfo generation in our
regression testing.  At the moment I can think of no easy way to do
that: it's a hard problem because even if we detect that one file has
correct debuginfo, that doesn't mean that _all_ files do.  Ideas
welcome...

Andrew.


2007-10-05  Andrew Haley  <aph at redhat.com>

        * patches/icedtea-debuginfo.patch: Add
        openjdk/hotspot/build/linux/makefiles/gcc.make.
        Add -g to CFLAGS_REQUIRED in
        openjdk/j2se/make/common/Defs-linux.gmk

--- openjdk/j2se/make/common/Defs-linux.gmk.orig	2007-09-27 08:52:06.000000000 +0100
+++ openjdk/j2se/make/common/Defs-linux.gmk	2007-10-04 15:04:02.000000000 +0100
@@ -155,13 +155,11 @@
    CFLAGS_COMMON   += $(GLOBAL_KPIC) $(GCC_WARNINGS)
 endif
 
-# Linux 64bit machines use Dwarf2, which can be HUGE, have fastdebug use -g1
 DEBUG_FLAG = -g
-ifeq ($(FASTDEBUG), true)
-  ifeq ($(ARCH_DATA_MODEL), 64)
-    DEBUG_FLAG = -g1
-  endif
-endif
+
+# Always generate full debuginfo on Linux.  It'll be in a separate
+# debuginfo package when building RPMs.
+CFLAGS_REQUIRED += -g
 
 CFLAGS_OPT      = $(POPT)
 CFLAGS_DBG      = $(DEBUG_FLAG)
@@ -236,7 +234,7 @@
 ifeq ($(VARIANT), OPT)
   ifneq ($(NO_STRIP), true)
     # Debug 'strip -g' leaves local function Elf symbols (better stack traces)
-    POST_STRIP_PROCESS = $(STRIP) -g
+    # POST_STRIP_PROCESS = $(STRIP) -g
   endif
 endif
 
--- openjdk/j2se/make/sun/awt/mawt.gmk~	2007-05-24 08:33:23.000000000 +0100
+++ openjdk/j2se/make/sun/awt/mawt.gmk	2007-06-21 15:25:58.000000000 +0100
@@ -132,7 +132,7 @@
 #
 
 
-#CFLAGS += -g
+CFLAGS += -g
 ifeq ($(HEADLESS),true)
 CFLAGS += -DHEADLESS=$(HEADLESS)
 CPPFLAGS += -DHEADLESS=$(HEADLESS)
--- openjdk/j2se/make/common/shared/Defs-java.gmk	2007-09-13 03:52:42.000000000 -0400
+++ openjdk/j2se/make/common/shared/Defs-java.gmk	2007-09-14 10:50:45.000000000 -0400
@@ -98,15 +98,9 @@
 #  -- Use JAVAC_CMD if you want to take the defaults given to you.
 #
 
-ifndef DEBUG_CLASSFILES
-  ifeq ($(VARIANT), DBG)
-    DEBUG_CLASSFILES = true
-  endif
-endif
-JAVACFLAGS =
-ifeq ($(DEBUG_CLASSFILES),true)
-  JAVACFLAGS += -g
-endif
+DEBUG_CLASSFILES = true
+JAVACFLAGS += -g
+
 ifeq ($(COMPILER_WARNINGS_FATAL), true)
   JAVACFLAGS  += -Werror
 endif
--- openjdk/hotspot/build/linux/makefiles/gcc.make~	2007-10-03 17:54:11.000000000 +0100
+++ openjdk/hotspot/build/linux/makefiles/gcc.make	2007-10-03 18:19:33.000000000 +0100
@@ -63,6 +63,10 @@
 CFLAGS += -D_REENTRANT
 CFLAGS += -fcheck-new
 
+# Always generate full debuginfo on Linux.  It'll be in a separate
+# debuginfo package when building RPMs.
+CFLAGS += -g
+
 ARCHFLAG = $(ARCHFLAG/$(BUILDARCH))
 ARCHFLAG/i486    = -m32 -march=i586
 ARCHFLAG/amd64   = -m64

-- 
Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, UK
Registered in England and Wales No. 3798903