Shark: fix some minor typos (and thinkos)

Andrew Haley aph at redhat.com
Wed Aug 20 02:43:36 PDT 2008


Gary Benson wrote:
> Andrew Haley wrote:
>> -    : IRBuilder(),
>> +  : IRBuilder<>(),
> ...
>> -class SharkBuilder : public llvm::IRBuilder {
>> +class SharkBuilder : public llvm::IRBuilder<> {
> ...
>> -  llvm::Value* intptr_value(llvm::IRBuilder* builder) const
>> +  llvm::Value* intptr_value(llvm::IRBuilder<>* builder) const
> 
> This patch breaks the build for older g++s.  Is there any way it can
> be made to work for all?

Hmm, I wonder why it breaks.  I'd try inserting the default template
arguments.  I think they were something like <true, llvm::something>.

Andrew.



More information about the distro-pkg-dev mailing list