[patch] Support New NIO in IcedTea

[Mark Wielaard]

Hi Chris,

On Sun, 2008-08-31 at 12:40 +1200, C. K. Jester-Young wrote:
> Attached is my patch for building New NIO [1] (aka NIO2) on IcedTea.
> Many thanks to Andrew John Hughes for the -b33 patches for IcedTea, and
> for the --with-project support; these helped cut down the size of my
> patch by two-thirds. :-)
> 
> The main ``meat'' of the patch is icedtea-nio2-genfiles.patch; this
> patches up the pre-generated NIO files so that they reflect the changes
> made in the NIO2 repository.

Nice idea. I wasn't aware that NIO2 was progressing already. I now see
that my ignorance was partly because it seems this work is done in the
nio/nio forest instead of in the jdk7/nio2 forest. Do you know how they
relate?

Also, how do you keep track of which commits are really nio2 related and
which ones are the commits that just sync with the master jdk7 repo? It
would be nice to have an easy way to see just those changes/commits made
for the new nio support.

> As I'm writing this, I'm currently building against nio2-b94; I have got
> these patches working with nio2-b93 in the past, so if the -b94 build
> breaks, I'll send more patches. Meanwhile, hopefully this gives readers
> something to play with. :-)

Do you need any special tag to get that tag? While building with your
patch applied and doing just:
autoreconf --force --install \
  && ./configure --enable-hg --with-project=nio2 \
  && make

I got:
	  /home/mark/src/icedtea/bootstrap/jdk1.6.0/bin/javac  -g \
	    -d lib/hotspot-tools \
	    -source 1.5 \
	    -sourcepath \
	      'hotspot-tools:openjdk/jdk/src/share/classes:openjdk/jdk/src/solaris/classes:openjdk/langtools/src/share/classes:openjdk/jaxp/src/share/classes:openjdk/corba/src/share/classes:openjdk/jaxws/src/share/classes:/home/mark/src/icedtea/generated:/home/mark/src/icedtea/rt' \
	    -bootclasspath '' @hotspot-tools-source-files.txt ; \
	fi
incorrect classpath: hotspot-tools/com/sun/codemodel/internal/ClassType.java
----------
1. ERROR in /home/mark/src/icedtea/openjdk/jdk/src/share/classes/java/nio/channels/spi/AbstractInterruptibleChannel.java (at line 144)
	public void disableInterruptor(AbstractInterruptibleChannel ch) {
	            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
The method disableInterruptor(AbstractInterruptibleChannel) of type new JavaNioChannelsSpiAccess(){} must override a superclass method
----------
1 problem (1 error)make: *** [stamps/hotspot-tools-class-files.stamp] Error 255

Did I get the wrong nio tree, or did I apply the patch wrongly?

> I'm not entirely sure of the legal requirements for patches to be
> accepted into IcedTea. I have already signed the SCA, so if that's all
> that's needed, then that's great!

There are no real legal requirements except for making sure every
contribution is free software. But it is encouraged to push anything
upstream into openjdk of course to keep divergence as low as possible.

Thanks for working on this, nio2 is very exciting.

Cheers,

Mark