changeset in /hg/icedtea6: 2008-12-21 Matthias Klose <doko at ubu...

[Mark Wielaard]

Hi Matthias,

On Sun, 2008-12-21 at 14:54 +0000, doko at ubuntu.com wrote:
> +2008-12-21  Matthias Klose  <doko at ubuntu.com>
> +
> +	* Makefile.am (ICEDTEA_ENV, ICEDTEA_ENV_GCJ): Prepend directories
> +	to PATH, don't replace PATH.
> +

Good catch.

> diff -r a530e095f65b -r c10244d778ac Makefile.am
> --- a/Makefile.am	Fri Dec 19 09:39:44 2008 -0500
> +++ b/Makefile.am	Sun Dec 21 15:53:12 2008 +0100
> @@ -150,7 +150,7 @@ ICEDTEA_ENV = \
>          "JRE_RELEASE_VERSION=1.6.0_$(COMBINED_VERSION)" \
>  	"MILESTONE=fcs" \
>  	"LANG=C" \
> -	"PATH=$(abs_top_builddir)/bootstrap/jdk1.6.0/bin:/usr/bin:/bin:/usr/sbin:/sbin" \
> +	"PATH=$(abs_top_builddir)/bootstrap/jdk1.6.0/bin:/usr/bin:/bin:/usr/sbin:/sbin:$$PATH" \
>  	"ALT_BOOTDIR=$(ICEDTEA_BOOT_DIR)" \
>  	"ALT_BINARY_PLUGS_PATH=$(abs_top_builddir)/bootstrap/jdk1.7.0" \
>  	"BUILD_ARCH_DIR=$(BUILD_ARCH_DIR)" \

In this case, shouldn't we also remove the /usr/bin:/bin:/usr/sbin:/sbin
prepending? It seems that either those are already on the users PATH, or
they overrode their PATH explicitly to include some binaries that would
override some of the standard binaries.

Cheers,

Mark