changeset in /hg/icedtea6: 2008-12-21 Matthias Klose <doko at ubu...

[Andrew John Hughes]

2008/12/22 Matthias Klose <doko at ubuntu.com>:
> Mark Wielaard schrieb:
>> Hi Matthias,
>>
>> On Sun, 2008-12-21 at 14:54 +0000, doko at ubuntu.com wrote:
>>> +2008-12-21  Matthias Klose  <doko at ubuntu.com>
>>> +
>>> +    * Makefile.am (ICEDTEA_ENV, ICEDTEA_ENV_GCJ): Prepend directories
>>> +    to PATH, don't replace PATH.
>>> +
>>
>> Good catch.
>>
>>> diff -r a530e095f65b -r c10244d778ac Makefile.am
>>> --- a/Makefile.am    Fri Dec 19 09:39:44 2008 -0500
>>> +++ b/Makefile.am    Sun Dec 21 15:53:12 2008 +0100
>>> @@ -150,7 +150,7 @@ ICEDTEA_ENV = \
>>>          "JRE_RELEASE_VERSION=1.6.0_$(COMBINED_VERSION)" \
>>>      "MILESTONE=fcs" \
>>>      "LANG=C" \
>>> -    "PATH=$(abs_top_builddir)/bootstrap/jdk1.6.0/bin:/usr/bin:/bin:/usr/sbin:/sbin" \
>>> +    "PATH=$(abs_top_builddir)/bootstrap/jdk1.6.0/bin:/usr/bin:/bin:/usr/sbin:/sbin:$$PATH" \
>>>      "ALT_BOOTDIR=$(ICEDTEA_BOOT_DIR)" \
>>>      "ALT_BINARY_PLUGS_PATH=$(abs_top_builddir)/bootstrap/jdk1.7.0" \
>>>      "BUILD_ARCH_DIR=$(BUILD_ARCH_DIR)" \
>>
>> In this case, shouldn't we also remove the /usr/bin:/bin:/usr/sbin:/sbin
>> prepending? It seems that either those are already on the users PATH, or
>> they overrode their PATH explicitly to include some binaries that would
>> override some of the standard binaries.
>
> sure, we can do this. otoh it doesn't help much to override the default tools.
> the build system uses absolute paths for many binaries in several places. you
> can change the prefix for these commands, but can't unset the prefix to use the
> default location (this is COMPILER_PATH, DEVTOOLS_PATH, UNIXCCS_PATH,
> USRBIN_PATH). So although you might want to use the first tool found in PATH,
> the OpenJDK build system overwrites your settings. Maybe this is necessary on
> Solaris where you have BSD and sysv binaries in different places and only find a
> K&R C Compiler in the standard PATH, but this shouldn't be necessary on Linux.
>
>  Matthias
>
>


What bug does this patch fix?
-- 
Andrew :-)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8