[patch] generated files out of date?

[Lillian Angel]

Francis Kung wrote:
> Lillian Angel wrote:
>> Matthias Klose wrote:
>>> After a rebuild (on amd64) the generated files differ from what is 
>>> checked in.
>>> Should these files be updated?
>>
>> I checked this on i386 and x86_64, and this file remains unchanged.
> 
> It doesn't really matter, as icedtea/generated/* isn't used in any 
> practical sense - they are essentially stubs needed to compile the plug 
> replacements.  Later in the build, all these files are re-generated 
> properly by the OpenJDK build system and the new files are the ones that 
> make it into the final product.
> 
> It's possible to run the OpenJDK generation script to create 
> icedtea/generated/* in the first place, rather than committing files 
> from one specific build, but the generation process was pretty messy 
> last time I looked (granted, many months ago) and I don't know if it's 
> worth the effort.

Agreed. We have been committing them for sake of order. When running 
"hg status" it is nicer to see *only* the files you have modified, 
rather than all those the build has modified.

We have it set up so OpenJDK generates all files into 
icedtea/generated/, but unfortunately most include a date/time stamp 
which gets changed with each build. Therefore, we still need to commit 
these files (initially); there are patches in icedtea/patches that 
remove the date/time stamp from the scripts generating these files.

Lillian