very slow icedtea6 builds

[Matthias Klose]

Andrew John Hughes schrieb:
> On 02/07/2008, Lillian Angel <langel at redhat.com> wrote:
>>
>>  Andrew John Hughes wrote:
>>
>>> On 02/07/2008, Andrew John Hughes <gnu_andrew at member.fsf.org> wrote:
>>>
>>>> On 02/07/2008, Andrew John Hughes <gnu_andrew at member.fsf.org> wrote:
>>>>  > On 02/07/2008, Andrew John Hughes <gnu_andrew at member.fsf.org> wrote:
>>>>  >  > On 02/07/2008, Andrew John Hughes <gnu_andrew at member.fsf.org>
>> wrote:
>>>>  >  >  > 2008/7/2 Gary Benson <gbenson at redhat.com>:
>>>>  >  >  >
>>>>  >  >  > > Gary Benson wrote:
>>>>  >  >  >  >> Can you try with the attached patch?
>>>>  >  >  >  >
>>>>  >  >  >  > Yeah...
>>>>  >  >  >
>>>>  >  >  >
>>>>  >  >  > I've just set it going and I'll let you know what comes out the
>> other end.
>>>>  >  >  >  From the patch though, it looks like the right fix.  The
>> original implies
>>>>  >  >  >  that core is enabled whenever shark isn't whereas it should
>> only be
>>>>  >  >  >  enabled if the build is also not x86/x86_64/sparc.
>>>>  >  >  >
>>>>  >  >  > --
>>>>  >  >  >  Andrew :-)
>>>>  >  >  >
>>>>  >  >  >  Support Free Java!
>>>>  >  >  >  Contribute to GNU Classpath and the OpenJDK
>>>>  >  >  >  http://www.gnu.org/software/classpath
>>>>  >  >  >  http://openjdk.java.net
>>>>  >  >  >
>>>>  >  >  >  PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
>>>>  >  >  >  Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
>>>>  >  >  >
>>>>  >  >
>>>>  >  >
>>>>  >  > Sorry doesn't seem to solve the issue here or for doko... I'll try
>> and
>>>>  >  >  look into it myself later.
>>>>  >  >
>>>>  >  > --
>>>>  >  >  Andrew :-)
>>>>  >  >
>>>>  >  >  Support Free Java!
>>>>  >  >  Contribute to GNU Classpath and the OpenJDK
>>>>  >  >  http://www.gnu.org/software/classpath
>>>>  >  >  http://openjdk.java.net
>>>>  >  >
>>>>  >  >  PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
>>>>  >  >  Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8
>>>>  >  >
>>>>  >
>>>>  >
>>>>  > I think I spotted the issue, will retry.
>>>>  >  Just one alteration to your patch:
>>>>  >
>>>>  >  +  elif test "x${use_zero}" = "xyes"; then
>>>>  >
>>>>  >  instead of using test "x${ZERO_BUILD_TRUE}" = "x"
>>>>  >
>>>>  >
>>>>  >  --
>>>>  >
>>>>  > Andrew :-)
>>>>  >
>>>>  >  Support Free Java!
>>>>  >  Contribute to GNU Classpath and the OpenJDK
>>>>  >  http://www.gnu.org/software/classpath
>>>>  >  http://openjdk.java.net
>>>>  >
>>>>  >  PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
>>>>  >  Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8
>>>>  >
>>>>
>>>>
>>>> Ok that didn't work, but I think it may be a case of twisti's cacao
>>>>  changes taking place while you were working on Shark...
>>>>
>>>>  Your checks probe ${CACAO} but I can only see ${WITH_CACAO} being
>> defined...
>>>> --
>>>>
>>>> Andrew :-)
>>>>
>>>>  Support Free Java!
>>>>  Contribute to GNU Classpath and the OpenJDK
>>>>  http://www.gnu.org/software/classpath
>>>>  http://openjdk.java.net
>>>>
>>>>  PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
>>>>  Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8
>>>>
>>>>
>>> That appears to have worked based on the resulting Makefile, so I
>>> checked in the attached fix:
>>>
>>> 2008-07-02  Andrew John Hughes  <gnu_andrew at member.fsf.org>
>>>
>>>        * acinclude.m4:
>>>        Switch ${CACAO} for ${WITH_CACAO} in
>>>        Shark/core/zero rules and use ${use_zero}
>>>        instead of ${ZERO_BUILD_TRUE}.
>>>        * aclocal.m4,
>>>        * configure:
>>>        Regenerated.
>>>
>>> 2008-07-02  Gary Benson  <gbenson at redhat.com>
>>>
>>>        * acinclude.m4:
>>>        Fix detection of Shark/core build.
>>>        * aclocal.m4,
>>>        * configure:
>>>        Regenerated.
>>>
>>>
>>> Please check I didn't break cacao or zero though!
>>>
>>
>>  Thanks so much for fixing this.
>>
>>
>>  Lillian
>>
> 
> No problem, I was kind of annoyed myself when my build went from 10
> minutes to over 2 hours the other night... :)
> 
> Hey, at least Gary's work got a lot of much deserved testing over the
> last week...

heh, a shark choking on cacao. thanks for finding that.

  Matthias