[patch] Use jar `cat file-list` not gjar -@ stdin extension

Andrew John Hughes gnu_andrew at member.fsf.org
Sun Jun 1 09:45:35 PDT 2008


On 30/05/2008, Mark Wielaard <mark at klomp.org> wrote:
> Hi Martin,
>
>
>  On Fri, 2008-05-30 at 11:39 -0700, Martin Buchholz wrote:
>  > On Fri, May 30, 2008 at 7:13 AM, Mark Wielaard <mark at klomp.org> wrote:
>  > > There was some concern that the command line would have some limit that
>  > > might overflow. But this doesn't seem an issue on modern GNU/Linux (or
>  > > OpenSolaris) systems.
>  >
>  > I share that concern.  Although very recent Linux
>  > kernels might have no command line length limit,
>  > today essentially every OS has such a limit,
>  > and I consider it a bug to depend on its magnitude.
>
>
> Yeah, I agree it isn't the most beautiful thing to do. But there doesn't
>  seem to be another way given that the different jar utility
>  implementations being used for bootstrapping icedtea don't all currently
>  support the same set of options.
>
>  I see I forgot to add the link to the patch that should go into gjar to
>  support the @file arguments like the openjdk jar implementation does:
>  http://svn.debian.org/viewsvn/gcccvs/branches/sid/gcc-4.3/debian/patches/libjava-jar.dpatch?view=markup
>
>  When that goes in and we can kind of rely on systems shipping it by
>  default we could reverse this and depend on @file everywhere I hope.
>
>  Cheers,
>
>
>  Mark
>
>

I think there's a better way of patching this bug than implementing
parsing the @file from scratch as the linked patch does.  I'd rather
we reused the existing stdin support by generalising it to read from a
list of files in addition to stdin.

I'll look into rolling a patch for this.
-- 
Andrew :-)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8



More information about the distro-pkg-dev mailing list