PING: RFC: JScheme fix (PR icedtea/140)

[Andrew John Hughes]

2008/6/16 Mark Wielaard <mark at klomp.org>:
> Hi Andrew,
>
> On Mon, 2008-06-16 at 04:11 +0100, Andrew John Hughes wrote:
>> On 10/06/2008, Andrew John Hughes <gnu_andrew at member.fsf.org> wrote:
>> > The attached patch removes the dependency on JScheme, replacing the
>> >  Scheme script with a Java equivalent.
>> >
>> >  I've bootstrapped this on x86_64.  Okay to commit?
>>
>> Any comments?
>
> yeah, sorry. We discussed this a bit on irc. I like it.
>

That's ok.  I'd forgotten I'd only RFCed it myself.

> The fact that, apart from the headers the generated files are the same
> is very encouraging. Also good to see the icedtea-ecj.patch cleaned up
> (although a Changelog entry would have helped getting a better idea what
> was going on).

It doesn't fully cleanup the icedtea-ecj patch, just alters it
slightly so the existing changes to that
bit of the tree are either removed (mc.scm is no longer patched as it
gets removed anyway) or remade
(the removal of the corresponding Makefile needs a new patch because
the Makefile changes due
to the jscheme patch).

I thought I had included a ChangeLog, sorry.  I'm pretty sure I have
one on my tree.  The changes are simply:

* Add icedtea-jscheme.patch which adds the new Java code and a new
Makefile, as well as hooking that
Makefile into the build in corba/tools.
* Add the patch to configure.ac along with removal of jscheme.jar.
* Fix icedtea-ecj.patch as described above.

> Do you plan to push this upstream?
>

Yes, that's the plan.  I need to roll another patch against OpenJDK hg to do so.

> Thanks,
>
> Mark
>
>

Thanks,
-- 
Andrew :-)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8