broken make clean-patch?

Christian Thalinger twisti at complang.tuwien.ac.at
Thu Mar 27 05:52:33 PDT 2008


On Thu, 2008-03-27 at 13:13 +0100, Christian Thalinger wrote:
> /bin/sh: -c: line 1: syntax error near unexpected token
> `all_patches_ok=yes'
> /bin/sh: -c: line 1: `all_patches_ok=yes; \'
> make: *** [clean-patch] Error 2

This patch fixes it.

diff -r fc06aaf1e991 Makefile.am
--- a/Makefile.am       Thu Mar 27 08:58:31 2008 +0000
+++ b/Makefile.am       Thu Mar 27 13:51:01 2008 +0100
@@ -324,8 +324,8 @@ stamps/patch.stamp: stamps/extract.stamp
 
 clean-patch:
        rm -f stamps/patch.stamp
+       all_patches_ok=yes; \
        for p in $(ICEDTEA_PATCHES) ; \
-       all_patches_ok=yes; \
        do \
          echo Checking $$p ; \
          if $(PATCH) -l -p0 -R --dry-run -s -t -f < $$p ; \

Could someone else commit it?  When I do it, I have to commit a number
of other regenerated files because I have automake-1.10.1.

Btw, why are the generated files in the repository?

- twisti




More information about the distro-pkg-dev mailing list