changeset in /hg/icedtea: 2008-05-21 Lillian Angel <langel at red...

[Lillian Angel]

Mark Wielaard wrote:
> Hi Lillian,
>
> On Wed, 2008-05-21 at 13:41 +0000, Lillian Angel wrote:
>   
>> changeset aeba6ca27fc7 in /hg/icedtea
>> details: http://icedtea.classpath.org/hg/icedtea?cmd=changeset;node=aeba6ca27fc7
>> description:
>> 	2008-05-21  Lillian Angel  <langel at redhat.com>
>>
>> 	        * .hgignore: Updated.
>> 	        * Makefile.am: Updated to build with ecj properly.
>> 	        * Makefile.in: Regenerated.
>> 	        * aclocal.m4: Likewise.
>> 	        * configure: Likewise.
>> 	        * javac.in: Changed to use 1.6 source.
>>     
>
> Was that last change to 1.6 necessary? It makes building with a gcj that
> doesn't support the 1.6 target classes impossible (like on fedora 8).
>
> I tested on Fedora 8 and Fedora 9 with that last change reverted (and
> explicitly marking -source 1.5 in Makefile.am - -source 1.6 isn't
> actually a valid/meaningful value since there were no java language
> changes between 1.5 and 1.6). And it build fine now on both platform. So
> for now I have made this change:
>
> 2008-05-25  Mark Wielaard  <mark at klomp.org>
>
>         * Makefile.am: Use -source 1.5 whenever possible.
>         * Makefile.in: Regenerated.
>         * javac.in: Use -1.5.
>
> Please let us on older platforms know if you really need to upgrade to
> 1.6 for some reason, then we can see if we can find some solution for
> making the build work when using a 1.5 only runtime.


This change is fine, feel free to revert it.


Thanks,
Lillian