ECJ and OpenJDK b26

[Andrew John Hughes]

2008/5/26 Andrew John Hughes <gnu_andrew at member.fsf.org>:
> On 26/05/2008, Joseph D. Darcy <Joe.Darcy at sun.com> wrote:
>> In JDK 6, the behavior of @Override was expanded to include interface
>> methods and not just superclass methods:
>>
>>  http://blogs.sun.com/ahe/entry/override
>>
>>  -Joe
>>
>>
>>  Andrew John Hughes wrote:
>>
>> > I came across a problem compiling
>> javax.management.AttributeValueExp
>> > from b26 with ECJ, due to the addition of the @Override annotation:
>> >
>> > # Running javac:
>> > /usr/bin/ecj -1.5 -nowarn -sourcepath
>> >
>> /home/andrew/projects/openjdk/icedtea/generated:../../../src/solaris/classes:../../../src/share/classes
>> > -bootclasspath
>> /home/andrew/builder/icedtea/bootstrap/jdk1.7.0/jre/lib/rt-closed.jar:/home/andrew/builder/icedtea/bootstrap/jdk1.7.0/jre/lib/tools.jar::/home/andrew/builder/icedtea/openjdk-ecj/build/linux-amd64/classes
>> > -d
>> /home/andrew/builder/icedtea/openjdk-ecj/build/linux-amd64/classes
>> >
>> @/home/andrew/builder/icedtea/openjdk-ecj/build/linux-amd64/tmp/sun/javax.management/.classes.list
>> > ----------
>> > 1. ERROR in
>> ../../../src/share/classes/javax/management/AttributeValueExp.java
>> > (at line 117)
>> >        public ValueExp apply(ObjectName name) throws
>> > BadStringOperationException, BadBinaryOpValueExpException,
>> >        BadAttributeValueExpException, InvalidApplicationException {
>> >
>> >
>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>> > The method apply(ObjectName) of type AttributeValueExp must override a
>> > superclass method
>> > ----------
>> > 2. ERROR in
>> ../../../src/share/classes/javax/management/AttributeValueExp.java
>> > (at line 154)
>> >        public void setMBeanServer(MBeanServer s)  {
>> >                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>> > The method setMBeanServer(MBeanServer) of type AttributeValueExp must
>> > override a superclass method
>> >
>> > ecj seems to be applying @Override only to superclasses and not to
>> > interfaces (these methods are specified in the interface
>> > javax.management.ValueExp).
>> >
>> > Is this a bug in ECJ (3.3.0) or is javac overlooking this and
>> > @Override should only be used with superclasses?
>> >
>>
>>
>
> Ah, ok then as I thought it's an issue with the compiler and/or
> options being used.
> I'll test with ecj and -source 1.6 and see if this works.
> --
> Andrew :-)
>
> Support Free Java!
> Contribute to GNU Classpath and the OpenJDK
> http://www.gnu.org/software/classpath
> http://openjdk.java.net
>
> PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
> Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8
>

I found the bug in ECJ:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=141931

It was fixed in 3.3 and 3.2.2.  This doesn't help us with IcedTea as
many distributions don't ship this new a version.
So we should continue to patch it.

I was doing this just for the ecj build, but it seems building on
Debian x86 pulls this file in earlier, before the OpenJDK build:

if ! test -f stamps/icedtea-ecj.stamp ; \
        then \
          /usr/bin/ecj -nowarn  -g -d lib/rt -bootclasspath '' -source 1.6 \
          -sourcepath
'generated:rt:openjdk/jdk/src/share/classes:openjdk/jdk/src/solaris/classes:openjdk/langtools/src/share/classes:openjdk/jaxp/src/share/classes\
:openjdk/corba/src/share/classes:openjdk/jaxws/src/share/classes:/builder/projects/icedtea/generated:/builder/projects/icedtea/rt'
\
          @rt-source-files.txt ; \
        else \
          /builder/builder/icedtea/bootstrap/jdk1.6.0/bin/javac  -g -d lib/rt \
          -bootclasspath '' -source 1.6 \
          -sourcepath
'generated:rt:openjdk/jdk/src/share/classes:openjdk/jdk/src/solaris/classes:openjdk/langtools/src/share/classes:openjdk/jaxp/src/share/classes\
:openjdk/corba/src/share/classes:openjdk/jaxws/src/share/classes:/builder/projects/icedtea/generated:/builder/projects/icedtea/rt'
\
          @rt-source-files.txt ; \
        fi
incorrect classpath:
----------
1. ERROR in /builder/builder/icedtea/openjdk/jdk/src/share/classes/javax/management/AttributeValueExp.java
(at line 117)
        public ValueExp apply(ObjectName name) throws
BadStringOperationException, BadBinaryOpValueExpException,
        BadAttributeValueExpException, InvalidApplicationException {

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\
^^^^^^^^^^^^^^^
The method apply(ObjectName) of type AttributeValueExp must override a
superclass method
----------
2. ERROR in /builder/builder/icedtea/openjdk/jdk/src/share/classes/javax/management/AttributeValueExp.java
(at line 154)
        public void setMBeanServer(MBeanServer s)  {
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
The method setMBeanServer(MBeanServer) of type AttributeValueExp must
override a superclass method
----------
2 problems (2 errors)make: *** [stamps/rt-class-files.stamp] Error 255

I'll separate it into a separate patch rather than making it part of
icedtea-ecj.patch.

I also found that the patches for zero need updating to build on
ppc64, and we had a lurking srcdir dependency.
So looks like no b26 goodness today :(
-- 
Andrew :-)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8