changeset in /hg/icedtea6: Add IcedTea version to java -version.

[Andrew John Hughes]

2008/11/7 Gary Benson <gbenson at redhat.com>:
> Andrew John Hughes wrote:
>> changeset 829a4250db62 in /hg/icedtea6
>> details: http://icedtea.classpath.org/hg/icedtea6?cmd=changeset;node=829a4250db62
>> description:
>>       Add IcedTea version to java -version.
> [snip]
>> +     if [ -e $(abs_top_srcdir)/.hg ]; then \
>> +       revision="-r`(cd $(srcdir); $(HG) tip --template '{rev}')`" ; \
>> +     fi ; \
>> +     icedtea_version="$(PACKAGE_VERSION)$${revision}" ; \
>> +     sed -i "s#IcedTea6#IcedTea6 $${icedtea_version}#" openjdk/jdk/make/common/shared/Defs.gmk
>
> The number reported by '{rev}' is only meaningful within your own
> repository.  Anyone mind if I change this to '{node|short}'?
>
> Cheers,
> Gary
>
> --
> http://gbenson.net/
>

Well the idea was that these would be the revision numbers of the
IcedTea6 and IcedTea7 repositories, in the same vein as the Subversion
numbers used by gcc.  Do they break in some awful way with Mercurial?
I can see there are issues if you have your own repository with lots
of local commits but the intention was for them to be used against the
main repositories.

My only objection against using the node number instead is that there
then isn't a logical progression between revisions.  One of the
benefits of using rev is that it's clear that one revision is later
than another for the same repository.  But if this makes it a lot
easier to match up a build with a source tree, go for it.
-- 
Andrew :-)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8