changeset in /hg/icedtea6: Add IcedTea version to java -version.

[Mark Wielaard]

On Fri, 2008-11-07 at 14:18 +0000, Gary Benson wrote:
> Andrew John Hughes wrote:
> > 2008/11/7 Gary Benson <gbenson at redhat.com>:
> > > Andrew John Hughes wrote:
> > > > changeset 829a4250db62 in /hg/icedtea6
> > > > details: http://icedtea.classpath.org/hg/icedtea6?cmd=changeset;node=829a4250db62
> > > > description:
> > > >       Add IcedTea version to java -version.
> > > [snip]
> > > > +     if [ -e $(abs_top_srcdir)/.hg ]; then \
> > > > +       revision="-r`(cd $(srcdir); $(HG) tip --template '{rev}')`" ; \
> > > > +     fi ; \
> > > > +     icedtea_version="$(PACKAGE_VERSION)$${revision}" ; \
> > > > +     sed -i "s#IcedTea6#IcedTea6 $${icedtea_version}#" openjdk/jdk/make/common/shared/Defs.gmk
> > >
> > > The number reported by '{rev}' is only meaningful within your own
> > > repository.  Anyone mind if I change this to '{node|short}'?
> > 
> > Well the idea was that these would be the revision numbers of the
> > IcedTea6 and IcedTea7 repositories, in the same vein as the
> > Subversion numbers used by gcc.  Do they break in some awful way
> > with Mercurial?  I can see there are issues if you have your own
> > repository with lots of local commits but the intention was for them
> > to be used against the main repositories.
> 
> I'm not 100% sure but I think the revision numbers are in date order,
> so if someone pushes a bunch of branch commits that interleave with
> the main trunk then the numbers will change.

Yes, in date order of when they got into your local tree. For example we
just crossed commits and rev 1191 for me is on one box:

changeset:   1191:bddf55be4f36
user:        Gary Benson <gbenson at redhat.com>
date:        Fri Nov 07 06:50:49 2008 -0500
summary:     2008-11-07  Gary Benson  <gbenson at redhat.com>

But on another box it is:

changeset:   1191:7175ea5857e4
parent:      1166:5176cf42d236
user:        Mark Wielaard <mark at klomp.org>
date:        Fri Nov 07 13:47:41 2008 +0100
summary:     * patches/icedtea-6761856-freetypescaler.patch: New patch.

So I would say please use '{node|sort}' to make sure they are unique.
(And if 12 hex-digits are still too long, you can probably get away with
just the first 6 with | cut -c-6 and still have unique numbers that you
can feed into all hg commands that take a revision - totally
unscientificly determined by a quick look through my local repos).

Cheers,

Mark