OpenJDK 6 build 12 source posted (directaudio/alsa backend)

Mark Wielaard mark at klomp.org
Thu Nov 20 09:48:43 PST 2008


On Thu, 2008-11-06 at 15:27 +0100, Mark Wielaard wrote:
> Hi Joe, hi Alex,
> 
> On Mon, 2008-09-22 at 12:54 -0700, Joseph D. Darcy wrote:
> > Mark Wielaard wrote:
> > > Although not in your changelogs, I saw you also included two of my fixes
> > > for the ALSA directaudio backend which I posted back in May on
> > > sound-dev, and which are included in icedtea already.
> > > - The sloppy open/close patch:
> > > http://mail.openjdk.java.net/pipermail/sound-dev/2008-May/000053.html
> > > - The ALSA native lock patch:
> > > http://mail.openjdk.java.net/pipermail/sound-dev/2008-May/000054.html
> > >
> > > Although it makes some applets that use some primitive sound output work
> > > better I never got a real response. Did you get someone from the sound
> > > team to look at these patches? They do seem to work for me and the few
> > > test users of those applets, but a full review by one of the sound
> > > engineers would be appreciated. They don't seem to be in the JDK7 tree.
> > >   
> > No; the patches were not explicitly reviewed; Alex, please take a look 
> > at them.
> 
> While these are being reviewed it might be nice if some of the
> additional fixes for the DirectAudio ALSA code that were added by Omair
> were also reviewed:
> 
> - Use the ALSA 'default' device if possible.
>   patches/icedtea-alsa-default-device.patch
> http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2008-November/003844.html
> 
> - Fix linker order:
>   patches/icedtea-linker-libs-order.patch
> http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2008-November/003845.html

Omair told me on irc that that last one more a generic build fix, not
directly just for the sound build itself. So, this might be more
relevant for the build-dev list. But any comments on the other three
patches highly appreciated.

Cheers,

Mark




More information about the distro-pkg-dev mailing list