[PATCH] Integrating a PulseAudio-based Java Mixer in icedtea6

[Andrew John Hughes]

2008/10/10 Mark Wielaard <mark at klomp.org>:
> Hi,
>
> On Thu, 2008-10-09 at 21:47 +0100, Andrew John Hughes wrote:
>> 2008/10/9 Omair Majid <omajid at redhat.com>:
>> > Ioana and I have been working on creating a PulseAudio based Mixer and we
>> > believe that it has become stable enough to include it as an optional build
>> > in icedtea6. To do that, the pulseaudio source code needs to be put in the
>> > pulseaudio folder in icedtea and the attached patch needs to be applied.
>> >
>> > The configure option --enable-pulse-java is used to enable building the
>> > PulseAudio based mixer.
>> >
>> > To compile icedtea with the pulseaudio-based mixer :
>> > (assuming the icedtea-pulseaudio.patch file is in the current directory)
>> >
>> > hg clone http://icedtea.classpath.org/hg/icedtea6
>> > cd icedtea6
>> > # this next step wont be necessary once the pulse-java source code
>> > # is commited to icedtea6
>> > hg clone http://icedtea.classpath.org/hg/pulseaudio
>> > patch -p1 < ../icedtea-pulseaudio.patch
>> > ./autogen.sh
>> > ./configure --enable-pulse-java
>> > make
>> >
>> > Please let me know if there are any concerns, comments or objections.
>>
>> Is the intention for this patch to represent how PulseAudio will be integrated?
>> If so, I assume it won't be part of IcedTea but just an optional dependency?
>
> No, my impression was that we wanted the pulseaudio directory directly
> into the icedtea repo. That would certainly be my preference.
>

Well, I don't really mind either way. If you want to have separate releases,
it needs to be outside the IcedTea repository though.

I expect we'll always be able to turn it off.

> The only thing we need to think about is whether we also want to carry
> over the revision history or that we keep around the pulseaudio repo for
> historical reasons. I don't immediately know how easy it is to carry
> over the changesets from one repo to a completely separate one.
> Omair, Ioana, what do you want?
>

hg pull would do the job presumably.

>> Comments:
>>
>> * PULSE_JAVA_DIR should be configurable by a --with-pulse-java-dir option.
>
> But not if we just add the directory to the repo.

Indeed.

>
>> * I assume CC is called explicitly rather than using the usual automake rules
>> (pulseaudio_SOURCES and the like) is because IcedTea itself is a bit
>> non-standard.
>> * The continued use of the test +     if ! test -d $(ICEDTEA_BOOT_DIR) ;
>> is worrying.
>> I was already concerned about this from the current ecj invocations.
>> Can we not just
>> depend on the creation of the boot directory for targets that need it?
>>  Users tend to find
>> this confusing as it is unclear at runtime which javac/jar/javah is
>> being used and the duplication
>> can lead to inaccuracies.
>
> What would the "correct" way be to express this in the Makefile.am?
>

Depend on $(BOOTSTRAP_DIRECTORY_STAMP) as visualvm does.

>> Thanks for the contribution!
>
> Yes, I like to see this go in. I already tested it a bit and it seems to
> work nicely.
>
> Cheers,
>
> Mark
>
>
-- 
Andrew :-)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8