changeset in /hg/icedtea6: * Makefile.am (EXTRA_DIST): Always in...

[Mark Wielaard]

Hi Andrew,

On Thu, 2008-10-16 at 09:23 +0100, Andrew John Hughes wrote:
> 2008/10/15 Mark Wielaard <mark at klomp.org>:
> > changeset d3bdd63d63d1 in /hg/icedtea6
> > details: http://icedtea.classpath.org/hg/icedtea6?cmd=changeset;node=d3bdd63d63d1
> > description:
> >        * Makefile.am (EXTRA_DIST): Always include all patches,
> >                irrespective of any configure options.
>
> Is there going to be another release?  The current tarball is unbuildable for
> an ecj build:
> 
> Checking patches/icedtea-ecj.patch
> /bin/sh: line 8:
> /var/tmp/portage/dev-java/icedtea6-1.3-r1/work/icedtea6-1.3/patches/icedtea-ecj.patch:
> No such file or directory
> ERROR patch patches/icedtea-ecj.patch FAILED!

O, that is bad. This wasn't exactly what the patch was for. It was to
make sure the shark specific patches (and any conditionally patch lists)
would all be included. I see why this happened. ICEDTEA_ECJ_PATCH was
renamed to ICEDTEA_ECJ_PATCHES except in EXTRA_DIST. My patch would also
help with that.

Creating a new release seems like a good idea, to make sure all files
are included.

I haven't tried if make distcheck works. That is always a good thing to
be sure the dist tar ball is complete. But sometimes hard to get working
for the first time.

Cheers,

Mark