changeset in /hg/icedtea6: - Replace TCP/IP model with fifo pipes

[Deepak Bhole]

* Matthew Flaschen <matthew.flaschen at gatech.edu> [2008-10-18 15:10]:
> Deepak Bhole wrote:
> > changeset 2262032cc2ae in /hg/icedtea6
> > details: http://icedtea.classpath.org/hg/icedtea6?cmd=changeset;node=2262032cc2ae
> > description:
> > 	- Replace TCP/IP model with fifo pipes
> > 	- Improved performance
> > 	- Centralize debugging, subject to environment variable ICEDTEAPLUGIN_DEBUG
> > 	- Improved security by using per context privileges, rather than consulting
> > 	  security manager.
> > 	- Add code for better panel resizing.
> 
> In the below code, you're dividing an int
> (atts.get("height/widthPercentage")) by a larger or equal int, which is
> always going to return 0 or 1.
> 
> I think proposedHeightFactor and proposedWidthFactor should be doubles,
> and 100 should be 100.0.
> 
> Matt Flaschen
> 
> ------------------------------------------------------------------------------
> 
> if (atts.get("heightPercentage") != null) {
>         	 proposedHeightFactor = (Integer) atts.get("heightPercentage")/100;
>          }
> 
> if (((String) atts.get("width")).endsWith("%")) {
>         	 proposedWidthFactor = (Integer) atts.get("widthPercentage")/100;
>          }


Doh! Can't believe I missed that. That part is still WIP, but it was a
bug nonetheless. It is now fixed, and I tested it to make sure. Nice
catch, and thanks!

Deepak