changeset in /hg/icedtea6: * Makefile.am (EXTRA_DIST): Always in...

[Mark Wielaard]

Hi Andrew,

On Mon, 2008-10-20 at 10:47 +0100, Andrew John Hughes wrote:
> >> Is there going to be another release?  The current tarball is unbuildable for
> >> an ecj build:
> >>
> >> Checking patches/icedtea-ecj.patch
> >> /bin/sh: line 8:
> >> /var/tmp/portage/dev-java/icedtea6-1.3-r1/work/icedtea6-1.3/patches/icedtea-ecj.patch:
> >> No such file or directory
> >> ERROR patch patches/icedtea-ecj.patch FAILED!
> >
> > O, that is bad. This wasn't exactly what the patch was for. It was to
> > make sure the shark specific patches (and any conditionally patch lists)
> > would all be included. I see why this happened. ICEDTEA_ECJ_PATCH was
> > renamed to ICEDTEA_ECJ_PATCHES except in EXTRA_DIST. My patch would also
> > help with that.
>
> Ok, the name change is my fault, I thought I'd changed it there.
> Anyway, the more general
> fix you've applied is the correct one, otherwise the contents of the
> release tarball depend on how
> things are configured when make dist is run.  So Shark is presumably
> missing from the current one
> too.  I count 77 patches in the tarball and 87 in hg.

Yes, that was why I made the patch, I saw the missing patches and wanted
to make sure they were always included.

> > Creating a new release seems like a good idea, to make sure all files
> > are included.
> >
> I hope this is what Lillian had planned when she changed the tree to 1.3.1.

I don't know of any plans for an quick fixup release, but it sounds like
a good idea to me. It could also include a couple (all) of the other
fixes since 1.3 and making the IcedTeaPlugin the default.

> > I haven't tried if make distcheck works. That is always a good thing to
> > be sure the dist tar ball is complete. But sometimes hard to get working
> > for the first time.
> 
> I've had make distcheck run to the point of doing the tests before, so
> this wouldn't
> be the first run.  Currently it stumbles over the -bootclasspath
> issue, at least for me.
> I know there are bugs in the pulseaudio config (fixed in icedtea, I'll
> backport) that prevent
> out-of-dir builds.

A ./autogen.sh && ./configure && make distcheck now works up to the make
check stage (still running). So that part is good to go now.

>   Ideally make distcheck should be run with most
> things enabled, but I don't
> have NetBeans to check VisualVM (and I still wonder why that is in
> this tree at all).

I haven't tried having anything enabled besides the default configure
yet.

Cheers,

Mark