Support BSD and Caciocavallo
Andrew John Hughes
gnu_andrew at member.fsf.org
Mon Sep 1 07:11:28 PDT 2008
On 01/09/2008, C. K. Jester-Young <cky944 at gmail.com> wrote:
> Hi Andrew,
>
>
> On Sun, Aug 31, 2008 at 09:01:56PM +0100, Andrew John Hughes wrote:
> > 2008-08-31 Andrew John Hughes <gnu_andrew at member.fsf.org>
> >
> > * Makefile.am:
> > Make enabling hg-only projects sufficient for
> > downloading from hg.
> >
> > This does mean I had to separate out the hg forest check so it wasn't
> > duplicated.
>
>
> I like the idea of the fix, though I think the way it's implemented
> doesn't do what's intended, and is additionally a maintenance hassle
> whenever new Mercurial repositories are added.
>
> Looking at the forest test, it only applies if !OPENJDK_SRC_DIR_FOUND
> && !USE_ALT_OPENJDK_SRC_ZIP && USE_HG && USE_CLOSURES && USE_CVMI &&
> USE_CACIOCAVALLO && USE_BSD. In other words, this test will never be
> invoked.
>
> I propose an alternative patch, that simply turns --enable-hg on if
> --with-project != jdk7. The main caveat is now that the --with-project
> stuff must appear before the --enable-hg. But other than that, I think
> that this is more robust and easier to maintain, and I hope it works
> for you too. :-)
>
> Many thanks,
> ---Chris K.
>
>
This does simplify it quite a bit. Applying with the following
addition from myself:
2008-09-01 Andrew John Hughes <gnu_andrew at member.fsf.org>
* Makefile.am: Simply hgforest
rule and add corresponding clean rule.
2008-09-01 C. K. Jester-Young <cky944 at gmail.com>
* acinclude.m4:
Enable hg by default unless building jdk7.
* configure.ac:
Do project check before hg check.
--
Andrew :-)
Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: implicit_enable_hg.diff
Url: http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20080901/3f0da90e/implicit_enable_hg.diff
More information about the distro-pkg-dev
mailing list