[patch] Support New NIO in IcedTea

[Andrew John Hughes]

2008/9/2 C. K. Jester-Young <cky944 at gmail.com>:
> Hi Andrew,
>
> On Mon, Sep 01, 2008 at 06:16:43PM +0100, Andrew John Hughes wrote:
>> It's not javac, it's ecj.
>
> Ah, thank you. I looked through the build scripts and noticed that
> whatever compiler is used, there's a symlink called jdk1.6.0 that
> points to it, so the jdk1.6.0 is no indication of the compiler version
> or type.
>

No it isn't, it's just to fake a JDK for the build.  For an ecj build, it will
be a javac generated from javac.in against the ecj.jar it finds.  For an IcedTea
build, it will be symlinked to javac.

>> > This is very odd. The first line in hotspot-tools-source-files.txt is
>> >  indeed hotspot-tools/com/sun/codemodel/internal/ClassType.java, which
>> >  means that whatever make system you have is not passing the '' argument
>> >  before it. Either that, or the javac you have is disregarding it.
>>
>> Could be the opening " after bootclasspath without a closing one.
>
> That's two single quotes, not a double quote, so it should represent an
> empty string.

Sorry, hard to tell with whatever font GMail is using...

Nonetheless, I'm testing it with ecj now and I'm seeing
> the same message. I'll be investigating this further once I have a
> complete build (by doing all the @Override stripping).
>
>> Yes, patches/icedtea-override.patch.  Which compiler are you using with IcedTea?
>> The default build should use ecj unless you are building with an
>> existing IcedTea tree (--with-icedtea).
>
> I do all my builds with the OpenJDK supplied with Ubuntu 8.04, thus the
> options I use are --with-openjdk-home=/usr/lib/jvm/java-6-openjdk
> --with-openjdk. I wasn't aware of the default compiler used by IcedTea
> (probably because I'm a control freak that seldom uses defaults as is),
> so thanks for pointing that out.
>

Well that's actually IcedTea.  I'm not sure what the difference is
between --with-openjdk
and --with-icedtea except that the latter is probably more well-tested.

> I'm doing my testing with ecj now; once I have the fixes for that, I'll
> be posting another patch! (The nio2 repository has had more updates
> since, so my new patches are tracking those updates, as well as the
> recent IcedTea6 merges that have occurred---oh, and by the way, thanks
> for applying my implicit-enable-hg patch!)
>

These merges are fun aren't they... at least we aren't stuck with CVS!

> Many thanks,
>        ---Chris K.
>

Thanks,
-- 
Andrew :-)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8