FYI: Versioning support for IcedTea

[Andrew John Hughes]

2008/9/13 Christian Thalinger <twisti at complang.tuwien.ac.at>:
> On Sat, 2008-09-13 at 02:47 +0100, Andrew John Hughes wrote:
>> This patch adds support for reporting the IcedTea
>> version and Mercurial revision from the resulting build:
>>
>> $ ~/builder/icedtea/openjdk/build/linux-amd64/bin/java -version
>> java version "1.7.0_0"
>> IcedTea 1.8-pre-r1223 Runtime Environment (build 1.7.0_0-b35)
>> OpenJDK 64-Bit Server VM (build 1.7.0_0-b35, mixed mode)
>
> That is a very cool patch.  I'll add something similar to CACAO.
>

Thanks!

>> diff -r 15c4a75ee541 Makefile.am
>> --- a/Makefile.am       Sat Sep 13 01:08:32 2008 +0100
>> +++ b/Makefile.am       Sat Sep 13 02:43:32 2008 +0100
>> @@ -252,7 +252,7 @@
>>
>>  # Mercurial snapshot.
>>  snapshot: dist
>> -       mv $(DIST_ARCHIVES) $(distdir)-`hg tip --template '{node}'`.tar.gz
>> +       mv $(DIST_ARCHIVES) $(distdir)-`$(HG) tip --template '{node}'`.tar.gz
>
>> +       if [ -e $(abs_top_srcdir)/.hg ]; then \
>> +         revision="-r`(cd $(srcdir); $(HG) tip|grep changeset|cut -d':' -f2|sed -r 's#\W+##')`" ; \
>> +       fi ; \
>> +       icedtea_version="$(PACKAGE_VERSION)$${revision}" ; \
>> +       sed -i "s#IcedTea#IcedTea $${icedtea_version}#" openjdk/jdk/make/common/shared/Defs.gmk
>
> I wonder, as you're using tip --template already above, why not doing
> this instead of the grep-cut-sed magic:
>
> hg tip --template '{rev}'
>

Because I didn't know about it :)
I saw the existing use of tip --template and tried to find something
suitable.  Unfortunately,
hg's help system proved unhelpful.  Anyway, I'll switch to that.

> - twisti
>
>



-- 
Andrew :-)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8